Skip Menu |
 

This queue is for tickets about the SMS-Send-Smstrade CPAN distribution.

Report information
The Basics
Id: 99586
Status: new
Priority: 0/
Queue: SMS-Send-Smstrade

People
Owner: Nobody in particular
Requestors: dominic [...] s5g.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: No long SMS available / patch attached
Date: Sun, 19 Oct 2014 22:10:34 +0200
To: bug-SMS-Send-Smstrade [...] rt.cpan.org
From: Dominic Sonntag <dominic [...] s5g.de>
Download (untitled) / with headers
text/plain 892b
Hi, I want to the driver for Smstrade to also send long ("concatenated") SMS, but there is a hard-coded substring cutting off everything after the first 160 characters. Take a look at my following patch which should solve this correctly. Thanks Dominic --- Smstrade.pm 2014-10-19 19:58:58.000000000 +0000 +++ Smstrade.pm.patched 2014-10-19 19:56:59.000000000 +0000 @@ -167,7 +167,7 @@ my %params = @_; my $destination = $self->_clean_number($params{to}); - my $message = substr($params{text},0,159); + my $message = $params{text}; my %args = ( 'key' => $self->{_apikey}, @@ -175,6 +175,7 @@ 'to' => $destination, 'route' => $self->{_route}, 'from' => $self->{_from}, + 'concat' => length($message) > 160 ? 1 : 0, 'cost' => 1, 'message_id' => 1, 'count' => 1,


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.