Skip Menu |
 

This queue is for tickets about the Socket CPAN distribution.

Report information
The Basics
Id: 99363
Status: resolved
Priority: 0/
Queue: Socket

People
Owner: Nobody in particular
Requestors: JHI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.016

Attachments
0001-The-tested-code-needs-to-have-its-own-scope.patch



Subject: feature tests need scoping [PATCH]
Download (untitled) / with headers
text/plain 101b
The feature tests introduce variables, which doesn't work with strict C89 settings. Patch attached.
Subject: 0001-The-tested-code-needs-to-have-its-own-scope.patch
From fcd6b8a4cb23e22e894ad96e223c5ef81ba9cc7c Mon Sep 17 00:00:00 2001 From: Jarkko Hietaniemi <jhi@iki.fi> Date: Tue, 7 Oct 2014 20:57:24 +0200 Subject: [PATCH] The tested code needs to have its own scope. Otherwise e.g. declaring variables will die with strict C89. --- cpan/Socket/Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpan/Socket/Makefile.PL b/cpan/Socket/Makefile.PL index 0eadd3f..0198deb 100644 --- a/cpan/Socket/Makefile.PL +++ b/cpan/Socket/Makefile.PL @@ -46,7 +46,7 @@ int main(int argc, char *argv[]) { (void)argc; (void)argv; - $main + { $main } return 0; } EOF -- 2.1.0
Download (untitled) / with headers
text/plain 210b
On Tue Oct 07 17:36:45 2014, JHI wrote: Show quoted text
> The feature tests introduce variables, which doesn't work with strict > C89 settings. Patch attached.
Ahyes, good catch. Pesky non-C99 machines... :/ -- Paul Evans
Released -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.