|Subject:||hspace should be changed to hscale|
|Date:||Tue, 02 Sep 2014 10:31:22 -0400|
|To:||bug-PDF-API2 [...] rt.cpan.org|
|From:||Phil M Perry <philperry [...] hvc.rr.com>|
PDF::API2 v2.022 Perl 5.16.3 Windows 7 severity: Important The 'hspace' method is misnamed. It should be 'hscale'. The old 'hspace' should be deprecated, and eventually removed from the product. It is currently in Content.pm and Resource/XObject/Form/Hybrid.pm. I have sent updated code to the maintainer, adding hscale() and deprecating hspace() in the POD. As a global variable is used to hold the scale value between calls, I renamed it from hspace to hscale, including within hspace(). This should not be a problem, unless someone chose to directly access the hspace internal variable, which no longer exists. The alternative would be to keep both hscale and hspace variables, and copy one to the other whenever it's changed, which would be a lot of work.