Skip Menu |
 

This queue is for tickets about the PDF-API2 CPAN distribution.

Report information
The Basics
Id: 98534
Status: resolved
Priority: 0/
Queue: PDF-API2

People
Owner: Nobody in particular
Requestors: philperry [...] hvc.rr.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.026



Subject: hspace should be changed to hscale
Date: Tue, 02 Sep 2014 10:31:22 -0400
To: bug-PDF-API2 [...] rt.cpan.org
From: Phil M Perry <philperry [...] hvc.rr.com>
Download (untitled) / with headers
text/plain 777b
PDF::API2 v2.022 Perl 5.16.3 Windows 7 severity: Important The 'hspace' method is misnamed. It should be 'hscale'. The old 'hspace' should be deprecated, and eventually removed from the product. It is currently in Content.pm and Resource/XObject/Form/Hybrid.pm. I have sent updated code to the maintainer, adding hscale() and deprecating hspace() in the POD. As a global variable is used to hold the scale value between calls, I renamed it from hspace to hscale, including within hspace(). This should not be a problem, unless someone chose to directly access the hspace internal variable, which no longer exists. The alternative would be to keep both hscale and hspace variables, and copy one to the other whenever it's changed, which would be a lot of work.
Patched. Will be included in the next release.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.