This queue is for tickets about the IO-Socket-IP CPAN distribution.

Report information
The Basics
Id:
98494
Status:
rejected
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
aixtools [...] gmail.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



CC: Steve Hay <steve.m.hay@googlemail.com>
Subject: "issues" with tests for IO-Socket-IP and AIX 5.3 - basic PATCH included
Date: Sun, 31 Aug 2014 22:32:48 +0200
To: bug-IO-Socket-IP@rt.cpan.org
From: Michael Felt <aixtools@gmail.com>
AIX 5.3 - which is frozen in time, and likely the bug is in AIX, fails three tests consistently.

Basically, when creating a new socket and the LocalPort is not defined (zero being assummed, and a local port is to be assigned) the calls fail on AIX 5.3 (These tests pass on AIX 6.1 and AIX 7.1).

I do not see it as a bug in the perl code - the assumption is that LocalPort is zero. I am assuming the code is using "buffer" from the stack, rather than a malloc. However on AIX 5.3, for whatever reason, this assumption is not working (the test passes on AIX 6.1 and AIX 7.1).
It may be that the weakness is in AIX - which will never be updated. However, the current status of the tests causes Test::SMOKE to always report a failure when, basically, perl is passing all tests. It would be great if you at least added or adapted the follwing patch so that AIX 5.3 will pass t/TEST

Many thanks!

PATCH========
root@lp01:[/data/smoker/perl-
current]diff -u cpan/IO-Socket-IP/t.orig cpan/IO-Socket-IP/t
diff -u cpan/IO-Socket-IP/t.orig/02local-server-v4.t cpan/IO-Socket-IP/t/02local-server-v4.t
--- cpan/IO-Socket-IP/t.orig/02local-server-v4.t        2014-08-26 10:46:16.000000000 +0000
+++ cpan/IO-Socket-IP/t/02local-server-v4.t     2014-08-26 10:47:33.000000000 +0000
@@ -27,6 +27,7 @@
     my $testserver = IO::Socket::IP->new(
        ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
        LocalHost => "127.0.0.1",
+       LocalPort => 0,
        Type      => Socket->$socktype,
     );
 
diff -u cpan/IO-Socket-IP/t.orig/
03local-cross-v4.t cpan/IO-Socket-IP/t/03local-cross-v4.t
--- cpan/IO-Socket-IP/t.orig/
03local-cross-v4.t 2014-08-26 10:46:16.000000000 +0000
+++ cpan/IO-Socket-IP/t/03local-
cross-v4.t      2014-08-26 10:47:48.000000000 +0000
@@ -11,6 +11,7 @@
     my $testserver = IO::Socket::IP->new(
        ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
        LocalHost => "127.0.0.1",
+       LocalPort => 0,
        Type      => Socket->$socktype,
     ) or die "Cannot listen on PF_INET - $@";
 
diff -u cpan/IO-Socket-IP/t.orig/
05local-server-v6.t cpan/IO-Socket-IP/t/05local-server-v6.t
--- cpan/IO-Socket-IP/t.orig/
05local-server-v6.t        2014-08-26 10:46:16.000000000 +0000
+++ cpan/IO-Socket-IP/t/05local-
server-v6.t     2014-08-26 10:48:18.000000000 +0000
@@ -33,6 +33,7 @@
     my $testserver = IO::Socket::IP->new(
        ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
        LocalHost => "::1",
+       LocalPort => 0,
        Type      => Socket->$socktype,
        GetAddrInfoFlags => 0, # disable AI_ADDRCONFIG
     );
diff -u cpan/IO-Socket-IP/t.orig/
06local-cross-v6.t cpan/IO-Socket-IP/t/06local-cross-v6.t
--- cpan/IO-Socket-IP/t.orig/
06local-cross-v6.t 2014-08-26 10:46:16.000000000 +0000
+++ cpan/IO-Socket-IP/t/06local-
cross-v6.t      2014-08-26 10:48:31.000000000 +0000
@@ -14,6 +14,7 @@
     my $testserver = IO::Socket::IP->new(
        ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
        LocalHost => "::1",
+       LocalPort => 0,
        Type      => Socket->$socktype,
     ) or die "Cannot listen on PF_INET6 - $@";
 
(seems to be a dupe of RT98640) -- Paul Evans
Subject: Re: [rt.cpan.org #98494] "issues" with tests for IO-Socket-IP and AIX 5.3 - basic PATCH included
Date: Sat, 6 Sep 2014 14:57:45 +0200
To: bug-IO-Socket-IP@rt.cpan.org
From: Michael Felt <aixtools@gmail.com>

I sent it to two people, at least. sorry for any confusion.

On Sep 5, 2014 6:25 PM, "Paul Evans via RT" <bug-IO-Socket-IP@rt.cpan.org> wrote:
Show quoted text
<URL: https://rt.cpan.org/Ticket/Display.html?id=98494 >

(seems to be a dupe of RT98640)

--

Paul Evans
Subject: Re: [rt.cpan.org #98494] "issues" with tests for IO-Socket-IP and AIX 5.3 - basic PATCH included
Date: Sat, 20 Sep 2014 17:14:04 +0200
To: bug-IO-Socket-IP@rt.cpan.org
From: Michael Felt <aixtools@gmail.com>
Got home and started smoking again, and here is an excerpt of my log - after I had added a patch file as part of the smoke process:

This is just the first entry - the patch failed for all 4 because4 it has been patched...

/data/smoker/perl-current now up to patchlevel 5cbc519179d070e5670099e1d22fb729a3652e0f
Get patchinfo from /data/smoker/run/AIX.patchup
Get patch from /data/smoker/patches/02-IO-Socket-IP.t.patch
patching file cpan/IO-Socket-IP/t/02local-server-v4.t
Hunk #1 FAILED at 27.
1 out of 1 hunk FAILED -- saving rejects to file cpan/IO-Socket-IP/t/02local-server-v4.t.rej

Upon examiniation I saw that the patch had added lines:
    Port => 0,
That is:
foreach my $socktype (qw( SOCK_STREAM SOCK_DGRAM )) {
   my $testserver = IO::Socket::IP->new(
      ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
      LocalHost => "127.0.0.1",
      Port      => 0,
      Type      => Socket->$socktype,
   );

My first run of tests failed with:
#   at t/02local-server-v4.t line 40.
cpan/IO-Socket-IP/t/01local-client-v4 ......................... ok
#   Failed test '$testserver->sockhost for SOCK_STREAM'
#   at t/02local-server-v4.t line 40.
#          got: '0.0.0.0'
#     expected: '127.0.0.1'
cpan/IO-Socket-IP/t/02local-server-v4 ......................... FAILED at test 4
Cannot connect on PF_INET - Can't assign requested address at t/03local-cross-v4.t line 18.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 68 just after 6.
cpan/IO-Socket-IP/t/03local-cross-v4 .......................... FAILED--no leader found
cpan/IO-Socket-IP/t/04local-client-v6 ......................... ok
#   Failed test '$testserver->sockdomain for SOCK_STREAM'
#   at t/05local-server-v6.t line 44.
#          got: '2'
#     expected: '24'
cpan/IO-Socket-IP/t/05local-server-v6 ......................... FAILED at test 2
Cannot connect on PF_INET6 - Connection refused at t/06local-cross-v6.t line 21.
cpan/IO-Socket-IP/t/06local-cross-v6 .......................... FAILED--no leader found
cpan/IO-Socket-IP/t/10args .................................... ok
cpan/IO-Socket-IP/t/11sockopts ................................ ok
cpan/IO-Socket-IP/t/12port-fallback ........................... ok
cpan/IO-Socket-IP/t/13addrinfo ................................ ok
cpan/IO-Socket-IP/t/14fileno .................................. ok
cpan/IO-Socket-IP/t/15io-socket ............................... ok
cpan/IO-Socket-IP/t/16v6only .................................. ok
cpan/IO-Socket-IP/t/17gai-flags ............................... ok
cpan/IO-Socket-IP/t/18fdopen .................................. ok
cpan/IO-Socket-IP/t/19no-addrs ................................ ok
cpan/IO-Socket-IP/t/20subclass ................................ ok
cpan/IO-Socket-IP/t/21as-inet ................................. ok
cpan/IO-Socket-IP/t/22timeout ................................. ok
cpan/IO-Socket-IP/t/30nonblocking-connect ..................... ok
cpan/IO-Socket-IP/t/31nonblocking-connect-internet ............ ok
cpan/IO-Socket-IP/t/99pod ..................................... skipped

whereas after reading http://search.cpan.org/~pevans/IO-Socket-IP-0.32/lib/IO/Socket/IP.pm I am sure it should be

my $testserver = IO::Socket::IP->new(
      ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
      LocalHost => "127.0.0.1",
      LocalPort  => "0",
      Type      => Socket->$socktype,
   );

I have updated my AIX.patchup file to apply the following patches


--- cpan/IO-Socket-IP/t/02local-server-v4.t     2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/02local-server-v4.t  2014-09-20 14:31:22 +0000
@@ -27,7 +27,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "127.0.0.1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    );
 
--- cpan/IO-Socket-IP/t/03local-cross-v4.t      2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/03local-cross-v4.t   2014-09-20 14:31:36 +0000
@@ -11,7 +11,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "127.0.0.1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    ) or die "Cannot listen on PF_INET - $@";
 
--- cpan/IO-Socket-IP/t/05local-server-v6.t     2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/05local-server-v6.t  2014-09-20 14:31:58 +0000
@@ -33,7 +33,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "::1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
       GetAddrInfoFlags => 0, # disable AI_ADDRCONFIG
    );

--- cpan/IO-Socket-IP/t/06local-cross-v6.t      2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/06local-cross-v6.t   2014-09-20 14:32:12 +0000
@@ -14,7 +14,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "::1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    ) or die "Cannot listen on PF_INET6 - $@";
 
I will post the results using my patch later.

On Sat, Sep 6, 2014 at 2:57 PM, Michael Felt <aixtools@gmail.com> wrote:
Show quoted text

I sent it to two people, at least. sorry for any confusion.

On Sep 5, 2014 6:25 PM, "Paul Evans via RT" <bug-IO-Socket-IP@rt.cpan.org> wrote:
<URL: https://rt.cpan.org/Ticket/Display.html?id=98494 >

(seems to be a dupe of RT98640)

--

Paul Evans

Subject: Re: [rt.cpan.org #98494] "issues" with tests for IO-Socket-IP and AIX 5.3 - basic PATCH included
Date: Sat, 20 Sep 2014 17:47:32 +0200
To: bug-IO-Socket-IP@rt.cpan.org
From: Michael Felt <aixtools@gmail.com>
Update: short version: the patch needs to be LocalPort => 0, or better LocalPort => "0",

long version:

As is ( Port => 0,)

root@x112:[/data/smoker/perl-current/t]./perl harness ../cpan/IO-Socket-IP/t/*.t
../cpan/IO-Socket-IP/t/00use.t ........................... ok  
../cpan/IO-Socket-IP/t/01local-client-v4.t ............... ok   
../cpan/IO-Socket-IP/t/02local-server-v4.t ............... 1/?
#   Failed test '$testserver->sockhost for SOCK_STREAM'
#   at t/02local-server-v4.t line 40.
#          got: '0.0.0.0'
#     expected: '127.0.0.1'

#   Failed test '$testserver->sockhost for SOCK_DGRAM'
#   at t/02local-server-v4.t line 40.
#          got: '0.0.0.0'
#     expected: '127.0.0.1'
Cannot connect to PF_INET - IO::Socket::INET: connect: Can't assign requested address at t/02local-server-v4.t line 43.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 68 just after 20.
../cpan/IO-Socket-IP/t/02local-server-v4.t ............... Dubious, test returned 68 (wstat 17408, 0x4400)
Failed 2/20 subtests
../cpan/IO-Socket-IP/t/03local-cross-v4.t ................ 1/? Cannot connect on PF_INET - Can't assign requested address at t/03local-cross-v4.t line 18.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 68 just after 6.
../cpan/IO-Socket-IP/t/03local-cross-v4.t ................ Dubious, test returned 68 (wstat 17408, 0x4400)
All 6 subtests passed
../cpan/IO-Socket-IP/t/04local-client-v6.t ............... ok   
../cpan/IO-Socket-IP/t/05local-server-v6.t ...............
../cpan/IO-Socket-IP/t/05local-server-v6.t ............... 1/? #   Failed test '$testserver->sockdomain for SOCK_STREAM'
#   at t/05local-server-v6.t line 44.
#          got: '2'
#     expected: '24'

#   Failed test '$testserver->sockhost for SOCK_STREAM'
#   at t/05local-server-v6.t line 47.
#          got: '0.0.0.0'
#     expected: '::1'
Cannot connect() - Connection refused at t/05local-server-v6.t line 57.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 79 just after 5.
../cpan/IO-Socket-IP/t/05local-server-v6.t ............... Dubious, test returned 79 (wstat 20224, 0x4f00)
Failed 2/5 subtests
../cpan/IO-Socket-IP/t/06local-cross-v6.t ................ Cannot connect on PF_INET6 - Connection refused at t/06local-cross-v6.t line 21.
../cpan/IO-Socket-IP/t/06local-cross-v6.t ................ Dubious, test returned 79 (wstat 20224, 0x4f00)
No subtests run
../cpan/IO-Socket-IP/t/10args.t .......................... ok   
../cpan/IO-Socket-IP/t/11sockopts.t ...................... ok  
../cpan/IO-Socket-IP/t/12port-fallback.t ................. ok  
../cpan/IO-Socket-IP/t/13addrinfo.t ...................... ok  
../cpan/IO-Socket-IP/t/14fileno.t ........................ ok  
../cpan/IO-Socket-IP/t/15io-socket.t ..................... ok  
../cpan/IO-Socket-IP/t/16v6only.t ........................ ok  
../cpan/IO-Socket-IP/t/17gai-flags.t ..................... ok  
../cpan/IO-Socket-IP/t/18fdopen.t ........................ ok  
../cpan/IO-Socket-IP/t/19no-addrs.t ...................... ok   
../cpan/IO-Socket-IP/t/20subclass.t ...................... ok  
../cpan/IO-Socket-IP/t/21as-inet.t ....................... ok  
../cpan/IO-Socket-IP/t/22timeout.t ....................... ok  
../cpan/IO-Socket-IP/t/30nonblocking-connect.t ........... ok  
../cpan/IO-Socket-IP/t/31nonblocking-connect-internet.t .. ok  
../cpan/IO-Socket-IP/t/99pod.t ........................... skipped: Test::Pod 1.00 required for testing POD

Test Summary Report
-------------------
../cpan/IO-Socket-IP/t/02local-server-v4.t             (Wstat: 17408 Tests: 20 Failed: 2)
  Failed tests:  4, 19
  Non-zero exit status: 68
  Parse errors: No plan found in TAP output
../cpan/IO-Socket-IP/t/03local-cross-v4.t              (Wstat: 17408 Tests: 6 Failed: 0)
  Non-zero exit status: 68
  Parse errors: No plan found in TAP output
../cpan/IO-Socket-IP/t/05local-server-v6.t             (Wstat: 20224 Tests: 5 Failed: 2)
  Failed tests:  2, 4
  Non-zero exit status: 79
  Parse errors: No plan found in TAP output
../cpan/IO-Socket-IP/t/06local-cross-v6.t              (Wstat: 20224 Tests: 0 Failed: 0)
  Non-zero exit status: 79
  Parse errors: No plan found in TAP output
Files=23, Tests=162,  9 wallclock secs ( 0.12 usr  0.03 sys +  2.72 cusr  0.25 csys =  3.12 CPU)
Result: FAIL

Apply patches (see below)

root@x112:[/data/smoker/perl-current/t]cd ..
root@x112:[/data/smoker/perl-current]cat ../patches/* | patch -p0            
patching file cpan/IO-Socket-IP/t/02local-server-v4.t
patching file cpan/IO-Socket-IP/t/03local-cross-v4.t
patching file cpan/IO-Socket-IP/t/05local-server-v6.t
patching file cpan/IO-Socket-IP/t/06local-cross-v6.t
root@x112:[/data/smoker/perl-current]cd ..                      
root@x112:[/data/smoker/perl-current]cd -
/data/smoker/perl-current/t

Test again - PASS!!!

root@x112:[/data/smoker/perl-current/t]./perl harness ../cpan/IO-Socket-IP/t/*.t
../cpan/IO-Socket-IP/t/00use.t ........................... ok  
../cpan/IO-Socket-IP/t/01local-client-v4.t ............... ok   
../cpan/IO-Socket-IP/t/02local-server-v4.t ............... ok   
../cpan/IO-Socket-IP/t/03local-cross-v4.t ................ ok   
../cpan/IO-Socket-IP/t/04local-client-v6.t ............... ok   
../cpan/IO-Socket-IP/t/05local-server-v6.t ............... ok   
../cpan/IO-Socket-IP/t/06local-cross-v6.t ................ ok   
../cpan/IO-Socket-IP/t/10args.t .......................... ok   
../cpan/IO-Socket-IP/t/11sockopts.t ...................... ok  
../cpan/IO-Socket-IP/t/12port-fallback.t ................. ok  
../cpan/IO-Socket-IP/t/13addrinfo.t ...................... ok  
../cpan/IO-Socket-IP/t/14fileno.t ........................ ok  
../cpan/IO-Socket-IP/t/15io-socket.t ..................... ok  
../cpan/IO-Socket-IP/t/16v6only.t ........................ ok  
../cpan/IO-Socket-IP/t/17gai-flags.t ..................... ok  
../cpan/IO-Socket-IP/t/18fdopen.t ........................ ok  
../cpan/IO-Socket-IP/t/19no-addrs.t ...................... ok   
../cpan/IO-Socket-IP/t/20subclass.t ...................... ok  
../cpan/IO-Socket-IP/t/21as-inet.t ....................... ok  
../cpan/IO-Socket-IP/t/22timeout.t ....................... ok  
../cpan/IO-Socket-IP/t/30nonblocking-connect.t ........... ok  
../cpan/IO-Socket-IP/t/31nonblocking-connect-internet.t .. ok  
../cpan/IO-Socket-IP/t/99pod.t ........................... skipped: Test::Pod 1.00 required for testing POD
All tests successful.
Files=23, Tests=214, 11 wallclock secs ( 0.11 usr  0.02 sys +  2.28 cusr  0.20 csys =  2.61 CPU)
Result: PASS
root@x112:[/data/smoker/perl-current/t]cd .
root@x112:[/data/smoker/perl-current/t]cd ..

The patches applied (actually 4 files, but that is not relevant)

root@x112:[/data/smoker/perl-current]cat ../patches/*

--- cpan/IO-Socket-IP/t/02local-server-v4.t     2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/02local-server-v4.t  2014-09-20 14:31:22 +0000
@@ -27,7 +27,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "127.0.0.1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    );
 
--- cpan/IO-Socket-IP/t/03local-cross-v4.t      2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/03local-cross-v4.t   2014-09-20 14:31:36 +0000
@@ -11,7 +11,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "127.0.0.1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    ) or die "Cannot listen on PF_INET - $@";
 
--- cpan/IO-Socket-IP/t/05local-server-v6.t     2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/05local-server-v6.t  2014-09-20 14:31:58 +0000
@@ -33,7 +33,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "::1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
       GetAddrInfoFlags => 0, # disable AI_ADDRCONFIG
    );
--- cpan/IO-Socket-IP/t/06local-cross-v6.t      2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/06local-cross-v6.t   2014-09-20 14:32:12 +0000
@@ -14,7 +14,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "::1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    ) or die "Cannot listen on PF_INET6 - $@";
 
root@x112:[/data/smoker/perl-current]

Hope this Helps!

On Sat, Sep 20, 2014 at 5:14 PM, Michael Felt <aixtools@gmail.com> wrote:
Show quoted text
Got home and started smoking again, and here is an excerpt of my log - after I had added a patch file as part of the smoke process:

This is just the first entry - the patch failed for all 4 because4 it has been patched...

/data/smoker/perl-current now up to patchlevel 5cbc519179d070e5670099e1d22fb729a3652e0f
Get patchinfo from /data/smoker/run/AIX.patchup
Get patch from /data/smoker/patches/02-IO-Socket-IP.t.patch
patching file cpan/IO-Socket-IP/t/02local-server-v4.t
Hunk #1 FAILED at 27.
1 out of 1 hunk FAILED -- saving rejects to file cpan/IO-Socket-IP/t/02local-server-v4.t.rej

Upon examiniation I saw that the patch had added lines:
    Port => 0,
That is:
foreach my $socktype (qw( SOCK_STREAM SOCK_DGRAM )) {
   my $testserver = IO::Socket::IP->new(
      ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
      LocalHost => "127.0.0.1",
      Port      => 0,
      Type      => Socket->$socktype,
   );

My first run of tests failed with:
#   at t/02local-server-v4.t line 40.
cpan/IO-Socket-IP/t/01local-client-v4 ......................... ok
#   Failed test '$testserver->sockhost for SOCK_STREAM'
#   at t/02local-server-v4.t line 40.
#          got: '0.0.0.0'
#     expected: '127.0.0.1'
cpan/IO-Socket-IP/t/02local-server-v4 ......................... FAILED at test 4
Cannot connect on PF_INET - Can't assign requested address at t/03local-cross-v4.t line 18.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 68 just after 6.
cpan/IO-Socket-IP/t/03local-cross-v4 .......................... FAILED--no leader found
cpan/IO-Socket-IP/t/04local-client-v6 ......................... ok
#   Failed test '$testserver->sockdomain for SOCK_STREAM'
#   at t/05local-server-v6.t line 44.
#          got: '2'
#     expected: '24'
cpan/IO-Socket-IP/t/05local-server-v6 ......................... FAILED at test 2
Cannot connect on PF_INET6 - Connection refused at t/06local-cross-v6.t line 21.
cpan/IO-Socket-IP/t/06local-cross-v6 .......................... FAILED--no leader found
cpan/IO-Socket-IP/t/10args .................................... ok
cpan/IO-Socket-IP/t/11sockopts ................................ ok
cpan/IO-Socket-IP/t/12port-fallback ........................... ok
cpan/IO-Socket-IP/t/13addrinfo ................................ ok
cpan/IO-Socket-IP/t/14fileno .................................. ok
cpan/IO-Socket-IP/t/15io-socket ............................... ok
cpan/IO-Socket-IP/t/16v6only .................................. ok
cpan/IO-Socket-IP/t/17gai-flags ............................... ok
cpan/IO-Socket-IP/t/18fdopen .................................. ok
cpan/IO-Socket-IP/t/19no-addrs ................................ ok
cpan/IO-Socket-IP/t/20subclass ................................ ok
cpan/IO-Socket-IP/t/21as-inet ................................. ok
cpan/IO-Socket-IP/t/22timeout ................................. ok
cpan/IO-Socket-IP/t/30nonblocking-connect ..................... ok
cpan/IO-Socket-IP/t/31nonblocking-connect-internet ............ ok
cpan/IO-Socket-IP/t/99pod ..................................... skipped

whereas after reading http://search.cpan.org/~pevans/IO-Socket-IP-0.32/lib/IO/Socket/IP.pm I am sure it should be

my $testserver = IO::Socket::IP->new(
      ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
      LocalHost => "127.0.0.1",
      LocalPort  => "0",
      Type      => Socket->$socktype,
   );

I have updated my AIX.patchup file to apply the following patches


--- cpan/IO-Socket-IP/t/02local-server-v4.t     2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/02local-server-v4.t  2014-09-20 14:31:22 +0000
@@ -27,7 +27,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "127.0.0.1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    );
 
--- cpan/IO-Socket-IP/t/03local-cross-v4.t      2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/03local-cross-v4.t   2014-09-20 14:31:36 +0000
@@ -11,7 +11,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "127.0.0.1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    ) or die "Cannot listen on PF_INET - $@";
 
--- cpan/IO-Socket-IP/t/05local-server-v6.t     2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/05local-server-v6.t  2014-09-20 14:31:58 +0000
@@ -33,7 +33,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "::1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
       GetAddrInfoFlags => 0, # disable AI_ADDRCONFIG
    );

--- cpan/IO-Socket-IP/t/06local-cross-v6.t      2014-09-13 19:09:09 +0000
+++ /data/prj/perl/perl-5.20.x/cpan/IO-Socket-IP/t/patches/06local-cross-v6.t   2014-09-20 14:32:12 +0000
@@ -14,7 +14,7 @@
    my $testserver = IO::Socket::IP->new(
       ( $socktype eq "SOCK_STREAM" ? ( Listen => 1 ) : () ),
       LocalHost => "::1",
-      Port      => 0,
+      LocalPort => "0",
       Type      => Socket->$socktype,
    ) or die "Cannot listen on PF_INET6 - $@";
 
I will post the results using my patch later.

On Sat, Sep 6, 2014 at 2:57 PM, Michael Felt <aixtools@gmail.com> wrote:

I sent it to two people, at least. sorry for any confusion.

On Sep 5, 2014 6:25 PM, "Paul Evans via RT" <bug-IO-Socket-IP@rt.cpan.org> wrote:
<URL: https://rt.cpan.org/Ticket/Display.html?id=98494 >

(seems to be a dupe of RT98640)

--

Paul Evans


This seems to be a dupe of RT96064; now applied. (reject/dupe) -- Paul Evans
Subject: Re: [rt.cpan.org #98494] "issues" with tests for IO-Socket-IP and AIX 5.3 - basic PATCH included
Date: Fri, 13 Mar 2015 10:06:06 +0100
To: bug-IO-Socket-IP@rt.cpan.org
From: Michael Felt <aixtools@gmail.com>
Will adjust my smokers so when it comes down the pipeline they will not report the error. Thanks!

On Thu, Mar 12, 2015 at 9:01 PM, Paul Evans via RT <bug-IO-Socket-IP@rt.cpan.org> wrote:
Show quoted text
<URL: https://rt.cpan.org/Ticket/Display.html?id=98494 >

This seems to be a dupe of RT96064; now applied.

(reject/dupe)

--

Paul Evans



This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.