Skip Menu |
 

This queue is for tickets about the DBIx-MyParsePP CPAN distribution.

Report information
The Basics
Id: 98472
Status: resolved
Worked: 10 min
Priority: 0/
Queue: DBIx-MyParsePP

People
Owner: MERKYS [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.50
Fixed in: 0.51

Attachments
0001-Fix-key-ordering-for-unit-tests.patch.txt



Subject: Possible hash randomization problems in test suite
Download (untitled) / with headers
text/plain 210b
The test suite started to fail (sometimes) with perl 5.17.x, see http://matrix.cpantesters.org/?dist=DBIx-MyParsePP%200.50 It's possible that the newly introduced hash randomization is causing these failures.
This fixes things but I'm not sure it's the right fix?
Subject: 0001-Fix-key-ordering-for-unit-tests.patch.txt
From 6cf477ed5ac2d148795d998f50e529b87c507587 Mon Sep 17 00:00:00 2001 From: Todd Rinaldo <toddr@cpan.org> Date: Thu, 25 Jun 2015 22:25:38 -0500 Subject: [PATCH] Fix key ordering for unit tests RT 98472: This fixes the unit test but it's far from clear if this resolves the underlying issue. The code uses keys in a total of one place and applying sort to the fix there doesn't seem to fix things. --- modules/DBIx-MyParsePP/DBIx-MyParsePP/t/error.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/DBIx-MyParsePP/DBIx-MyParsePP/t/error.t b/modules/DBIx-MyParsePP/DBIx-MyParsePP/t/error.t index 4a9acc8..c5a5c7a 100644 --- a/modules/DBIx-MyParsePP/DBIx-MyParsePP/t/error.t +++ b/modules/DBIx-MyParsePP/DBIx-MyParsePP/t/error.t @@ -25,7 +25,7 @@ ok(ref($query) eq $query_class,'error2'); ok(!defined($query->root()), 'error3'); ok(ref($query->expected()) eq 'ARRAY', 'error4'); -my @expected = @{$query->expected()}; +my @expected = sort @{$query->expected()}; ok($expected[0] eq ')', 'error5'); ok($expected[1] eq ',', 'error6'); -- 2.4.0
Download (untitled) / with headers
text/plain 222b
On Thu Jun 25 23:30:11 2015, TODDR wrote: Show quoted text
> This fixes things but I'm not sure it's the right fix?
I have incorporated the patch in https://github.com/merkys/DBIx-MyParsePP/commit/cd32f26d298a307698fb721a8530235b968adb71.
Bug is fixed, closing the issue.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.