Skip Menu |
 

This queue is for tickets about the CPANPLUS-Dist-Build CPAN distribution.

Report information
The Basics
Id: 9793
Status: resolved
Worked: 37 hours (2220 min)
Priority: 0/
Queue: CPANPLUS-Dist-Build

People
Owner: BINGOS [...] cpan.org
Requestors: SAPER [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: FAIL reports does not include tests output
Download (untitled) / with headers
text/plain 596b
Hello Jos, The FAIL reports sent by CPANPLUS 0.051 don't include the output of "make test" or "Build test", whereas CPANPLUS 0.050_xx did. While not being severe, this may be annoying to an author who receive such reports because they he then don't have the opportunity to immediatly know (for example) wihch test failed. For reference, here[1] is a FAIL report sent by CPANPLUS 0.050_xx and here[2] is one sent by CPANPLUS 0.051. [1] http://www.nntp.perl.org/group/perl.cpan.testers/175706 [2] http://www.nntp.perl.org/group/perl.cpan.testers/178985 Regards, Sébastien Aperghis-Tramoni
Subject: CPANPLUS FAIL reports using Module::Build do not include tests output
Download (untitled) / with headers
text/plain 1.3k
[SAPER - Sun Jan 16 16:19:09 2005]: Show quoted text
> The FAIL reports sent by CPANPLUS 0.051 don't include the output of > "make test" or "Build test", whereas CPANPLUS 0.050_xx did. While > not being severe, this may be annoying to an author who receive > such reports because they he then don't have the opportunity to > immediatly know (for example) wihch test failed. > > For reference, here[1] is a FAIL report sent by CPANPLUS 0.050_xx and > here[2] is one sent by CPANPLUS 0.051. > > [1] http://www.nntp.perl.org/group/perl.cpan.testers/175706 > [2] http://www.nntp.perl.org/group/perl.cpan.testers/178985
Actually, this is not a difference between 0.050_04 and 0.051, but between using Module:: Build and using ExtUtils::MakeMaker; EU::MM's make test is run by shelling out and capturing the output, but M::B's build test is run by calling it's API. The build test call will die on test failure, but $@ only contains the summary line, rather than the entire output. This could be fixed in either T::H or in M::B, but M::B seems the logical choice in this case. Attached is a patch for M::B 0.2607 which will change this test report: http://www.nntp.perl.org/group/perl.cpan.testers/178257 into this test report: http://www.nntp.perl.org/group/perl.cpan.testers/179030 Moving this ticket over to the M::B queue, so they may address the issue
==== //depot/cpanplus/devel/lib/CPANPLUS/inc/installers/Module/Build/Base.pm#3 - /Users/kane/sources/p4/cpanplus/devel/lib/CPANPLUS/inc/installers/Module/Build/Base.pm ==== 1349c1349,1369 < Test::Harness::runtests(@$tests); --- > > # Test::Harness prints all it's diagnostics to STDOUT, then dies > # with a summary of the failure. In order to facilitate test reporting > # and better diagnostics, we'd like to capture the T::H output and add > # it to our die() message. > use IO::String; > local *STDOUT; > tie *STDOUT, 'IO::String'; > > eval { Test::Harness::runtests(@$tests) }; > > seek( STDOUT, 0, 0 ); > my $msg .= join "", <STDOUT>; > > # T::H would have done this already, but we caught it's output > print $msg; > > # now die with the full output, plus the error message, if there > # was an error > die $msg . $/ . $@ if $@; >
Download (untitled) / with headers
text/plain 160b
I can't update the keywords of this ticket but I can confirm that this bug was present with Module::Build 0.2607 and is still present with Module::Build 0.2608.
Download (untitled) / with headers
text/plain 337b
[KANE - Mon Jan 17 03:02:30 2005]: Show quoted text
> Moving this ticket over to the M::B queue, so they may address the > issue
Just to add my complaint to this "Unimportant item". This bug annoys me on a daily basic, because of CPAN Testers reports like the following: http://www.nntp.perl.org/group/perl.cpan.testers/215404 Please fix. Leon
RT-Send-CC: LBROCARD [...] cpan.org, KANE [...] cpan.org
Download (untitled) / with headers
text/plain 499b
I think that because this bug was moved into the M::B queue and didn't originate there, I never got an email about it. Sorry I didn't notice it in the queue. I'm not sure it's a great idea to have $@ contain the entire failure output. In general we try to have $@ contain just the text of an "exception" message. Other "informational" messages go to STDOUT or STDERR. Since CPANPLUS is the one that actually wants this output, it seems like it should be the one that collects it too. -Ken
Download (untitled) / with headers
text/plain 210b
[KWILLIAMS - Tue Jun 14 08:51:18 2005]: Show quoted text
> Since CPANPLUS is the one that actually wants this output, it seems > like it should be the one that collects it too.
Then please make it available through your API.
Download (untitled) / with headers
text/plain 429b
Ken, I didn't even notice you just moved the ticket back to the CPANPLUS queue. I'm not quite sure what you're thinking here, but this is in all intents and purposes a problem with Module::Build, and not CPANPLUS. So it would be kindly appreciated if, rather than ignoring a bug ticket for half a year, you'd actually take the time to fix the issue at hand. Please leave this ticket in your queue and attend to it, thanks.
Like Leo, I'm often bothered by this problem. Would be really nice if this patch got applied.
From: NUFFIN [...] cpan.org
Download (untitled) / with headers
text/plain 389b
On Tue Mar 14 05:33:25 2006, MRAMBERG wrote: Show quoted text
> Like Leo, I'm often bothered by this problem. Would be really nice if > this patch got applied.
I suffer from this quite often too... There are other ways to fix it: make $@ an error object which stringifies to the terse message but also has the long message, or have a global accumilator that can be accessed after detecting the error.
Download (untitled) / with headers
text/plain 262b
I definitely agree, this is an important issue. It's the first thing we're planning to work on after the 0.28 release. The 0.28 release itself will just be essentially the current beta release with enough bugs fixed to get tests passing in bleadperl. -Ken
From: JROBINSON [...] cpan.org
Download (untitled) / with headers
text/plain 411b
On Thu Mar 16 18:02:49 2006, KWILLIAMS wrote: Show quoted text
> I definitely agree, this is an important issue. It's the first thing > we're planning to work on after > the 0.28 release. The 0.28 release itself will just be essentially > the current beta release with > enough bugs fixed to get tests passing in bleadperl. > > -Ken
I'd like this fixed too! (Anyone know how to remove erroneous/useless tester reports ? ;)
Bug in CPANPLUS.
Download (untitled) / with headers
text/plain 109b
Reopening. We might not know who needs to fix what, but it's definitely a problem and shouldn't be rejected.
New releases now include process separation of Build.PL and Build actions with capturing. Cheers.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.