Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 97191
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: Steffen_Ullrich [...] genua.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.64
Fixed in: 1.65



Subject: Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Download (untitled) / with headers
text/plain 817b
Hi, this patch fixes the support for SSL_set_info_callback and adds SSL_CTX_set_info_callback and SSL_set_state. Support for these functions is necessary to either detect renegotiation or to enforce renegotiation: - SSL_set_info_callback: now takes a proper perl callback, instead some C callback which you cannot create from Perl - SSL_CTX_set_info_callback: same as SSL_set_info_callback, but for CTX - SSL_set_state: needed together with SSL_renegotiate to explicitly trigger renegotiation now instead of sometimes later This patch omits the autogenerated changes on constants.c and 21_constants.t. It also omits for clarity the necessary changes for the exported symbols in SSLeay.pm and SSLeay.pod, which need to be done by running regen_openssl_constants.pl at the appropriate places. Regards, Steffen
Subject: diff
Download diff
application/octet-stream 9.8k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #97191] Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Date: Mon, 14 Jul 2014 07:50:56 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 1.6k
Hello Steffen, Thanks for your patch. It is now in SVN 418. I would be grateful if you will confirm that revision works OK for you. Maybe time for a new release? Cheers. On Sunday, July 13, 2014 12:40:49 PM you wrote: Show quoted text
> Sun Jul 13 12:40:48 2014: Request 97191 was acted upon. > Transaction: Ticket created by SULLR > Queue: Net-SSLeay > Subject: Patch: fix SSL_set_info_callback, add > SSL_CTX_set_info_callback and SSL_set_state > Broken in: 1.64 > Severity: (no value) > Owner: Nobody > Requestors: Steffen_Ullrich@genua.de > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=97191 > > > > Hi, > > this patch fixes the support for SSL_set_info_callback and adds > SSL_CTX_set_info_callback and SSL_set_state. Support for these functions is > necessary to either detect renegotiation or to enforce renegotiation: > - SSL_set_info_callback: now takes a proper perl callback, instead some C > callback which you cannot create from Perl > - SSL_CTX_set_info_callback: same as SSL_set_info_callback, but for CTX > - SSL_set_state: needed together with SSL_renegotiate to explicitly trigger > renegotiation now instead of sometimes later > > This patch omits the autogenerated changes on constants.c and > 21_constants.t. It also omits for clarity the necessary changes for the > exported symbols in SSLeay.pm and SSLeay.pod, which need to be done by > running > regen_openssl_constants.pl at the appropriate places. > > Regards, > Steffen
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474
Download (untitled) / with headers
text/plain 745b
Am So 13. Jul 2014, 17:51:08, mikem@airspayce.com schrieb: Show quoted text
> Hello Steffen, > > Thanks for your patch. > It is now in SVN 418. I would be grateful if you will confirm that > revision > works OK for you.
Thanks for the quick reply. While testing on an old system with openssl 0.9.8 I've noticed, that SSL_set_state is not available there. The attached small patch fixes this issue. Also, the test t/local/42_info_callback.t is not included in SVN yet. And, while looking at the output from make dist I've noticed that it complains about a missing Debian_CPANTS.txt, which is included in MANIFEST but not checked into SVN. Show quoted text
> Maybe time for a new release?
Apart from the mentioned issues I think it would be a good idea. Thanks a lot, Steffen
Subject: set_state.diff
Download set_state.diff
text/x-diff 342b
Index: SSLeay.xs =================================================================== --- SSLeay.xs (revision 419) +++ SSLeay.xs (working copy) @@ -4570,7 +4570,11 @@ SSL * ssl int state CODE: +#ifdef OPENSSL_NO_SSL_INTERN SSL_set_state(ssl,state); +#else + ssl->state = state; +#endif long SSL_need_tmp_RSA(ssl)
Subject: Re: [rt.cpan.org #97191] Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Date: Mon, 14 Jul 2014 16:36:58 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 1.1k
Hello Steffen, On Monday, July 14, 2014 02:23:08 AM you wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=97191 > > > Am So 13. Jul 2014, 17:51:08, mikem@airspayce.com schrieb:
> > Hello Steffen, > > > > Thanks for your patch. > > > > It is now in SVN 418. I would be grateful if you will confirm that > > > > revision > > works OK for you.
> > Thanks for the quick reply. > While testing on an old system with openssl 0.9.8 I've noticed, that > SSL_set_state is not available there. The attached small patch fixes this > issue. Also, the test t/local/42_info_callback.t is not included in SVN > yet. And, while looking at the output from make dist I've noticed that it > complains about a missing Debian_CPANTS.txt, which is included in MANIFEST > but not checked into SVN.
> > Maybe time for a new release?
> > Apart from the mentioned issues I think it would be a good idea.
OK, just to be sure will you check SVN 420 is perfect for you? Cheers. Show quoted text
> > Thanks a lot, > Steffen
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474
Subject: Re: [rt.cpan.org #97191] Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Date: Mon, 14 Jul 2014 08:58:20 +0200
To: Mike McCauley via RT <bug-Net-SSLeay [...] rt.cpan.org>
From: Steffen Ullrich <Steffen_Ullrich [...] genua.de>
Download (untitled) / with headers
text/plain 548b
Show quoted text
> > OK, just to be sure will you check SVN 420 is perfect for you?
The changes are fine, but I still cannot see t/local/42_info_callback.t and Debian_CPANTS.txt checked into SVN. But this should not affect make dist, as long as you have these files locally. Thanks, Steffen -- genua Gesellschaft fuer Netzwerk- und Unix-Administration mbH Domagkstrasse 7, 85551 Kirchheim bei Muenchen tel +49 89 991950-0, fax -999, www.genua.de Geschaeftsfuehrer: Dr. Magnus Harlander, Dr. Michaela Harlander, Bernhard Schneck. Amtsgericht Muenchen HRB 98238
Subject: Re: [rt.cpan.org #97191] Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Date: Mon, 14 Jul 2014 17:16:20 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 799b
Hello Steffen, On Monday, July 14, 2014 02:58:37 AM you wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=97191 > >
> > OK, just to be sure will you check SVN 420 is perfect for you?
> > The changes are fine, but I still cannot see t/local/42_info_callback.t and > Debian_CPANTS.txt checked into SVN. But this should not affect make dist, as > long as you have these files locally.
Thanks for picking that up. t/local/42_info_callback.t is now in SVN 421, but where does Debian_CPANTS.txt come from? I dont have that here. Cheers. Show quoted text
> > Thanks, > Steffen
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474
Subject: Re: [rt.cpan.org #97191] Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Date: Mon, 14 Jul 2014 10:33:32 +0200
To: Mike McCauley via RT <bug-Net-SSLeay [...] rt.cpan.org>
From: Steffen Ullrich <Steffen_Ullrich [...] genua.de>
Download (untitled) / with headers
text/plain 457b
Show quoted text
> ... but where does Debian_CPANTS.txt > come from? I dont have that here.
I don't know. I see it in MANIFEST and I see it included in the current 1.64 distribution. Regards, Steffen -- genua Gesellschaft fuer Netzwerk- und Unix-Administration mbH Domagkstrasse 7, 85551 Kirchheim bei Muenchen tel +49 89 991950-0, fax -999, www.genua.de Geschaeftsfuehrer: Dr. Magnus Harlander, Dr. Michaela Harlander, Bernhard Schneck. Amtsgericht Muenchen HRB 98238
Subject: Re: [rt.cpan.org #97191] Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Date: Mon, 14 Jul 2014 20:19:43 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 571b
Hi, On Monday, July 14, 2014 04:33:46 AM you wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=97191 > >
> > ... but where does Debian_CPANTS.txt > > come from? I dont have that here.
> > I don't know. > I see it in MANIFEST and I see it included in the current 1.64 distribution.
Im removing it. Cheers. Show quoted text
> > Regards, > Steffen
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474
Subject: Re: [rt.cpan.org #97191] Patch: fix SSL_set_info_callback, add SSL_CTX_set_info_callback and SSL_set_state
Date: Mon, 14 Jul 2014 20:33:55 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 706b
Version 1.65 has been pushed to CPAN. Cheers. On Monday, July 14, 2014 08:19:43 PM you wrote: Show quoted text
> Hi, > > On Monday, July 14, 2014 04:33:46 AM you wrote:
> > Queue: Net-SSLeay > > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=97191 > > >
> > > ... but where does Debian_CPANTS.txt > > > come from? I dont have that here.
> > > > I don't know. > > I see it in MANIFEST and I see it included in the current 1.64 > > distribution.
> Im removing it. > Cheers. >
> > Regards, > > Steffen
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.