Skip Menu |
 

This queue is for tickets about the Ogg-Vorbis-Header-PurePerl CPAN distribution.

Report information
The Basics
Id: 96578
Status: resolved
Priority: 0/
Queue: Ogg-Vorbis-Header-PurePerl

People
Owner: DAVECROSS [...] cpan.org
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.0
Fixed in: (no value)

Attachments
eliminate_deprecated_use_of_array_as_reference_rt_cpan_org_96578.diff



Subject: Can't use an array as a reference
Download (untitled) / with headers
text/plain 558b
Running the tests with perl v5.12.5 or higher is warning Using an array as a reference is deprecated at test.pl line 22. Using an array as a reference is deprecated at test.pl line 28. Using an array as a reference is deprecated at test.pl line 31. With bleadperl v5.21.0-417-g1f1ec7b this construct is deprecated, so with the next perl version, 5.22, O:V:H:PP will stop passing tests. Sample fail report: http://www.cpantesters.org/cpan/report/43357898 HTH&&Thanks, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)
Download (untitled) / with headers
text/plain 784b
On Fri Jun 20 00:06:25 2014, ANDK wrote: Show quoted text
> Running the tests with perl v5.12.5 or higher is warning > > Using an array as a reference is deprecated at test.pl line 22. > Using an array as a reference is deprecated at test.pl line 28. > Using an array as a reference is deprecated at test.pl line 31. > > With bleadperl v5.21.0-417-g1f1ec7b this construct is deprecated, so > with the next perl version, 5.22, O:V:H:PP will stop passing tests. > > Sample fail report: > > http://www.cpantesters.org/cpan/report/43357898 > > HTH&&Thanks, > (Disclaimer: this was discovered by statistical analysis, I'm not > speaking as a user)
I am attaching a patch which should eliminate the warnings in perl-5.20 and earlier and prevent failures in perl-5.22. Thank you very much. Jim Keenan
Subject: eliminate_deprecated_use_of_array_as_reference_rt_cpan_org_96578.diff
--- /home/jkeenan/Downloads/Ogg-Vorbis-Header-PurePerl-1.0/test.pl 2007-01-04 17:12:23.000000000 -0500 +++ ./test.pl 2015-04-06 21:44:12.970890513 -0400 @@ -19,16 +19,16 @@ # Try all the routines ok($ogg->info->{'rate'} == 44100); ok($ogg->comment_tags); -ok(@{$ogg->comment('artist')}->[0] == 'maloi'); +ok($ogg->comment('artist')->[0] == 'maloi'); $ogg = 0; # See if full load works ok(my $ogg = Ogg::Vorbis::Header::PurePerl->new('test.ogg')); -ok(@{$ogg->comment('artist')}->[0] == 'maloi'); +ok($ogg->comment('artist')->[0] == 'maloi'); # and see if we can get comments including the '=' character -ok(@{$ogg->comment('album')}->[0] == 'this=that'); +ok($ogg->comment('album')->[0] == 'this=that'); # Make sure we're getting the right track length ok($ogg->info->{'length'} == 0);
Fixed in version 1.01 (currently en route to CPAN).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.