Skip Menu |
 

This queue is for tickets about the MozRepl-RemoteObject CPAN distribution.

Report information
The Basics
Id: 96247
Status: open
Priority: 0/
Queue: MozRepl-RemoteObject

People
Owner: Nobody in particular
Requestors: CDRAKE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.37
Fixed in: (no value)



Subject: AnyEvent.pm Fails when MozRepl is not local (127.0.0.1)
Download (untitled) / with headers
text/plain 592b
Here is the fix:- ($client->{host},$client->{port})=($1,$2) if(($ENV{MOZREPL}=~/(.*):(\d+)/) and !defined($client->{host})); # cnd - fix connection problems Here is is again, in context:- sub setup_async { my ($self,$options) = @_; my $client = delete $options->{ client } || {}; ($client->{host},$client->{port})=($1,$2) if(($ENV{MOZREPL}=~/(.*):(\d+)/) and !defined($client->{host})); # cnd - fix connection problems $client->{port} ||= 4242; $client->{host} ||= 'localhost'; $options->{log} ||= []; without the above, tests fail and it won't install or work.
Subject: Re: [rt.cpan.org #96247] AnyEvent.pm Fails when MozRepl is not local (127.0.0.1)
Date: Mon, 09 Jun 2014 21:31:05 +0200
To: bug-MozRepl-RemoteObject [...] rt.cpan.org
From: Max Maischein <corion [...] cpan.org>
Download (untitled) / with headers
text/plain 1.6k
Hello CDrake, Show quoted text
> Here is the fix:- > > ($client->{host},$client->{port})=($1,$2) if(($ENV{MOZREPL}=~/(.*):(\d+)/) and !defined($client->{host})); # cnd - fix connection problems > > Here is is again, in context:- > > > sub setup_async { > my ($self,$options) = @_; > my $client = delete $options->{ client } || {}; > ($client->{host},$client->{port})=($1,$2) if(($ENV{MOZREPL}=~/(.*):(\d+)/) and !defined($client->{host})); # cnd - fix connection problems > $client->{port} ||= 4242; > $client->{host} ||= 'localhost'; > $options->{log} ||= []; > > > > without the above, tests fail and it won't install or work. >
I can't reproduce the problem. If I run this # MOZREPL=192.168.1.92:4242 MOZREPL_CLASS=MozRepl::AnyEvent make test on a machine that is not 192.168.1.92 , with Firefox running and mozrepl listening on 192.168.1.92:4242 (with "allow outside connections") the tests pass except for 01-expr.t. At least when configuring the call to MozRepl::AnyEvent through the environment instead of manually setting up the object it works. But I see the t/expr-anyevent.t fails to properly set up (and respect) the (possibly remote) $ENV{MOZREPL} settings, so there is a bug in the test. Before I release the fixed version with the fixed test, can you please elaborate on your setup and how you are using MozRepl::AnyEvent? The parsing of $ENV{MOZREPL} is done in MozRepl::RemoteObject and MozRepl::AnyEvent expects the options to be passed in as MozRepl::RemoteObject does. If you want to use it separately, maybe it would help to factor out the $ENV{}-parsing code to a separate subroutine... -max


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.