Skip Menu |
 

This queue is for tickets about the Makefile-Parser CPAN distribution.

Report information
The Basics
Id: 95979
Status: open
Priority: 0/
Queue: Makefile-Parser

People
Owner: Nobody in particular
Requestors: CARNIL [...] cpan.org
gregoa [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


From: gregoa [...] cpan.org
Subject: libmakefile-parser-perl: FTBFS - tests fail
Download (untitled) / with headers
text/plain 1.5k
This bug has been forwarded from http://bugs.debian.org/749357 /* - Full build log at above URL. - Please note that Debian has GNU make 4.0 in testing and unstable now. */ -->-->-->-->-->-->-->-->-->-->-->-->-->-->-->-->-->-->-->--> Package: libmakefile-parser-perl Version: 0.215-2 Severity: serious Usertags: goto-cc During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder and pbuilder) the build failed with the following error. [...] dh_auto_test make[1]: Entering directory '/srv/jenkins-slave/workspace/sid-goto-cc-libmakefile-parser-perl/libmakefile-parser-perl-0.215' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/99-pod-coverage.t t/99-pod.t t/ast-basic.t t/ast-rule.t t/ast-stem.t t/ast-var.t t/Makefile-Parser.t t/makesimple.t t/99-pod-coverage.t .. skipped: We know we don't have enough POD :( t/99-pod.t ........... ok t/ast-basic.t ........ ok t/ast-rule.t ......... ok t/ast-stem.t ......... ok t/ast-var.t .......... ok t/Makefile-Parser.t .. ok GNU Make 4.0 # Failed test 'TEST 1: basics - process returned the 0 status' # at t/makesimple.t line 58. # got: '1' # expected: '0' # Failed test 'TEST 1: basics - script/makesimple generated the right output' # at t/makesimple.t line 59. # got: '' # expected: 'all: # @echo hello world # ' Further failing tests follow. The full build log is attached. Best, Michael <--<--<--<--<--<--<--<--<--<--<--<--<--<--<--<--<--<--<--<-- Thanks in advance, gregor herrmann, Debian Perl Group
From: ntyni [...] iki.fi
Download (untitled) / with headers
text/plain 822b
On Mon May 26 14:46:04 2014, GREGOA wrote: Show quoted text
> This bug has been forwarded from http://bugs.debian.org/749357
Show quoted text
> # Failed test 'TEST 1: basics - process returned the 0 status' > # at t/makesimple.t line 58. > # got: '1' > # expected: '0' >
The immediate failure here is because GNU make 4.0 outputs # 'override' directive GNUMAKEFLAGS := The attached patch makes the parser survive this. The next problem is that rules with an assignment like all: FOO += one now get passed through 'make --print-data-base' unsimplified, but aren't correctly parsed: warning: line 178: Unknown GNU make database struct: all: FOO += one I managed to get Makefile::DOM to parse those with a quick hack, but I suppose Makefile::AST::Rule needs to understand them next? Hope this helps, -- Niko Tyni ntyni@debian.org
Subject: 0001-make-4.0-compatibility.patch
From 097521aae7b4e8d719e9535077905236aefa0f96 Mon Sep 17 00:00:00 2001 From: Niko Tyni <ntyni@debian.org> Date: Sun, 7 Sep 2014 15:37:58 +0300 Subject: [PATCH] make 4.0 compatibility --- lib/Makefile/Parser/GmakeDB.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile/Parser/GmakeDB.pm b/lib/Makefile/Parser/GmakeDB.pm index 0e876e0..a221490 100644 --- a/lib/Makefile/Parser/GmakeDB.pm +++ b/lib/Makefile/Parser/GmakeDB.pm @@ -154,7 +154,7 @@ sub parse ($$) { undef $var_origin; } } - elsif ($elem =~ /^#\s+(automatic|makefile|default|environment|command line)/) { + elsif ($elem =~ /^#\s+(automatic|makefile|default|environment|command line|'override' directive)/) { $var_origin = $1; $var_origin = 'file' if $var_origin eq 'makefile'; $next_var_lineno = $elem->lineno + 1; -- 2.1.0
Ping? Any news / experiences / patches? Cheers, gregor


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.