Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 95635
Status: rejected
Priority: 0/
Queue: CGI

People
Owner: Nobody in particular
Requestors: m.krayushin [...] net-probe.ru
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: CGI.pn: misprint in find_tempdir subroutine
Date: Wed, 14 May 2014 14:37:40 +0400
To: bug-CGI [...] rt.cpan.org
From: Maxim Krayushin <m.krayushin [...] net-probe.ru>
Download (untitled) / with headers
text/plain 318b
Hello, I've found a misprint in the CGI.pm module in find_tempdir subroutine: 4205c4205 < do {$TMPDIRECTORY = $_; last} if -d $_ && -w _; --- Show quoted text
> do {$TMPDIRECTORY = $_; last} if -d $_ && -w $_;
-- Best regards, Maxim Krayushin e-mail: m.krayushin@net-probe.ru skype: voodoovin web: www.net-probe.ru
Subject: Re: [rt.cpan.org #95635] CGI.pn: misprint in find_tempdir subroutine
Date: Wed, 14 May 2014 05:55:55 -0700
To: Maxim Krayushin via RT <bug-CGI [...] rt.cpan.org>
From: Mark Stosberg <mark [...] stosberg.com>
Download (untitled) / with headers
text/plain 407b
Show quoted text
> < do {$TMPDIRECTORY = $_; last} if -d $_ && -w _; > ---
> > do {$TMPDIRECTORY = $_; last} if -d $_ && -w $_;
The existing code is correct and in fact better because it will run a bit faster. If you had creating a test case before you submitted, you would have seen that the existing code works as expected. See perldoc -f -X And scroll to the bottom to see "_" explained. Mark
Download (untitled) / with headers
text/plain 241b
This issue has been copied to: https://github.com/leejo/CGI.pm/issues/135 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.
Rejecting as per reasons explained above


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.