Skip Menu |
 

This queue is for tickets about the CPAN2RT CPAN distribution.

Report information
The Basics
Id: 94289
Status: open
Priority: 0/
Queue: CPAN2RT

People
Owner: Nobody in particular
Requestors: tsibley [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.03
Fixed in: (no value)



Subject: Catch distribution renames in load_queue()
Download (untitled) / with headers
text/plain 284b
After a successful load, do something like: if ($queue->Name ne $dist) { $queue->SetName($dist); # but with error checking! } I wonder if ->SetName is going to complain about it already being the current value. See also https://github.com/CPAN-API/metacpan-web/issues/1138.
Subject: Re: [rt.cpan.org #94289] Catch distribution renames in load_queue()
Date: Fri, 28 Mar 2014 17:04:48 -0400
To: Thomas Sibley via RT <bug-CPAN2RT [...] rt.cpan.org>
From: Kevin Falcone <falcone [...] bestpractical.com>
Download (untitled) / with headers
text/plain 579b
On Fri, Mar 28, 2014 at 04:51:09PM -0400, Thomas Sibley via RT wrote: Show quoted text
> > I wonder if ->SetName is going to complain about it already being the current value. > > See also https://github.com/CPAN-API/metacpan-web/issues/1138.
Queue name validation checks to make sure you aren't renaming to conflict with an existing queue, but does specifically exempt renaming the current Queue. Without that, I'd have been unable to rename HTML-Diff in the UI. While we had a bug about this, it was fixed in 3.4.3. We've had similar bugs in the other name validation functions. -kevin
Subject: Re: [rt.cpan.org #94289] Catch distribution renames in load_queue()
Date: Fri, 28 Mar 2014 17:10:29 -0400
To: "falcone [...] bestpractical.com via RT" <bug-CPAN2RT [...] rt.cpan.org>
From: Thomas Sibley <tom [...] zulutango.org>
Download (untitled) / with headers
text/plain 494b
On Fri, Mar 28, 2014 at 05:04:51PM -0400, falcone@bestpractical.com via RT wrote: Show quoted text
>> I wonder if ->SetName is going to complain about it already being the current value. >> >> See also https://github.com/CPAN-API/metacpan-web/issues/1138.
> > Queue name validation checks to make sure you aren't renaming to > conflict with an existing queue, but does specifically exempt renaming > the current Queue. Without that, I'd have been unable to rename > HTML-Diff in the UI.
Ah, good point. :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.