Bug #93739 for Finance-Bank-Bankwest: cannot create Transaction instances without a transaction code

Mon Mar 10 22:35:12 2014 owenhollands [...] gmail.com - Ticket created

Subject:	Fwd: Minor fix to Finance::Bank::Bankwest
Date:	Tue, 11 Mar 2014 13:35:02 +1100
To:	bug-finance-bank-bankwest@rt.cpan.org
From:	Owen Hollands <owenhollands@gmail.com>

---------- Forwarded message ----------
From: Owen Hollands <owenhollands@gmail.com>
Date: Thu, Mar 6, 2014 at 12:43 PM
Subject: Minor fix to Finance::Bank::Bankwest
To: bug-financebank-bankwest@rt.cpan.org

In short, the "type" field of a transaction ins blank (undef) for credit card "Authorisation Only" transaction. In Transaction.pm I ahve added "Maybe" to the type check

--- ./Transaction.pm 2013-08-08 11:25:25.000000000 +1000

+++ /Users/owenhollands/perl5/lib/perl5/Finance/Bank/Bankwest/Transaction.pm 2014-03-05 10:11:41.000000000 +1100

@@ -16,7 +16,7 @@

[ narrative => 'Str' ],

[ cheque_num => 'Maybe[Str]' ],

[ amount => 'Maybe[Num]' ],

- [ type => 'Str' ],

+ [ type => 'Maybe[Str]' ],

) {

my ($attr, $type) = @$_;

has $attr => ( isa => $type, is => 'ro', required => 1 );

Tue Mar 11 02:39:44 2014 lxp [...] cpan.org - Taken

Tue Mar 11 02:39:44 2014 lxp [...] cpan.org - Broken in 1.2.5 added

Tue Mar 11 03:06:29 2014 lxp [...] cpan.org - Correspondence added

Hi Owen, Thanks for trying out Finance::Bank::Bankwest ("FBB"), and for taking the time to contact me about the problem you faced.

Show quoted text

> In short, the "type" field of a transaction ins blank (undef) for > credit card "Authorisation Only" transaction.

As recently as Friday (7 March), Bankwest was assigning code "DAU" to all Authorisation Only transactions. I wonder whether something has changed on Bankwest's side, or whether perhaps a fault elsewhere in FBB is causing erroneous attempts to create a Transaction instance without a code. I'll monitor Bankwest's treatment of Authorisation Only transactions over the coming days and get back to you. -- Kind regards, Alex Peters

Tue Mar 11 03:06:29 2014 The RT System itself - Status changed from 'new' to 'open'

Tue Mar 11 03:07:50 2014 lxp [...] cpan.org - Subject changed from 'Fwd: Minor fix to Finance::Bank::Bankwest' to 'attempted creation of Transaction instance without a transaction code'

Tue Mar 11 23:36:39 2014 owenhollands [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #93739] Fwd: Minor fix to Finance::Bank::Bankwest
Date:	Wed, 12 Mar 2014 14:36:29 +1100
To:	bug-Finance-Bank-Bankwest@rt.cpan.org
From:	Owen Hollands <owenhollands@gmail.com>

I definitely have a blank field for authority types - but it seems to have been that way for some time. This may have something to do with the type of credit card?

> head -2 Trans*.csv

==> Transactions_03_06_2013.csv <==

BSB Number,Account Number,Transaction Date,Narration,Cheque Number,Debit,Credit,Balance,Transaction Type

,9999 9999 9999 9999,03/06/2013,"AUTHORISATION ONLY - COLES XXXXXXXXXX NSW AU",,-99.99,,-999.99,

On Tue, Mar 11, 2014 at 6:06 PM, Alex Peters via RT <bug-Finance-Bank-Bankwest@rt.cpan.org> wrote:

Show quoted text

<URL: https://rt.cpan.org/Ticket/Display.html?id=93739 >

Hi Owen,

Thanks for trying out Finance::Bank::Bankwest ("FBB"), and for taking
the time to contact me about the problem you faced.

> In short, the "type" field of a transaction ins blank (undef) for
> credit card "Authorisation Only" transaction.

As recently as Friday (7 March), Bankwest was assigning code "DAU" to
all Authorisation Only transactions.

I wonder whether something has changed on Bankwest's side, or whether
perhaps a fault elsewhere in FBB is causing erroneous attempts to create
a Transaction instance without a code.

I'll monitor Bankwest's treatment of Authorisation Only transactions
over the coming days and get back to you.

--
Kind regards,
Alex Peters

Wed Mar 12 01:16:57 2014 lxp [...] cpan.org - Correspondence added

Subject:

Re: Fwd: Minor fix to Finance::Bank::Bankwest

Hi Owen,

Show quoted text

> I definitely have a blank field for authority types - but it seems to > have been that way for some time. This may have something to do with > the type of credit card?

That would be it. My experience with Authorisation Only transactions is limited to the Zero Transaction account--I hadn't even considered credit card accounts during design.

Show quoted text

> > head -2 Trans*.csv

> > ==> Transactions_03_06_2013.csv <== > > BSB Number,Account Number,Transaction Date,Narration,Cheque Number,Debit,Credit,Balance,Transaction Type > ,9999 9999 9999 9999,03/06/2013,"AUTHORISATION ONLY - COLES XXXXXXXXXX NSW AU",,-99.99,,-999.99,

Thanks for the CSV snippet. I'm satisfied that it's not a problem in another part of the code. I'll incorporate your patch and adjust the documentation. While I'm at it, can I ask you exactly how you specify your account number in your $session->transactions call? I'm guessing whitespace is significant. If so, I'd like to add an example to the documentation. -- Kind regards, Alex Peters

Fri Mar 14 04:34:09 2014 lxp [...] cpan.org - Subject changed from 'attempted creation of Transaction instance without a transaction code' to 'cannot create Transaction instances without a transaction code'

Fri Mar 14 04:34:09 2014 lxp [...] cpan.org - Fixed in 1.2.6 added

Fri Mar 14 04:41:23 2014 lxp [...] cpan.org - Correspondence added

Subject:

Re: Fwd: Minor fix to Finance::Bank::Bankwest

Hi Owen,

Show quoted text

> While I'm at it, can I ask you exactly how you specify your account > number in your $session->transactions call? I'm guessing whitespace > is significant. If so, I'd like to add an example to the > documentation.

I've implemented your patch, made the assumption that credit card numbers are entered in the same format as in the CSV you provided, updated the documentation accordingly and uploaded a new release of Finance-Bank-Bankwest to CPAN:

Show quoted text

> 1.2.6 2014-03-14 > > - Allow an undefined transaction code in Transaction objects, since > Bankwest does not return one in some cases ([rt.cpan.org #93739]). > Thanks to Owen Hollands for reporting this behaviour and providing > a patch. > > - Minor documentation adjustments.

Thanks for getting in touch, and please don't hesitate to contact me again if you have any further issues or suggestions. -- Kind regards, Alex Peters

Wed Mar 19 23:24:52 2014 lxp [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Dec 15 19:12:01 2014 owenhollands [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #93739] Re: Fwd: Minor fix to Finance::Bank::Bankwest
Date:	Tue, 16 Dec 2014 11:11:51 +1100
To:	bug-Finance-Bank-Bankwest@rt.cpan.org
From:	Owen Hollands <owenhollands@gmail.com>

Hi, I was wondering if you had experienced an issue where queries return the last 7 days of transactions, regardless of the dates specified?

I haven't had a chance to look into it myself, so I don't know if the issue is in your code or mine. I thought I would ask in case you were already looking at it.

Owen.

On Fri, Mar 14, 2014 at 7:41 PM, Alex Peters via RT <bug-Finance-Bank-Bankwest@rt.cpan.org> wrote:

Show quoted text

<URL: https://rt.cpan.org/Ticket/Display.html?id=93739 >

Hi Owen,

> While I'm at it, can I ask you exactly how you specify your account

> number in your $session->transactions call? I'm guessing whitespace
> is significant. If so, I'd like to add an example to the
> documentation.

I've implemented your patch, made the assumption that credit card
numbers are entered in the same format as in the CSV you provided,
updated the documentation accordingly and uploaded a new release of
Finance-Bank-Bankwest to CPAN:

> 1.2.6 2014-03-14
>
> - Allow an undefined transaction code in Transaction objects, since
> Bankwest does not return one in some cases ([rt.cpan.org #93739]).
> Thanks to Owen Hollands for reporting this behaviour and providing
> a patch.
>
> - Minor documentation adjustments.

Thanks for getting in touch, and please don't hesitate to contact me
again if you have any further issues or suggestions.

--
Kind regards,
Alex Peters

Tue Dec 16 07:02:10 2014 lxp [...] cpan.org - Reference to #100946: transaction search dates not being honoured added

Bug #93739 for Finance-Bank-Bankwest: cannot create Transaction instances without a transaction code

Maintainer(s)' notes