Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Sereal-Encoder CPAN distribution.

Report information
The Basics
Id: 93615
Status: open
Priority: 0/
Queue: Sereal-Encoder

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: custom op implementation
Date: Fri, 7 Mar 2014 17:16:38 +0000
To: bug-Sereal-Encoder [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 525b
Attached patch implements custom op optimisation for Sereal-Encoder. Same deal as for Sereal-Decoder. Should maintain Perl version portability, but not actually tested. Patch lacks tests for the new exportable sub. This one is considerably simpler than Sereal-Decoder, because there's only one affected sub. Rate method function op method 2.33738e+06+-59/s -- -12.3% -21.4% function 2.66585e+06+-7.4/s 14.1% -- -10.4% op 2.97563e+06+-9.2/s 27.3% 11.6% -- -zefram
Download custom_op.patch
text/x-diff 6.6k

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #93615] custom op implementation
Date: Mon, 10 Mar 2014 08:36:12 +0100
To: bug-Sereal-Encoder [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
Download (untitled) / with headers
text/plain 1.1k
Please review "custom_op" branch. I have not merged your comments yet. Yves On 7 March 2014 18:16, Zefram via RT <bug-Sereal-Encoder@rt.cpan.org> wrote: Show quoted text
> Fri Mar 07 12:16:51 2014: Request 93615 was acted upon. > Transaction: Ticket created by zefram@fysh.org > Queue: Sereal-Encoder > Subject: custom op implementation > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: zefram@fysh.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=93615 > > > > Attached patch implements custom op optimisation for Sereal-Encoder. Same > deal as for Sereal-Decoder. Should maintain Perl version portability, > but not actually tested. Patch lacks tests for the new exportable sub. > This one is considerably simpler than Sereal-Decoder, because there's > only one affected sub. > > Rate method function op > method 2.33738e+06+-59/s -- -12.3% -21.4% > function 2.66585e+06+-7.4/s 14.1% -- -10.4% > op 2.97563e+06+-9.2/s 27.3% 11.6% -- > > -zefram >
-- perl -Mre=debug -e "/just|another|perl|hacker/"
Subject: Re: [rt.cpan.org #93615] custom op implementation
Date: Wed, 12 Mar 2014 13:12:58 +0000
To: demerphq via RT <bug-Sereal-Encoder [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 196b
demerphq via RT wrote: Show quoted text
>Please review "custom_op" branch. I have not merged your comments yet.
Looks fine from inspection, and passes tests for me on various Perls from 5.8.8 to 5.19.8. -zefram
Subject: Re: [rt.cpan.org #93615] custom op implementation
Date: Mon, 17 Mar 2014 11:23:53 +0000
To: demerphq via RT <bug-Sereal-Encoder [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 111b
Your Changes entry refers to "sereal_decode_with_object" which should be "sereal_encode_with_object". -zefram


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.