Skip Menu |
 

This queue is for tickets about the Imager CPAN distribution.

Report information
The Basics
Id: 92738
Status: rejected
Priority: 0/
Queue: Imager

People
Owner: Nobody in particular
Requestors: TONYC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: i_io_raw_read mishandles COW scalars
Date: Wed, 5 Feb 2014 14:59:57 +1100
To: bug-Imager [...] rt.cpan.org
From: tonyc [...] cpan.org
It needs to call SvPVbyte_force() instead of SvPVbyte(). Similarly for i_io_read()
Download (untitled) / with headers
text/plain 425b
On Tue Feb 04 23:00:13 2014, TONYC wrote: Show quoted text
> It needs to call SvPVbyte_force() instead of SvPVbyte(). > > Similarly for i_io_read()
I turned out that this statement was incorrect. The code didn't call SvPVbyte() in any case, and the code that was there did all that was necessary, if a little inefficiently. I've updated the code to be a bit more direct, based on what I learned writing the patch for [perl #116925] Tony
Download (untitled) / with headers
text/plain 600b
On Mon Mar 31 05:36:42 2014, TONYC wrote: Show quoted text
> On Tue Feb 04 23:00:13 2014, TONYC wrote:
> > It needs to call SvPVbyte_force() instead of SvPVbyte(). > > > > Similarly for i_io_read()
> > > I turned out that this statement was incorrect. The code didn't call > SvPVbyte() in any case, and the code that was there did all that was > necessary, if a little inefficiently. > > I've updated the code to be a bit more direct, based on what I learned > writing the patch for [perl #116925]
This ended up breaking perl 5.6 and didn't add much efficiency, so the change was reverted. So rejecting. Tony


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.