Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Alien-SVN CPAN distribution.

Report information
The Basics
Id: 91782
Status: rejected
Priority: 0/
Queue: Alien-SVN

People
Owner: Nobody in particular
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: v1.7.3.1
Fixed in: (no value)



Subject: Build failure with svn-1.8.5
Download (untitled) / with headers
text/plain 429b
subversion/mod_dav_svn/util.c: In function 'dav_svn__log_err': subversion/mod_dav_svn/util.c:630:20: error: 'dav_error' has no member named 'save_errno' if (errscan->save_errno != 0) { ^ subversion/mod_dav_svn/util.c:631:28: error: 'dav_error' has no member named 'save_errno' errno = errscan->save_errno; ^ make: *** [subversion/mod_dav_svn/util.lo] Error 1
Download (untitled) / with headers
text/plain 1.1k
$ rpm -qf /usr/include/apache2/mod_dav.h apache2-devel-2.4.6-6.10.1.i586 $ mod_dav.h has --8<--- /* ** dav_error structure. ** ** In most cases, mod_dav uses a pointer to a dav_error structure. If the ** pointer is NULL, then no error has occurred. ** ** In certain cases, a dav_error structure is directly used. In these cases, ** a status value of 0 means that an error has not occurred. ** ** Note: this implies that status != 0 whenever an error occurs. ** ** The desc field is optional (it may be NULL). When NULL, it typically ** implies that Apache has a proper description for the specified status. */ typedef struct dav_error { int status; /* suggested HTTP status (0 for no error) */ int error_id; /* DAV-specific error ID */ const char *desc; /* DAV:responsedescription and error log */ apr_status_t aprerr; /* APR error if any, or 0/APR_SUCCESS */ const char *namespace; /* [optional] namespace of error */ const char *tagname; /* name of error-tag */ struct dav_error *prev; /* previous error (in stack) */ } dav_error; -->8--- that does not have save_errno
Download (untitled) / with headers
text/plain 1.5k
PASS with the patch as described in http://mail-archives.apache.org/mod_mbox/subversion-commits/201201.mbox/%3C20120117021721.EB7F42388860@eris.apache.org%3E Applied in Alien-SVN-v1.7.3.1 as --8<--- diff -purd a/src/subversion/subversion/mod_dav_svn/util.c b/src/subversion/subversion/mod_dav_svn/util.c --- a/src/subversion/subversion/mod_dav_svn/util.c 2012-03-18 23:09:42.000000000 +0100 +++ b/src/subversion/subversion/mod_dav_svn/util.c 2014-02-15 15:00:20.917078691 +0100 @@ -624,19 +624,21 @@ void dav_svn__log_err(request_rec *r, /* Log the errors */ /* ### should have a directive to log the first or all */ for (errscan = err; errscan != NULL; errscan = errscan->prev) { + apr_status_t status; + if (errscan->desc == NULL) continue; - if (errscan->save_errno != 0) { - errno = errscan->save_errno; - ap_log_rerror(APLOG_MARK, level, errno, r, "%s [%d, #%d]", - errscan->desc, errscan->status, errscan->error_id); - } - else { - ap_log_rerror(APLOG_MARK, level, 0, r, - "%s [%d, #%d]", - errscan->desc, errscan->status, errscan->error_id); - } +#if AP_MODULE_MAGIC_AT_LEAST(20091119,0) + status = errscan->aprerr; +#else + status = errscan->save_errno; +#endif + + ap_log_rerror(APLOG_MARK, level, status, r, + "%s [%d, #%d]", + errscan->desc, errscan->status, errscan->error_id); + } } -->8---
This doesn't seem to be about Alien::SVN, so I'm going to close it.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.