Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 91774
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: david [...] weekly.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Remove SSL_get_tlsa_record_byname
Download (untitled) / with headers
text/plain 1.2k
SSL_get_tlsa_record_byname is not included in OpenSSL git master; it was added optimistically in May to Net::SSLeay per http://comments.gmane.org/gmane.ietf.dane/653 but should probably be removed now to avoid "undefined symbol: SSL_get_tlsa_record_byname at /usr/lib/perl/5.14/DynaLoader.pm line 184." errors when linking against the latest version of OpenSSL (1.1.x DEV). Note that -DOPENSSL_NO_DANE did not result in a valid build. The below patch excises DANE; all tests still pass. --- SSLeay.c~ 2013-12-31 23:54:51.000000000 +0000 +++ SSLeay.c 2014-01-01 00:03:29.000000000 +0000 @@ -14305,31 +14305,7 @@ } #endif -#if OPENSSL_VERSION_NUMBER >= 0x10002000L && !defined(OPENSSL_NO_DANE) -#define XSubPPtmpAACF 1 - -XS(XS_Net__SSLeay_get_tlsa_record_byname); /* prototype to pass -Wmissing-prototypes */ -XS(XS_Net__SSLeay_get_tlsa_record_byname) -{ -#ifdef dVAR - dVAR; dXSARGS; -#else - dXSARGS; -#endif - if (items != 3) - croak_xs_usage(cv, "name, port, type"); - { - char * name = (char *)SvPV_nolen(ST(0)); - int port = (int)SvIV(ST(1)); - int type = (int)SvIV(ST(2)); - - SSL_get_tlsa_record_byname(name, port, type); - } - XSRETURN_EMPTY; -} - -#endif #define REM_EOF "/* EOF - SSLeay.xs */" #ifdef __cplusplus extern "C"
Subject: Re: [rt.cpan.org #91774] Remove SSL_get_tlsa_record_byname
Date: Tue, 07 Jan 2014 17:29:23 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Hi, thanks for the headsup. Deleted in SVN 391 On Tuesday, December 31, 2013 07:05:23 PM David E. Weekly via RT wrote: Show quoted text
> Tue Dec 31 19:05:22 2013: Request 91774 was acted upon. > Transaction: Ticket created by DEW > Queue: Net-SSLeay > Subject: Remove SSL_get_tlsa_record_byname > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: david@weekly.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=91774 > > > > SSL_get_tlsa_record_byname is not included in OpenSSL git master; it was > added optimistically in May to Net::SSLeay per > http://comments.gmane.org/gmane.ietf.dane/653 but should probably be > removed now to avoid "undefined symbol: SSL_get_tlsa_record_byname at > /usr/lib/perl/5.14/DynaLoader.pm line 184." errors when linking against the > latest version of OpenSSL (1.1.x DEV). Note that -DOPENSSL_NO_DANE did not > result in a valid build. > > The below patch excises DANE; all tests still pass. > > --- SSLeay.c~ 2013-12-31 23:54:51.000000000 +0000 > +++ SSLeay.c 2014-01-01 00:03:29.000000000 +0000 > @@ -14305,31 +14305,7 @@ > } > > #endif > -#if OPENSSL_VERSION_NUMBER >= 0x10002000L && !defined(OPENSSL_NO_DANE) > -#define XSubPPtmpAACF 1 > > - > -XS(XS_Net__SSLeay_get_tlsa_record_byname); /* prototype to pass > -Wmissing-prototypes */ -XS(XS_Net__SSLeay_get_tlsa_record_byname) > -{ > -#ifdef dVAR > - dVAR; dXSARGS; > -#else > - dXSARGS; > -#endif > - if (items != 3) > - croak_xs_usage(cv, "name, port, type"); > - { > - char * name = (char *)SvPV_nolen(ST(0)); > - int port = (int)SvIV(ST(1)); > - int type = (int)SvIV(ST(2)); > - > - SSL_get_tlsa_record_byname(name, port, type); > - } > - XSRETURN_EMPTY; > -} > - > -#endif > #define REM_EOF "/* EOF - SSLeay.xs */" > #ifdef __cplusplus > extern "C"
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.