Skip Menu |
 

This queue is for tickets about the App-JobLog CPAN distribution.

Report information
The Basics
Id: 91660
Status: open
Priority: 0/
Queue: App-JobLog

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: App-JobLog breaking in bleadperl
Download (untitled) / with headers
text/plain 179b
Please note, if you have not already done so, that recent changes in bleadperl are causing smoke testing failures in App-JobLog. https://rt.perl.org/Ticket/Display.html?id=120374
Download (untitled) / with headers
text/plain 903b
In looking at the failing test report cited above, I noted that in lib/App/JobLog/Log/Line.pm you have many lines that make use of regexes with one or more instances of two consecutive '+' signs: ##### 27: (?<ts> (\d{4}+\s++\d++\s++\d++\s++\d++\s++\d++\s++\d++) (?{$date = $^N}) ) 33: (?<tags> (?:(?&tag)(\s++(?&tag))*+)?) 34: (?<tag> ((?:[^\s:\\]|(?&escaped))++) (?{push @tags, $^N})) 37: (?<description> ((?:[^;\\]|(?&escaped))++) (?{push @description, $^N})) 86: $description =~ s/^\s++|\s++$//g; 87: $description =~ s/\s++/ /g; 123: my @time = split /\s++/, $date; 141: $v =~ s/^\s++|\s++$//g; 142: $v =~ s/\s++/ /g; ##### Do the log lines you are parsing actually have so many plus signs in them? (Note: I'm not claiming that this is the cause of the test failures in bleadperl.) Thank you very much. Jim Keenan
Download (untitled) / with headers
text/plain 933b
On Wed Dec 25 20:56:25 2013, JKEENAN wrote: Show quoted text
> In looking at the failing test report cited above, I noted that in > lib/App/JobLog/Log/Line.pm you have many lines that make use of > regexes with one or more instances of two consecutive '+' signs: > > ##### > 27: (?<ts> (\d{4}+\s++\d++\s++\d++\s++\d++\s++\d++\s++\d++) > (?{$date = $^N}) ) > 33: (?<tags> (?:(?&tag)(\s++(?&tag))*+)?) > 34: (?<tag> ((?:[^\s:\\]|(?&escaped))++) (?{push @tags, $^N})) > 37: (?<description> ((?:[^;\\]|(?&escaped))++) (?{push > @description, $^N})) > 86: $description =~ s/^\s++|\s++$//g; > 87: $description =~ s/\s++/ /g; > 123: my @time = split /\s++/, $date; > 141: $v =~ s/^\s++|\s++$//g; > 142: $v =~ s/\s++/ /g; > ##### > > Do the log lines you are parsing actually have so many plus signs in > them?
Those "+" aren't being matched literally. \s++ means (?>\s+)
Subject: Re: [rt.cpan.org #91660] App-JobLog breaking in bleadperl
Date: Thu, 26 Dec 2013 13:34:56 -0600 (CST)
To: bug-App-JobLog [...] rt.cpan.org
From: Jim Keenan <jkeen [...] verizon.net>
On 12/26/13, ikegami via RT<bug-App-JobLog@rt.cpan.org> wrote: <URL: https://rt.cpan.org/Ticket/Display.html?id=91660 > On Wed Dec 25 20:56:25 2013, JKEENAN wrote: Show quoted text
> In looking at the failing test report cited above, I noted that in > lib/App/JobLog/Log/Line.pm you have many lines that make use of > regexes with one or more instances of two consecutive '+' signs: > > ##### > 27: (?<ts> (\d{4}+\s++\d++\s++\d++\s++\d++\s++\d++\s++\d++) > (?{$date = $^N}) ) > 33: (?<tags> (?:(?&tag)(\s++(?&tag))*+)?) > 34: (?<tag> ((?:[^\s:\\]|(?&escaped))++) (?{push @tags, $^N})) > 37: (?<description> ((?:[^;\\]|(?&escaped))++) (?{push > @description, $^N})) > 86: $description =~ s/^\s++|\s++$//g; > 87: $description =~ s/\s++/ /g; > 123: my @time = split /\s++/, $date; > 141: $v =~ s/^\s++|\s++$//g; > 142: $v =~ s/\s++/ /g; > ##### > > Do the log lines you are parsing actually have so many plus signs in > them?
Those "+" aren't being matched literally. \s++ means (?>\s+) #### One of those new-fangled Perl ragex features I've never personally used! Had to look it up in 'perlre'. Thanks for the pointer. jimk
Download (untitled) / with headers
text/plain 306b
On Wed Dec 25 20:46:08 2013, JKEENAN wrote: Show quoted text
> Please note, if you have not already done so, that recent changes in > bleadperl are causing smoke testing failures in App-JobLog. > > https://rt.perl.org/Ticket/Display.html?id=120374
The problem has been fixed at perl’s end, so this ticket can be closed.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.