Skip Menu |
 

This queue is for tickets about the ExtUtils-Install CPAN distribution.

Report information
The Basics
Id: 91651
Status: open
Priority: 0/
Queue: ExtUtils-Install

People
Owner: Nobody in particular
Requestors: cpan [...] neonics.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.44
Fixed in: (no value)



Subject: Packlist::validate() false negatives on .gz man pages
Download (untitled) / with headers
text/plain 692b
calling ExtUtils::Installed->new()->validate( $module ) returns a list of man pages that it claims are missing (which they are). However, they are stored gzipped. Replacing the following line in ExtUtils/PackList.pm's validate($;$) method: if (! -e $key ) with if (! -e $key && ( $key =~ m@/man/@ ? ! -e $key.".gz" : 1 ) ) Fixes the issue. Perhaps a better regexp is needed to match the file extension aswell to avoid false matches, but you get the idea. I apologize for not formatting it as a patch. In version 1.44 (distributed with Cygwin) it is line 207, and in version 1.54 it is line 203: https://metacpan.org/source/YVES/ExtUtils-Install-1.54/lib/ExtUtils/Packlist.pm#L203
On Wed Dec 25 07:51:36 2013, https://openid.stackexchange.com/user/83939ede-74ea-4f6c-8bf4-a4539b9b5220 wrote: Show quoted text
> calling ExtUtils::Installed->new()->validate( $module ) > returns a list of man pages that it claims are missing > (which they are). However, they are stored gzipped. > > Replacing the following line in ExtUtils/PackList.pm's validate($;$) > method: > > if (! -e $key ) > > with > > if (! -e $key && ( $key =~ m@/man/@ ? ! -e $key.".gz" : 1 ) ) > > Fixes the issue. Perhaps a better regexp is needed to match the file > extension aswell to avoid false matches, but you get the idea. > > I apologize for not formatting it as a patch. > In version 1.44 (distributed with Cygwin) it is line 207, > and in version 1.54 it is line 203: > https://metacpan.org/source/YVES/ExtUtils-Install- > 1.54/lib/ExtUtils/Packlist.pm#L203
Can you give examples of situations where man pages would be stored in .gz format and listed as such in .packlist files? On my OS (Linux Ubuntu 14.04 LTS), I haven't found any such files, so I'm having trouble investigating your complaint. Thank you very much. Jim Keenan
Subject: Re: [rt.cpan.org #91651] Packlist::validate() false negatives on .gz man pages
Date: Wed, 19 Nov 2014 11:28:23 +0100
To: bug-ExtUtils-Install [...] rt.cpan.org
From: Kenney Westerhof <kenney [...] apache.org>
Download (untitled) / with headers
text/plain 2.6k
Hello, On 19-11-2014 2:39, James E Keenan via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=91651 > > > On Wed Dec 25 07:51:36 2013, https://openid.stackexchange.com/user/83939ede-74ea-4f6c-8bf4-a4539b9b5220 wrote:
>> calling ExtUtils::Installed->new()->validate( $module ) >> returns a list of man pages that it claims are missing >> (which they are). However, they are stored gzipped. >> >> Replacing the following line in ExtUtils/PackList.pm's validate($;$) >> method: >> >> if (! -e $key ) >> >> with >> >> if (! -e $key && ( $key =~ m@/man/@ ? ! -e $key.".gz" : 1 ) ) >> >> Fixes the issue. Perhaps a better regexp is needed to match the file >> extension aswell to avoid false matches, but you get the idea. >> >> I apologize for not formatting it as a patch. >> In version 1.44 (distributed with Cygwin) it is line 207, >> and in version 1.54 it is line 203: >> https://metacpan.org/source/YVES/ExtUtils-Install- >> 1.54/lib/ExtUtils/Packlist.pm#L203
> Can you give examples of situations where man pages would be stored in .gz format and listed as such in .packlist files?
No, because I have not yet found any such examples. What I'm describing above is that the .packlist files list man pages uncompressed, whereas on the filesystem they are sometimes/often stored gzipped. If i've proposed anything at all in the above, it's not that .packlist files should list man pages gzipped, but that the check for the existence of installed manpages should take into account that they could be stored gzipped. I've either not investigated, or I have forgotten how these manpages are installed in the first place, but it's likely that some sort of install.sh script would gzip them on the fly depending on system settings. Show quoted text
> On my OS (Linux Ubuntu 14.04 LTS), I haven't found any such files, so I'm having trouble investigating your complaint.
It's not a complaint, merely a report. It's been almost a year, so I can't remember any specific packages or filenames now, but here's some stats: On Cygwin: $ ls /usr/share/man/man3 | grep 3pm\$ | wc -l 1957 $ ls /usr/share/man/man3 | grep 3pm.gz\$ | wc -l 593 On Debian 7: $ ls /usr/share/man/man3 | grep 3pm\$ | wc -l 0 $ ls /usr/share/man/man3 | grep 3pm.gz\$ | wc -l 593 ls /usr/share/man/man3 | grep 3perl\$ | wc -l 0 ls /usr/share/man/man3 | grep 3perl.gz\$ | wc -l 590 I recall installing many packages using CPAN which put them in /usr/local/; all the manpages there are uncompressed. I believe that the issue arises when ExtUtils comes across packages installed using the OS distributions' package manager. Show quoted text
> Thank you very much. > Jim Keenan
Thanks for your response, Kenney Westerhof


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.