Skip Menu |
 

This queue is for tickets about the Archive-Zip CPAN distribution.

Report information
The Basics
Id: 91547
Status: open
Priority: 0/
Queue: Archive-Zip

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)



Subject: installation failure on 5.19.7
Download (untitled) / with headers
text/plain 7.5k
Unpacking Archive-Zip-1.34.tar.gz Entering Archive-Zip-1.34 Checking configure dependencies from META.json Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.84) Configuring Archive-Zip-1.34 Running Makefile.PL Checking if your kit is complete... Looks good Generating a Unix-style Makefile Writing Makefile for Archive::Zip Writing MYMETA.yml and MYMETA.json -> OK Checking dependencies from MYMETA.json ... Checking if you have Test::More 0.42 ... Yes (1.001002) Checking if you have IO::File 0 ... Yes (1.16) Checking if you have File::Basename 0 ... Yes (2.85) Checking if you have File::Find 0 ... Yes (1.26) Checking if you have File::Temp 0 ... Yes (0.2304) Checking if you have File::Spec 0.80 ... Yes (3.45) Checking if you have File::Path 0 ... Yes (2.09) Checking if you have Time::Local 0 ... Yes (1.2300) Checking if you have IO::Seekable 0 ... Yes (1.10) Checking if you have Compress::Raw::Zlib 2.017 ... Yes (2.063) Checking if you have IO::Handle 0 ... Yes (1.35) Checking if you have File::Copy 0 ... Yes (2.28) Building and testing Archive-Zip-1.34 cp lib/Archive/Zip.pm blib/lib/Archive/Zip.pm cp lib/Archive/Zip/ZipFileMember.pm blib/lib/Archive/Zip/ZipFileMember.pm cp lib/Archive/Zip/BufferedFileHandle.pm blib/lib/Archive/Zip/BufferedFileHandle.pm cp lib/Archive/Zip/FileMember.pm blib/lib/Archive/Zip/FileMember.pm cp lib/Archive/Zip/NewFileMember.pm blib/lib/Archive/Zip/NewFileMember.pm cp lib/Archive/Zip/FAQ.pod blib/lib/Archive/Zip/FAQ.pod cp lib/Archive/Zip/StringMember.pm blib/lib/Archive/Zip/StringMember.pm cp lib/Archive/Zip/Member.pm blib/lib/Archive/Zip/Member.pm cp lib/Archive/Zip/MemberRead.pm blib/lib/Archive/Zip/MemberRead.pm cp lib/Archive/Zip/Archive.pm blib/lib/Archive/Zip/Archive.pm cp lib/Archive/Zip/DirectoryMember.pm blib/lib/Archive/Zip/DirectoryMember.pm cp lib/Archive/Zip/Tree.pm blib/lib/Archive/Zip/Tree.pm cp lib/Archive/Zip/MockFileHandle.pm blib/lib/Archive/Zip/MockFileHandle.pm cp script/crc32 blib/script/crc32 /Users/ether/perl5/perlbrew/perls/19.7/bin/perl5.19.7 -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/crc32 Manifying blib/man3/Archive::Zip.0 Manifying blib/man3/Archive::Zip::FAQ.0 Manifying blib/man3/Archive::Zip::MemberRead.0 Manifying blib/man3/Archive::Zip::Tree.0 PERL_DL_NONLAZY=1 /Users/ether/perl5/perlbrew/perls/19.7/bin/perl5.19.7 "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_compile.t ................ ok warning: /Users/ether/perl5/perlbrew/perls/19.7/bin/perl5.19.7 -pe "BEGIN{binmode(STDIN);binmode(STDOUT)}" doesn't seem to work, may skip some tests at t/common.pl line 168. warning: /Users/ether/perl5/perlbrew/perls/19.7/bin/perl5.19.7 -pe "BEGIN{binmode(STDIN);binmode(STDOUT)}" doesn't seem to work, may skip some tests at t/common.pl line 168. warning: unzip -t doesn't seem to work, may skip some tests at t/common.pl line 198. warning: /Users/ether/perl5/perlbrew/perls/19.7/bin/perl5.19.7 -pe "BEGIN{binmode(STDIN);binmode(STDOUT)}" doesn't seem to work, may skip some tests at t/common.pl line 168. warning: unzip -t doesn't seem to work, may skip some tests at t/common.pl line 198. IO error: Can't open testdir/member_read.zip for write : No such file or directory at /Users/ether/.cpanm/work/1387584058.36210/Archive-Zip-1.34/blib/lib/Archive/Zip/Archive.pm line 395. Archive::Zip::Archive::writeToFileNamed(Archive::Zip::Archive=HASH(0x7f987302a2f0), "testdir/member_read.zip") called at t/04_readmember.t line 26 t/04_readmember.t ............. ok t/09_output_record_sep.t ...... ok format error: bad signature: 0x00001404 at offset 41 in file testout.zip at /Users/ether/.cpanm/work/1387584058.36210/Archive-Zip-1.34/blib/lib/Archive/Zip.pm line 468. Archive::Zip::_readSignature(IO::File=GLOB(0x7f875adf3628), "testout.zip") called at /Users/ether/.cpanm/work/1387584058.36210/Archive-Zip-1.34/blib/lib/Archive/Zip/Archive.pm line 629 Archive::Zip::Archive::readFromFileHandle(Archive::Zip::Archive=HASH(0x7f875adf2048), IO::File=GLOB(0x7f875adf3628), "testout.zip") called at /Users/ether/.cpanm/work/1387584058.36210/Archive-Zip-1.34/blib/lib/Archive/Zip/Archive.pm line 574 Archive::Zip::Archive::read(Archive::Zip::Archive=HASH(0x7f875adf2048), "testout.zip") called at t/07_filenames_of_0.t line 63 warning: /Users/ether/perl5/perlbrew/perls/19.7/bin/perl5.19.7 -pe "BEGIN{binmode(STDIN);binmode(STDOUT)}" doesn't seem to work, may skip some tests at t/common.pl line 168. t/05_tree.t ................... ok # Failed test at t/07_filenames_of_0.t line 63. # got: '3' # expected: '0' # Failed test 'Checking that a file called '0' was added properly by addString' # at t/07_filenames_of_0.t line 64. # Looks like you failed 2 tests of 3. t/07_filenames_of_0.t ......... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/3 subtests t/06_update.t ................. ok t/08_readmember_record_sep.t .. ok t/10_chmod.t .................. ok t/02_main.t ................... ok t/11_explorer.t ............... ok t/12_bug_47223.t .............. skipped: Only required on Win32. t/13_bug_46303.t .............. ok t/14_leading_separator.t ...... ok t/16_decrypt.t ................ ok t/15_decrypt.t ................ ok error: member not found at /Users/ether/.cpanm/work/1387584058.36210/Archive-Zip-1.34/blib/lib/Archive/Zip/Archive.pm line 186. Archive::Zip::Archive::extractMember(Archive::Zip::Archive=HASH(0x7f8af2029f08), "testdir/testing.txt") called at examples/extract.pl line 36 Extracting testdir/testing.txt from testout.zip failed # Failed test at t/03_ex.t line 41. # got: '65280' # expected: '0' Can't call method "desiredCompressionLevel" on an undefined value at /Users/ether/.cpanm/work/1387584058.36210/Archive-Zip-1.34/blib/lib/Archive/Zip/Archive.pm line 261. # Failed test at t/03_ex.t line 45. # got: '512' # expected: '0' # Failed test at t/03_ex.t line 59. # got: 'testdir/file.txt:100 # testdir/string.txt:100 # testdir/fileC.txt:100 # testdir/stringU.txt:100 # ' # expected: 'testdir/testing.txt:100 # ' error: testdir/testing.txt is neither a file nor a directory at /Users/ether/.cpanm/work/1387584058.36210/Archive-Zip-1.34/blib/lib/Archive/Zip/Archive.pm line 361. Archive::Zip::Archive::addFileOrDirectory(Archive::Zip::Archive=HASH(0x7ffeb9029f08), "testdir/testing.txt") called at examples/selfex.pl line 29 # Failed test 'extracted/testdir/testing.txt exists' # at t/03_ex.t line 74. # got: undef # expected: '1' # Looks like you failed 4 tests of 17. t/03_ex.t ..................... Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/17 subtests Test Summary Report ------------------- t/07_filenames_of_0.t (Wstat: 512 Tests: 3 Failed: 2) Failed tests: 2-3 Non-zero exit status: 2 t/03_ex.t (Wstat: 1024 Tests: 17 Failed: 4) Failed tests: 4, 6, 10, 13 Non-zero exit status: 4 Files=16, Tests=246, 2 wallclock secs ( 0.10 usr 0.04 sys + 2.91 cusr 0.52 csys = 3.57 CPU) Result: FAIL Failed 2/16 test programs. 6/246 subtests failed. make: *** [test_dynamic] Error 4 -> FAIL Installing Archive::Zip failed. See /Users/ether/.cpanm/work/1387584058.36210/build.log for details. Retry with --force to force install it. -> FAIL Installing the dependencies failed: Module 'Archive::Zip' is not installed -> FAIL Bailing out the installation for Archive-Any-Lite-0.07. -> FAIL Installing the dependencies failed: Module 'Archive::Any::Lite' is not installed -> FAIL Bailing out the installation for Module-CPANTS-Analyse-0.92. -> FAIL Installing the dependencies failed: Module 'Module::CPANTS::Analyse' is not installed -> FAIL Bailing out the installation for Test-Kwalitee-1.17.
Download (untitled) / with headers
text/plain 153b
Note that I use HARNESS_OPTIONS=j9, so this could be a concurrency issue. Are you reusing the same temp directory across multiple tests? Use File::Temp!
Download (untitled) / with headers
text/plain 5.4k
I had another box totally fall over and die when trying to install... the build.log was about 500k lines long, filled with this: format error: bad signature: 0x26197a74 at offset 578 in file testin.zip at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip.pm line 468. Archive::Zip::_readSignature(IO::File=GLOB(0x100e853e0), "testin.zip", 67324752) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 71 Archive::Zip::ZipFileMember::_seekToLocalHeader(Archive::Zip::ZipFileMember=HASH(0x100e7ced8)) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 106 Archive::Zip::ZipFileMember::_become(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "Archive::Zip::StringMember") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1005 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at t/02_main.t line 548 format error: bad signature: 0x26197a74 at offset 578 in file testin.zip at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip.pm line 468. Archive::Zip::_readSignature(IO::File=GLOB(0x100e853e0), "testin.zip", 67324752) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 71 Archive::Zip::ZipFileMember::_seekToLocalHeader(Archive::Zip::ZipFileMember=HASH(0x100e7ced8)) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 106 Archive::Zip::ZipFileMember::_become(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "Archive::Zip::StringMember") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1005 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1006 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at t/02_main.t line 548 format error: bad signature: 0x26197a74 at offset 578 in file testin.zip at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip.pm line 468. Archive::Zip::_readSignature(IO::File=GLOB(0x100e853e0), "testin.zip", 67324752) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 71 Archive::Zip::ZipFileMember::_seekToLocalHeader(Archive::Zip::ZipFileMember=HASH(0x100e7ced8)) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 106 Archive::Zip::ZipFileMember::_become(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "Archive::Zip::StringMember") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1005 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1006 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1006 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at t/02_main.t line 548 format error: bad signature: 0x26197a74 at offset 578 in file testin.zip at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip.pm line 468. Archive::Zip::_readSignature(IO::File=GLOB(0x100e853e0), "testin.zip", 67324752) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 71 Archive::Zip::ZipFileMember::_seekToLocalHeader(Archive::Zip::ZipFileMember=HASH(0x100e7ced8)) called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/ZipFileMember.pm line 106 Archive::Zip::ZipFileMember::_become(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "Archive::Zip::StringMember") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1005 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1006 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1006 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at /Users/ether/.cpanm/work/1387585863.85282/Archive-Zip-1.34/blib/lib/Archive/Zip/Member.pm line 1006 Archive::Zip::Member::contents(Archive::Zip::ZipFileMember=HASH(0x100e7ced8), "This is my new contents\x{a}") called at t/02_main.t line 548 format error: bad signature: 0x26197a74 at offset 578 in file testin.zip ...with each loop growing by one line... looks like you're not terminating your recursion properly!!!!
Download (untitled) / with headers
text/plain 435b
On 2013-12-20 17:22:30, ETHER wrote: Show quoted text
> I had another box totally fall over and die when trying to install... > the build.log was about 500k lines long, filled with this:
This is pretty bad. I was installing 5.18.2 for testing, and the cpanm build.log grew to 1500163529 bytes before the install process fell over and died. Increasing severity to Critical -- it's Not Cool At All to behave this badly when tests are run in parallel.
Subject: Re: [rt.cpan.org #91547] installation failure on 5.19.7
Date: Mon, 6 Jan 2014 23:05:08 -0800
To: bug-Archive-Zip [...] rt.cpan.org
From: Fred Moyer <fred [...] redhotpenguin.com>
Download (untitled) / with headers
text/plain 884b
I'm not seeing any failures for 5.18.2 on cpantesters - http://www.cpantesters.org/distro/A/Archive-Zip.html#Archive-Zip-1.36?oncpan=1&distmat=1 More than willing to accept a patch if you think you have something that will resolve the issue. On Mon, Jan 6, 2014 at 4:38 PM, Karen Etheridge via RT <bug-Archive-Zip@rt.cpan.org> wrote: Show quoted text
> Queue: Archive-Zip > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=91547 > > > On 2013-12-20 17:22:30, ETHER wrote:
>> I had another box totally fall over and die when trying to install... >> the build.log was about 500k lines long, filled with this:
> > This is pretty bad. I was installing 5.18.2 for testing, and the cpanm > build.log grew to 1500163529 bytes before the install process fell over and > died. Increasing severity to Critical -- it's Not Cool At All to behave this > badly when tests are run in parallel. > >
Subject: Re: [rt.cpan.org #91547] installation failure on 5.19.7
Date: Tue, 7 Jan 2014 09:09:44 -0800
To: "fred [...] redhotpenguin.com via RT" <bug-Archive-Zip [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
Download (untitled) / with headers
text/plain 569b
On Tue, Jan 07, 2014 at 02:05:19AM -0500, fred@redhotpenguin.com via RT wrote: Show quoted text
This is likely more related to running tests in parallel (e.g. HARNESS_OPTIONS=j9) than to the perl version. Temp files and directories should not be reused across tests (I don't know if that's the problem here, but it's the common cause of tests behaving badly in parallel).
Download (untitled) / with headers
text/plain 514b
Changing this in t/common.pl: use constant TESTDIR => 'testdir'; to this: use File::Temp 'tempdir'; sub TESTDIR { return tempdir( DIR => 'testdir', CLEANUP => 1 ) } ...at least eliminates the catastrophic failure, but some tests still fail - it looks like there are invalid assumptions being made about file paths somewhere in the tests. I implore you to not reuse the same tempdir across multiple tests - this is a horrible practice, even if it did not blow up so spectacularly as in this case.
Download (untitled) / with headers
text/plain 197b
This just happened on a deployment system and brought down other applications that were running on it. I'm going to start pursuing the option of removing this distribution from my dependency chain.
Subject: Re: [rt.cpan.org #91547] tests consume all disk when run in parallel
Date: Sun, 21 Sep 2014 11:22:14 -0700
To: bug-Archive-Zip [...] rt.cpan.org
From: Fred Moyer <fred [...] redhotpenguin.com>
Download (untitled) / with headers
text/plain 104b
I'll apply the change mentioned in your previous email. But think you have COMAINT on this module now?
Subject: Re: [rt.cpan.org #91547] tests consume all disk when run in parallel
Date: Sun, 21 Sep 2014 11:41:07 -0700
To: "fred [...] redhotpenguin.com via RT" <bug-Archive-Zip [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
Download (untitled) / with headers
text/plain 140b
On Sun, Sep 21, 2014 at 02:22:24PM -0400, fred@redhotpenguin.com via RT wrote: Show quoted text
> But think you have COMAINT on this module now?
I do not.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.