Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 91136
Status: rejected
Priority: 0/
Queue: CGI

People
Owner: Nobody in particular
Requestors: halgol60 [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: upload() requires cgi object reference
Date: Mon, 02 Dec 2013 19:58:46 -0600
To: bug-CGI [...] rt.cpan.org
From: Bozonius <halgol60 [...] gmail.com>
Download (untitled) / with headers
text/plain 533b
The upload() function does not seem to work if called in the "poetry" mode. It seems you have to qualify it with a CGI object, thus: my $cgi = new CGI; my $fileinfo = $cgi->upload('fieldname'); Otherwise, no object is returned. Here is a discussion where others have discovered this problem also: http://www.perlmonks.org/?node_id=206322 I'm using CGI 3.63, and this seems to happen on a few different Linux platforms, including mageia 3 and debian. Please feel free to email me at bozonius@aol.com if you need more info.
Download (untitled) / with headers
text/plain 241b
This issue has been copied to: https://github.com/leejo/CGI.pm/issues/129 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.
Download (untitled) / with headers
text/plain 524b
Rejecting as can't replicate, i have added specific tests cases for this in the below commit. If you can provide a failing test for this issue i shall look into it. Thanks! commit 3a377de3393c42c0a66be99d4a79534173e66192 Author: Lee Johnson <lee@givengain.ch> Date: Sat Jul 19 20:39:49 2014 +0200 resolve #129 [rt.cpan.org #91136] - test upload[info] returns correctly when called though procedural interface rather than the OO interface. seems there is nothing to do here, the code does the right thing
Subject: Re: [rt.cpan.org #91136] upload() requires cgi object reference
Date: Sun, 27 Jul 2014 15:28:17 -0700
To: bug-CGI [...] rt.cpan.org
From: Hal Goldfarb <halgol60 [...] gmail.com>
Download (untitled) / with headers
text/plain 1.1k
What is your testing platform? That can make a difference. I was using Mageia 3 at the time, and I believe my CGI.pm was from the distro's repo, which was 3.63. Have you looked at the example on the perlmonks list at http://www.perlmonks.org/?node_id=206322? Several people before me discovered it also. Please be sure you are testing against 3.63 as well -- that was the recommended/supported version at the time I submitted this bug. Thank you for looking into this. On 07/19/2014 11:42 AM, Lee Johnson via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=91136 > > > Rejecting as can't replicate, i have added specific tests cases for this in the below commit. If you can provide a failing test for this issue i shall look into it. Thanks! > > commit 3a377de3393c42c0a66be99d4a79534173e66192 > Author: Lee Johnson <lee@givengain.ch> > Date: Sat Jul 19 20:39:49 2014 +0200 > > resolve #129 [rt.cpan.org #91136] - test upload[info] > > returns correctly when called though procedural interface rather > than the OO interface. seems there is nothing to do here, the code > does the right thing
Subject: Re: [rt.cpan.org #91136] upload() requires cgi object reference
Date: Sun, 27 Jul 2014 17:39:11 -0700
To: Hal Goldfarb via RT <bug-CGI [...] rt.cpan.org>
From: Mark Stosberg <mark [...] stosberg.com>
Download (untitled) / with headers
text/plain 405b
Hal, If you have a failing test case, feel free to re-open the issue. If you are concerned that the issue might exist in 3.63 but not the current version, you should re-test with the current version. Lee has taken the effort to add his automated for the issue-- which passes. The ball is in your court to demonstrate an issue remains with the current version with a failing test case. Mark
Download (untitled) / with headers
text/plain 1.3k
On Sun Jul 27 18:28:29 2014, halgol60@gmail.com wrote: Show quoted text
> What is your testing platform? That can make a difference. I was > using > Mageia 3 at the time, and I believe my CGI.pm was from the distro's > repo, which was 3.63. > > Have you looked at the example on the perlmonks list at > http://www.perlmonks.org/?node_id=206322? > > Several people before me discovered it also. Please be sure you are > testing against 3.63 as well -- that was the recommended/supported > version at the time I submitted this bug.
My own platform is OS X, but travis shows the tests passing clean against x86_64-linux and all versions of perl back to 5.8. As Mark says, if you can improve the test case i added i would be interested, especially if you can get this to fail on other platforms as this would show some pretty odd behaviour i think: https://github.com/leejo/CGI.pm/commit/3a377de3393c42c0a66be99d4a79534173e66192 The tests will hit cpantesters once i upload the next dev release, which will filter through to many different platforms, configurations, and versions of perl: http://www.cpantesters.org/distro/C/CGI.html?oncpan=1&distmat=1&version=.pm-4.03 The fix was against the current version of CGI.pm (4.03). If there are issues in older versions of CGI.pm i encourage you to update the module. I am planning to get a dev release out this week and then if all is well 4.04 will go out on the 14th Aug (CPAN day!) Thanks!
Subject: Re: [rt.cpan.org #91136] upload() requires cgi object reference
Date: Mon, 28 Jul 2014 10:06:59 -0700
To: bug-CGI [...] rt.cpan.org
From: Hal Goldfarb <halgol60 [...] gmail.com>
On 07/27/2014 11:20 PM, Lee Johnson via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=91136 > > > On Sun Jul 27 18:28:29 2014, halgol60@gmail.com wrote:
>> What is your testing platform? That can make a difference. I was >> using >> Mageia 3 at the time, and I believe my CGI.pm was from the distro's >> repo, which was 3.63. >> >> Have you looked at the example on the perlmonks list at >> http://www.perlmonks.org/?node_id=206322? >> >> Several people before me discovered it also. Please be sure you are >> testing against 3.63 as well -- that was the recommended/supported >> version at the time I submitted this bug.
> My own platform is OS X, but travis shows the tests passing clean against x86_64-linux and all versions of perl back to 5.8. As Mark says, if you can improve the test case i added i would be interested, especially if you can get this to fail on other platforms as this would show some pretty odd behaviour i think: > > https://github.com/leejo/CGI.pm/commit/3a377de3393c42c0a66be99d4a79534173e66192 > > The tests will hit cpantesters once i upload the next dev release, which will filter through to many different platforms, configurations, and versions of perl: > > http://www.cpantesters.org/distro/C/CGI.html?oncpan=1&distmat=1&version=.pm-4.03 > > The fix was against the current version of CGI.pm (4.03). If there are issues in older versions of CGI.pm i encourage you to update the module. I am planning to get a dev release out this week and then if all is well 4.04 will go out on the 14th Aug (CPAN day!) > > Thanks!
Thank you, Lee, for your work on this. Currently, I am not using CGI, but if/when I do, I will try to remember to upgrade. The problem is that you can lose platform support if you don't use their specific module version. Usually, I get around that by installing selected modules to a local module directory so as not to break system functions (on Mageia, this is particularly an issue due to the use of Perl for a number of system configuration functions, so one has to be careful).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.