This queue is for tickets about the XML-LibXSLT CPAN distribution.

Report information
The Basics
Id:
91118
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
dmacks [...] netspace.org
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Subject: Warnings from clang (-Wpointer-sign and -Wparentheses)
Date: Mon, 02 Dec 2013 04:03:33 -0500
To: bug-XML-LibXSLT@rt.cpan.org
From: "Daniel Macks" <dmacks@netspace.org>
Building XML::LibXSLT-1.82 on OS X 10.8 using Apple's perl-5.12.4 and xcode-5.0.2 (with "gcc" mapped to clang-500.2.79), libxml2-2.9.1 and libxslt-1.1.28 via fink (along with a ton of CPAN modules)... gcc -c  -I/sw/include -I/sw/include/libxml2 -I/sw/include -I/sw/include/libxml2 -g -pipe -fno-common -DPERL_DARWIN -fno-strict-aliasing -fstack-protector -I/usr/local/include -Os   -DVERSION=\"1.82\" -DXS_VERSION=\"1.82\"  "-I/System/Library/Perl/5.12/darwin-thread-multi-2level/CORE"  -MD -DHAVE_BLANK -DHAVE_BLANK -DHAVE_EXSLT LibXSLT.c LibXSLT.xs:252:57: warning: passing 'char [4]' to parameter of type       'const xmlChar *' (aka 'const unsigned char *') converts between pointers       to integer types with different sign [-Wpointer-sign]         owner_doc = x_PmmNodeToSv(INT2PTR(xmlNodePtr,xmlNewDoc("1.0")),NULL);                                                                ^~~~~ /System/Library/Perl/5.12/darwin-thread-multi-2level/CORE/perl.h:1759:32: note:       expanded from macro 'INT2PTR' #  define INT2PTR(any,d)        (any)(d)                                       ^ /sw/include/libxml2/libxml/tree.h:775:30: note: passing argument to parameter       'version' here                 xmlNewDoc               (const xmlChar *version);                                                         ^ LibXSLT.xs:916:16: warning: using the result of an assignment as a condition       without parentheses [-Wparentheses]     while (key = hv_iternext(functions))            ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ LibXSLT.xs:916:16: note: place parentheses around the assignment to silence this       warning     while (key = hv_iternext(functions))                ^            (                           ) LibXSLT.xs:916:16: note: use '==' to turn this assignment into an equality       comparison     while (key = hv_iternext(functions))                ^                == LibXSLT.xs:948:16: warning: using the result of an assignment as a condition       without parentheses [-Wparentheses]     while (key = hv_iternext(functions))            ~~~~^~~~~~~~~~~~~~~~~~~~~~~~ LibXSLT.xs:948:16: note: place parentheses around the assignment to silence this       warning     while (key = hv_iternext(functions))                ^            (                           ) LibXSLT.xs:948:16: note: use '==' to turn this assignment into an equality       comparison     while (key = hv_iternext(functions))                ^                == 3 warnings generated. dan -- Daniel Macks dmacks@netspace.org
Hi Daniel, thanks for the report, and sorry for the late response. I corrected the code and fixed the warnings for version 1.83 of XML-LibXSLT. Resolving. Let me know if there are still problems. Regards, -- Shlomi Fish


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.