This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id:
91049
Status:
open
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
mkmetw [...] hotmail.com
Cc:
AdminCc:

BugTracker
Severity:
Unimportant
Broken in:
(no value)
Fixed in:
(no value)



Subject: Test failures for Module-Build-0.4203
Date: Fri, 29 Nov 2013 10:38:26 +0000
To: "bug-Module-Build@rt.cpan.org" <bug-module-build@rt.cpan.org>, "module-build@perl.org" <module-build@perl.org>
From: Manoj Kumar <mkmetw@hotmail.com>
Hi,

I am trying to install Module::Build 0.4203 on a Windows XP machine with Perl 5.14.2 and 3 of the test programs are failing. For details, please see http://cpantesters.org/cpan/report/e4cf6b7d-5b83-1016-8517-45cda0cab74a.

These tests are failing since (at least) Module::Build 0.40 - http://cpantesters.org/cpan/report/3b7579ca-7643-1014-87f1-7dc2a0cab74a.

t/properties/needs_compiler.t and t/xs.t are failing because, in the verbose mode, Module::Build::Base::have_c_compiler displays 'ok' which is interpreted by the test harness as the result of a non-planned test. To avoid this kind of failure, I propose to modify the Module::Build::Base::have_c_compiler so that it displays 'passed' in place of 'ok'.

t/test_type.t fails because it runs another test file which confuses the test harness. To avoid this failure, I propose to  capture the output of the sub test using stdout_of and then check the pass / fail result in the main test file (t/test_type.t).

I have attached the two patch files.

Thanks.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #91049] Test failures for Module-Build-0.4203
Date: Fri, 29 Nov 2013 14:55:48 +0100
To: bug-Module-Build@rt.cpan.org
From: Leon Timmermans <fawaka@gmail.com>
On Fri, Nov 29, 2013 at 11:38 AM, Manoj Kumar via RT <bug-Module-Build@rt.cpan.org> wrote:
Show quoted text
I am trying to install Module::Build 0.4203 on a Windows XP machine with Perl 5.14.2 and 3 of the test programs are failing. For details, please see http://cpantesters.org/cpan/report/e4cf6b7d-5b83-1016-8517-45cda0cab74a.

These tests are failing since (at least) Module::Build 0.40 - http://cpantesters.org/cpan/report/3b7579ca-7643-1014-87f1-7dc2a0cab74a.

t/properties/needs_compiler.t and t/xs.t are failing because, in the verbose mode, Module::Build::Base::have_c_compiler displays 'ok' which is interpreted by the test harness as the result of a non-planned test. To avoid this kind of failure, I propose to modify the Module::Build::Base::have_c_compiler so that it displays 'passed' in place of 'ok'.

Logging should not affect the harness. This looks to me like there is an underlying bug there that should be fixed rather than worked around. I can't replicate this under Linux, I'm wondering if this is an Open3 on Windows bug.

Show quoted text
t/test_type.t fails because it runs another test file which confuses the test harness. To avoid this failure, I propose to  capture the output of the sub test using stdout_of and then check the pass / fail result in the main test file (t/test_type.t).

I'm wondering if this isn't caused by the same underlying bug.

Leon
Please provide exact instructions for reproducing the issue. I tried with Strawberry Perl Nov 2011 5.14.2.1 / 32bit on Windows 7 with these commands: d:\cpan\mb>perl Build.PL d:\cpan\mb>set PERL_MB_OPT=--verbose d:\cpan\mb>Build test --test_files t/properties/needs_compiler.t The result was a PASS.
Subject: RE: [rt.cpan.org #91049] Test failures for Module-Build-0.4203
Date: Fri, 29 Nov 2013 16:42:53 +0000
To: "bug-Module-Build@rt.cpan.org" <bug-module-build@rt.cpan.org>
From: Manoj Kumar <mkmetw@hotmail.com>
Hi,

My PC is Windows XP 32-bit with SP3, Perl 5.14.2 and I use Visual Studio 8 C compiler.

As you already have d:\cpan\mb directory, I'll use it for this test.

1. Setup envoronment variables -
set HOMEDRIVE=d:
set HOMEPATH=\cpan\mb

2. Create .modulebuildrc in d:\cpan\mb with following data -
*        --debug --verbose

3. Build and test M::B

The tests should fail.

If you remove .modulebuildrc, the tests will pass.

> Subject: [rt.cpan.org #91049] Test failures for Module-Build-0.4203
> From: bug-Module-Build@rt.cpan.org
> To: mkmetw@hotmail.com
> Date: Fri, 29 Nov 2013 10:26:54 -0500
>
> <URL: https://rt.cpan.org/Ticket/Display.html?id=91049 >
>
> Please provide exact instructions for reproducing the issue. I tried with
>
> Strawberry Perl Nov 2011
> 5.14.2.1 / 32bit
> on Windows 7
>
> with these commands:
>
> d:\cpan\mb>perl Build.PL
> d:\cpan\mb>set PERL_MB_OPT=--verbose
> d:\cpan\mb>Build test --test_files t/properties/needs_compiler.t
>
> The result was a PASS.
Subject: RE: [rt.cpan.org #91049] Test failures for Module-Build-0.4203
Date: Tue, 3 Dec 2013 16:24:36 +0000
To: "bug-Module-Build@rt.cpan.org" <bug-module-build@rt.cpan.org>
From: Manoj Kumar <mkmetw@hotmail.com>
Hi,

It seems the problem is in t/lib/MBTest.pm which does not delete Windows specific environment variables.

Regards,


From: mkmetw@hotmail.com
To: bug-module-build@rt.cpan.org
Subject: RE: [rt.cpan.org #91049] Test failures for Module-Build-0.4203
Date: Fri, 29 Nov 2013 16:42:53 +0000

Hi,

My PC is Windows XP 32-bit with SP3, Perl 5.14.2 and I use Visual Studio 8 C compiler.

As you already have d:\cpan\mb directory, I'll use it for this test.

1. Setup envoronment variables -
set HOMEDRIVE=d:
set HOMEPATH=\cpan\mb

2. Create .modulebuildrc in d:\cpan\mb with following data -
*        --debug --verbose

3. Build and test M::B

The tests should fail.

If you remove .modulebuildrc, the tests will pass.

> Subject: [rt.cpan.org #91049] Test failures for Module-Build-0.4203
> From: bug-Module-Build@rt.cpan.org
> To: mkmetw@hotmail.com
> Date: Fri, 29 Nov 2013 10:26:54 -0500
>
> <URL: https://rt.cpan.org/Ticket/Display.html?id=91049 >
>
> Please provide exact instructions for reproducing the issue. I tried with
>
> Strawberry Perl Nov 2011
> 5.14.2.1 / 32bit
> on Windows 7
>
> with these commands:
>
> d:\cpan\mb>perl Build.PL
> d:\cpan\mb>set PERL_MB_OPT=--verbose
> d:\cpan\mb>Build test --test_files t/properties/needs_compiler.t
>
> The result was a PASS.

Message body is not shown because sender requested not to inline it.



This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.