Skip Menu |
 

This queue is for tickets about the Search-Sitemap CPAN distribution.

Report information
The Basics
Id: 90909
Status: open
Priority: 0/
Queue: Search-Sitemap

People
Owner: Nobody in particular
Requestors: upasna.shukla [...] gmail.com
cpan [...] zoffix.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: New Moose may break your code
Date: Fri, 29 Nov 2013 03:34:27 +0530
To: bug-Search-Sitemap [...] rt.cpan.org
From: "Upasana Shukla" <upasna.shukla [...] gmail.com>
Download (untitled) / with headers
text/plain 535b
We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.
Attached patch fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]
Subject: Search-Sitemap-2.13.patch
diff -Naur Search-Sitemap-2.13_orig/lib/Search/Sitemap/Types.pm Search-Sitemap-2.13/lib/Search/Sitemap/Types.pm --- Search-Sitemap-2.13_orig/lib/Search/Sitemap/Types.pm 2014-01-24 20:33:09.998361343 -0500 +++ Search-Sitemap-2.13/lib/Search/Sitemap/Types.pm 2014-01-24 20:33:55.570361940 -0500 @@ -2,6 +2,7 @@ use strict; use warnings; our $VERSION = '2.13'; our $AUTHORITY = 'cpan:JASONK'; +use Class::Load; use MooseX::Types -declare => [qw( SitemapURL SitemapUrlStore SitemapChangeFreq SitemapLastMod SitemapPriority XMLPrettyPrintValue XMLTwig SitemapPinger @@ -15,11 +16,11 @@ coerce SitemapURL, from HashRef, via { - Class::MOP::load_class( 'Search::Sitemap::URL' ); + Class::Load::load_class( 'Search::Sitemap::URL' ); Search::Sitemap::URL->new( $_ ); }, from Str, via { - Class::MOP::load_class( 'Search::Sitemap::URL' ); + Class::Load::load_class( 'Search::Sitemap::URL' ); Search::Sitemap::URL->new( loc => $_ ); }; @@ -128,12 +129,12 @@ my $class = $type =~ /::/ ? $type : 'Search::Sitemap::URLStore::'.$type; - Class::MOP::load_class( $class ); + Class::Load::load_class( $class ); $class->new( $_ ) }, from Str, via { my $class = 'Search::Sitemap::URLStore::'.$_; - Class::MOP::load_class( $class ); + Class::Load::load_class( $class ); return $class->new; }; @@ -144,7 +145,7 @@ subtype SitemapPinger, as 'Search::Sitemap::Pinger'; coerce SitemapPinger, from Str, via { my $class = 'Search::Sitemap::Pinger::'.$_; - Class::MOP::load_class( $class ); + Class::Load::load_class( $class ); return $class->new; }; diff -Naur Search-Sitemap-2.13_orig/lib/Search/Sitemap.pm Search-Sitemap-2.13/lib/Search/Sitemap.pm --- Search-Sitemap-2.13_orig/lib/Search/Sitemap.pm 2014-01-24 20:33:09.998361343 -0500 +++ Search-Sitemap-2.13/lib/Search/Sitemap.pm 2014-01-24 20:34:13.762362179 -0500 @@ -13,6 +13,7 @@ use IO::File; use Carp qw( carp croak ); use HTML::Entities qw( decode_entities ); +use Class::Load; use namespace::clean -except => 'meta'; has 'urls' => ( @@ -20,7 +21,7 @@ isa => SitemapUrlStore, coerce => 1, default => sub { - Class::MOP::load_class( 'Search::Sitemap::URLStore::Memory' ); + Class::Load::load_class( 'Search::Sitemap::URLStore::Memory' ); return Search::Sitemap::URLStore::Memory->new; }, handles => { @@ -79,7 +80,7 @@ lazy => 1, default => sub { local $@; - eval { Class::MOP::load_class( 'IO::Zlib' ) }; + eval { Class::Load::load_class( 'IO::Zlib' ) }; return $@ ? 0 : 1; }, ); diff -Naur Search-Sitemap-2.13_orig/Makefile.PL Search-Sitemap-2.13/Makefile.PL --- Search-Sitemap-2.13_orig/Makefile.PL 2014-01-24 20:33:09.994361343 -0500 +++ Search-Sitemap-2.13/Makefile.PL 2014-01-24 20:34:30.202362394 -0500 @@ -7,7 +7,7 @@ Moose LWP::UserAgent XML::Twig IO::File Carp POSIX IO::Zlib Class::Trigger HTML::Entities Module::Find Moose::Util::TypeConstraints MooseX::Types MooseX::Types::Moose MooseX::ClassAttribute namespace::clean - MooseX::Types::URI DateTime + MooseX::Types::URI DateTime Class::Load ); test_requires $_ for qw(


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.