Skip Menu |
 

This queue is for tickets about the Google-Chart CPAN distribution.

Report information
The Basics
Id: 90659
Status: open
Priority: 0/
Queue: Google-Chart

People
Owner: Nobody in particular
Requestors: upasna.shukla [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
Google-Chart-moose-enum-warnings.patch



Subject: New Moose may break your code
Date: Sat, 23 Nov 2013 07:57:22 +0530
To: bug-Google-Chart [...] rt.cpan.org
From: "Upasana Shukla" <upasna.shukla [...] gmail.com>
Download (untitled) / with headers
text/plain 547b
We recently changed the syntax of enum declarations in Moose types. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.
Attached patch fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]
Subject: Google-Chart-moose-enum-warnings.patch
diff -Naur Google-Chart-0.05014_orig/lib/Google/Chart/Axis/Item.pm Google-Chart-0.05014/lib/Google/Chart/Axis/Item.pm --- Google-Chart-0.05014_orig/lib/Google/Chart/Axis/Item.pm 2014-01-21 20:36:34.596499940 -0500 +++ Google-Chart-0.05014/lib/Google/Chart/Axis/Item.pm 2014-01-21 20:38:27.736501422 -0500 @@ -5,7 +5,7 @@ use Moose::Util::TypeConstraints; use Google::Chart::Axis::Style; -enum 'Google::Chart::Axis::Location' => qw(x y r t); +enum 'Google::Chart::Axis::Location' => [qw(x y r t)]; subtype 'Google::Chart::Axis::StyleList' => as 'ArrayRef[Google::Chart::Axis::Style]' diff -Naur Google-Chart-0.05014_orig/lib/Google/Chart/Axis/Style.pm Google-Chart-0.05014/lib/Google/Chart/Axis/Style.pm --- Google-Chart-0.05014_orig/lib/Google/Chart/Axis/Style.pm 2014-01-21 20:36:34.596499940 -0500 +++ Google-Chart-0.05014/lib/Google/Chart/Axis/Style.pm 2014-01-21 20:38:34.016501504 -0500 @@ -5,7 +5,7 @@ use Moose::Util::TypeConstraints; use Google::Chart::Types; -enum 'Google::Chart::Axis::Alignment' => qw(-1 0 1); +enum 'Google::Chart::Axis::Alignment' => [qw(-1 0 1)]; has 'color' => ( is => 'rw', diff -Naur Google-Chart-0.05014_orig/lib/Google/Chart/Marker.pm Google-Chart-0.05014/lib/Google/Chart/Marker.pm --- Google-Chart-0.05014_orig/lib/Google/Chart/Marker.pm 2014-01-21 20:36:34.596499940 -0500 +++ Google-Chart-0.05014/lib/Google/Chart/Marker.pm 2014-01-21 20:37:11.768500427 -0500 @@ -81,7 +81,7 @@ } ; -enum 'Google::Chart::Marker::Item::Type' => ( +enum 'Google::Chart::Marker::Item::Type' => [ 'a', # arrow 'c', # corrs 'd', # diamond @@ -93,7 +93,7 @@ 'h', # horizontal line across 'x', # x shape 'D', # Line and bar chart line styles -); +]; has 'marker_type' => ( is => 'rw', diff -Naur Google-Chart-0.05014_orig/lib/Google/Chart/Type/Bar.pm Google-Chart-0.05014/lib/Google/Chart/Type/Bar.pm --- Google-Chart-0.05014_orig/lib/Google/Chart/Type/Bar.pm 2014-01-21 20:36:34.596499940 -0500 +++ Google-Chart-0.05014/lib/Google/Chart/Type/Bar.pm 2014-01-21 20:37:50.144500927 -0500 @@ -6,7 +6,7 @@ with 'Google::Chart::Type::Simple'; -enum 'Google::Chart::Type::Bar::Orientation' => qw(horizontal vertical); +enum 'Google::Chart::Type::Bar::Orientation' => [qw(horizontal vertical)]; has 'stacked' => ( is => 'rw', diff -Naur Google-Chart-0.05014_orig/lib/Google/Chart/Type/QRcode.pm Google-Chart-0.05014/lib/Google/Chart/Type/QRcode.pm --- Google-Chart-0.05014_orig/lib/Google/Chart/Type/QRcode.pm 2014-01-21 20:36:34.596499940 -0500 +++ Google-Chart-0.05014/lib/Google/Chart/Type/QRcode.pm 2014-01-21 20:38:03.392501103 -0500 @@ -5,8 +5,8 @@ use Moose::Util::TypeConstraints; use Encode (); -enum 'Google::Chart::Type::QRcode::Encoding' => qw(shift_jis utf-8 iso-8859-1); -enum 'Google::Chart::Type::QRcode::ECLevel' => qw(L M Q H); +enum 'Google::Chart::Type::QRcode::Encoding' => [qw(shift_jis utf-8 iso-8859-1)]; +enum 'Google::Chart::Type::QRcode::ECLevel' => [qw(L M Q H)]; coerce 'Google::Chart::Type::QRcode::Encoding' => from 'Str'


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.