Skip Menu |
 

This queue is for tickets about the App-cpanminus-reporter CPAN distribution.

Report information
The Basics
Id: 90601
Status: resolved
Priority: 0/
Queue: App-cpanminus-reporter

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: deep recursion
Download (untitled) / with headers
text/plain 292b
While sending a bunch of reports (after a new perl install, so there were a *lot* of modules that I installed in one go), I saw this several times: Deep recursion on anonymous subroutine at /Users/ether/.perlbrew/libs/19.5@std/lib/perl5/App/cpanminus/reporter.pm line 206, <$fh> line 24837.
Download (untitled) / with headers
text/plain 245b
I just ran into this again when installing lots of things with perl 5.19.7: Deep recursion on anonymous subroutine at /Users/ether/.perlbrew/libs/19.7@std/lib/perl5/App/cpanminus/reporter.pm line 206, <$fh> line 40930. I cannot haz reports? :(
Download (untitled) / with headers
text/plain 447b
Hi ether! the parser is recursive indeed, and I agree 100 (perl's limit) might be a bit too short of a limit, specially to cover tons of nested deps such as on clean builds. I'll wrap the parser under a "no warnings 'recursion'" and see how it goes. I'd still feel more comfortable with some limit, though. How about you send me a faulty build.log (one that triggers the message) and I add it to the tests and use it to set a new limit? Thanks!
Download (untitled) / with headers
text/plain 664b
On 2014-03-17 23:22:15, GARU wrote: Show quoted text
> Hi ether! > > the parser is recursive indeed, and I agree 100 (perl's limit) might > be a bit too short of a limit, specially to cover tons of nested deps > such as on clean builds. I'll wrap the parser under a "no warnings > 'recursion'" and see how it goes. > > I'd still feel more comfortable with some limit, though. How about you > send me a faulty build.log (one that triggers the message) and I add > it to the tests and use it to set a new limit? > > Thanks!
I was able to reproduce this again, with a fresh 5.20.0 build! \o/ Attached is the build log (1.9MB!) /Users/ether/.cpanm/work/1401124766.32545/build.log
Subject: build.log
Download build.log
application/octet-stream 1.8m

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 33.8k

Message body is not shown because it is too large.

Download (untitled) / with headers
text/plain 226b
Thanks! I'm trying to turn your log into a test case, but right now it just takes too long to run so I just shipped v0.11 with just the fix, not the test for it. Hopefully I'll get to the proper test soon. But it's fixed! :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.