Skip Menu |
 

This queue is for tickets about the Net-Async-IRC CPAN distribution.

Report information
The Basics
Id: 90487
Status: resolved
Priority: 0/
Queue: Net-Async-IRC

People
Owner: Nobody in particular
Requestors: andreas.guldstrand [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.09



Subject: Nick change not properly set when connecting and getting an ERR_NICKINUSE
Date: Mon, 18 Nov 2013 18:19:13 +0100
To: bug-Net-Async-IRC [...] rt.cpan.org
From: Andreas Guldstrand <andreas.guldstrand [...] gmail.com>
Download (untitled) / with headers
text/plain 570b
<pink_mist> LeoNerd: I've got a problem with Net::Async::IRC ... if I connect to a server and the nick I want to use is already in use, I get an ERR_NICKINUSE, and can issue a new change_nick using a different nickname .. however that nick isn't "set" since https://metacpan.org/source/PEVANS/Net-Async-IRC-0.07/lib/Net/Async/IRC.pm#L353 doesn't realize that the prefix can be empty if the server hasn't actually given you a nick yet <LeoNerd> Define "that nick isn't set" <pink_mist> $self->_set_nick( $hints->{new_nick} ); <-- is never called
Subject: Re: [rt.cpan.org #90487] AutoReply: Nick change not properly set when connecting and getting an ERR_NICKINUSE
Date: Mon, 18 Nov 2013 18:29:42 +0100
To: bug-Net-Async-IRC [...] rt.cpan.org
From: Andreas Guldstrand <andreas.guldstrand [...] gmail.com>
Download (untitled) / with headers
text/plain 651b
Damn gmail compose box making me format the text horribly wrong, this should be more readable ... I hope <pink_mist> LeoNerd: I've got a problem with Net::Async::IRC ... if I connect to a server and the nick I want to use is already in use, I get an ERR_NICKINUSE, and can issue a new change_nick using a different nickname .. however that nick isn't "set" since https://metacpan.org/source/PEVANS/Net-Async-IRC-0.07/lib/Net/Async/IRC.pm#L353doesn't realize that the prefix can be empty if the server hasn't actually given you a nick yet <LeoNerd> Define "that nick isn't set" <pink_mist> $self->_set_nick( $hints->{new_nick} ); <-- is never called
Subject: Re: [rt.cpan.org #90487] AutoReply: Nick change not properly set when connecting and getting an ERR_NICKINUSE [PATCH]
Date: Wed, 20 Nov 2013 13:28:15 +0100
To: bug-Net-Async-IRC [...] rt.cpan.org
From: Andreas Guldstrand <andreas.guldstrand [...] gmail.com>
I've created a patch that seems to fix the problem for me; tests included!
Download err_nick_fix.patch
text/x-diff 2.7k

Message body is not shown because sender requested not to inline it.

Thanks; patch now applied in latest source. Will be in next version. -- Paul Evans
Released in 0.09 -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.