Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DB_File CPAN distribution.

Report information
The Basics
Id:
90383
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
HMBRAND [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
Critical
Broken in:
1.830
Fixed in:
1.831



Subject: C99 comment is a nogo
Already fixed in blead http://perl5.git.perl.org/perl.git/commit/1b7c306550e17237aec242cbef7ad7c3fdbd16f5 commit 1b7c306550e17237aec242cbef7ad7c3fdbd16f5 Author: H.Merijn Brand <h.m.brand@xs4all.nl> Date: Thu Nov 14 12:53:03 2013 +0100 NO C99 comments, please! diff --git a/cpan/DB_File/DB_File.xs b/cpan/DB_File/DB_File.xs index 83ba736..679c416 100644 --- a/cpan/DB_File/DB_File.xs +++ b/cpan/DB_File/DB_File.xs @@ -1498,7 +1498,7 @@ SV * sv ; if (status) { - db_close(RETVAL); // close **dbp handle to prevent mem.leak + db_close(RETVAL); /* close **dbp handle to prevent mem.leak */ RETVAL->dbp = NULL ; }
Good catch. Uploaded fixed version to CPAN. Paul


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.