Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 90353
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.55
Fixed in: (no value)



Subject: [patch] 50_external.t fails when alioth.debian.org is down
@sock will have 3 elements instead of 4. -- Alexandr Ciornii, http://chorny.net
Subject: 50_external.t.patch
--- 50_external.t.orig 2013-02-28 23:46:57.000000000 +0200 +++ 50_external.t 2013-11-14 11:52:33.000000000 +0200 @@ -28,8 +28,8 @@ tie(*$ssl, 'Net::SSLeay::Handle', $site, 443); }; - skip('could not connect', 2) if $@; - pass('connection'); + skip('could not connect to '.$site, 2) if $@; + pass('connection to '.$site); print $ssl "GET / HTTP/1.0\r\n\r\n"; my $resp = do { local $/ = undef; <$ssl> }; @@ -47,10 +47,13 @@ tie(*$ssl, 'Net::SSLeay::Handle', $sites[$i], 443); }; + $sock[$i] = undef; #so scalar @sock == scalar @sites + skip('could not connect', 2) if $@; pass('connection'); $sock[$i] = $ssl; + ok( $ssl, 'got handle' ); } } @@ -70,8 +73,7 @@ for my $sock (@sock) { SKIP : { skip('not connected', 1) unless defined $sock; - pass('connected'); - close($sock); + ok(close($sock), 'socket closed'); } } }
Subject: Re: [rt.cpan.org #90353] [patch] 50_external.t fails when alioth.debian.org is down
Date: Tue, 19 Nov 2013 14:20:30 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 871b
Hi, thanks for your patch. It will appear in SVN as soon as possible (alas the svn host is currently down). Cheers. On Thursday, November 14, 2013 04:54:20 AM Alexandr Ciornii via RT wrote: Show quoted text
> Thu Nov 14 04:54:19 2013: Request 90353 was acted upon. > Transaction: Ticket created by CHORNY > Queue: Net-SSLeay > Subject: [patch] 50_external.t fails when alioth.debian.org is down > Broken in: 1.55 > Severity: Unimportant > Owner: Nobody > Requestors: CHORNY@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=90353 > > > > @sock will have 3 elements instead of 4.
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070
Subject: Re: [rt.cpan.org #90353] [patch] 50_external.t fails when alioth.debian.org is down
Date: Wed, 27 Nov 2013 13:00:05 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Alioth is now back and the patch is in svn rev 385 Cheers. On Tuesday, November 19, 2013 02:20:30 PM Mike McCauley wrote: Show quoted text
> Hi, > > thanks for your patch. It will appear in SVN as soon as possible (alas the > svn host is currently down). > > Cheers. > > On Thursday, November 14, 2013 04:54:20 AM Alexandr Ciornii via RT wrote:
> > Thu Nov 14 04:54:19 2013: Request 90353 was acted upon. > > Transaction: Ticket created by CHORNY > > > > Queue: Net-SSLeay > > > > Subject: [patch] 50_external.t fails when alioth.debian.org is down > > > > Broken in: 1.55 > > > > Severity: Unimportant > > > > Owner: Nobody > > > > Requestors: CHORNY@cpan.org > > > > Status: new > > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=90353 > > > > > @sock will have 3 elements instead of 4.
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.