Skip Menu |
 

This queue is for tickets about the Sys-Syslog CPAN distribution.

Report information
The Basics
Id: 90212
Status: resolved
Priority: 0/
Queue: Sys-Syslog

People
Owner: SAPER [...] cpan.org
Requestors: fraserbn [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.34



Subject: Use fallback/syslog.h if I_SYSLOG is not defined
Download (untitled) / with headers
text/plain 636b
Syslog.xs should be including fallback/syslog.h on non-Windows systems where syslog.h is not defined -- for example, the Blackberry 10+ series of devices uses a stripped down verison of QNX NTO which doesn't have the header[*]. I'm also not sure what the '|| PATCHLEVEL < 6' bit is about -- if on 5.5 or earlier, always include the header? I had to remove it to actually make the fallback work. # undef HAVE_SYSLOG # include "fallback/syslog.h" #else -# if defined(I_SYSLOG) || PATCHLEVEL < 6 +# if defined(I_SYSLOG) # include <syslog.h> +# else +# undef HAVE_SYSLOG +# include "fallback/syslog.h" # endif #endif
Subject: Re: [rt.cpan.org #90212] Use fallback/syslog.h if I_SYSLOG is not defined
Date: Thu, 21 Nov 2013 01:11:13 +0100
To: bug-Sys-Syslog [...] rt.cpan.org
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
Download (untitled) / with headers
text/plain 940b
Brian Fraser wrote via RT: Show quoted text
> Syslog.xs should be including fallback/syslog.h on non-Windows systems where syslog.h is not defined -- for example, the Blackberry 10+ series of devices uses a stripped down verison of QNX NTO which doesn't have the header[*]. > > I'm also not sure what the '|| PATCHLEVEL < 6' bit is about -- if on 5.5 or earlier, always include the header? I had to remove it to actually make the fallback work.
Hmm, I *think* that's because I_SYSLOG wasn't defined by Configure back then. IIRC, someone on p5p, knowledge of metaunit, pointed this. Show quoted text
> # undef HAVE_SYSLOG > # include "fallback/syslog.h" > #else > -# if defined(I_SYSLOG) || PATCHLEVEL < 6 > +# if defined(I_SYSLOG) > # include <syslog.h> > +# else > +# undef HAVE_SYSLOG > +# include "fallback/syslog.h" > # endif > #endif
Thanks, applied the second part of the chunk. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.
This issue should be fixed with version 0.34, just released. -- Close the world, txEn eht nepO.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.