Skip Menu |
 

This queue is for tickets about the App-cpanminus-reporter CPAN distribution.

Report information
The Basics
Id: 89985
Status: resolved
Priority: 0/
Queue: App-cpanminus-reporter

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: 0.14



Subject: feature request: support N/A builds
Download (untitled) / with headers
text/plain 1.4k
Is it possible to detect and report on N/A builds? example: : [ether@bourbon ~/git]$; cpanm Dist::Zilla::PluginBundle::Author::ETHER; cpanm-reporter --> Working on Dist::Zilla::PluginBundle::Author::ETHER Fetching http://mirrors.gossamer-threads.com/CPAN/authors/id/E/ET/ETHER/Dist-Zilla-PluginBundle-Author-ETHER-0.035.tar.gz ... OK Configuring Dist-Zilla-PluginBundle-Author-ETHER-0.035 ... N/A ! Configure failed for Dist-Zilla-PluginBundle-Author-ETHER-0.035. See /Users/ether/.cpanm/work/1383417957.69205/build.log for details. The build.log contains: --> Working on Dist::Zilla::PluginBundle::Author::ETHER Fetching http://mirrors.gossamer-threads.com/CPAN/authors/id/E/ET/ETHER/Dist-Zilla-PluginBundle-Author-ETHER-0.035.tar.gz -> OK Unpacking Dist-Zilla-PluginBundle-Author-ETHER-0.035.tar.gz Entering Dist-Zilla-PluginBundle-Author-ETHER-0.035 Checking configure dependencies from META.json Checking if you have ExtUtils::MakeMaker 6.30 ... Yes (6.80) Checking if you have File::ShareDir::Install 0.03 ... Yes (0.05) Configuring Dist-Zilla-PluginBundle-Author-ETHER-0.035 Running Makefile.PL Perl v5.13.2 required--this is only v5.12.5, stopped at Makefile.PL line 5. BEGIN failed--compilation aborted at Makefile.PL line 5. -> N/A -> FAIL Configure failed for Dist-Zilla-PluginBundle-Author-ETHER-0.035. See /Users/ether/.cpanm/work/1383417609.68811/build.log for details.
Download (untitled) / with headers
text/plain 440b
Hi Ether! It *should* detect NA reports, but it's mimicking the behaviour of CPAN::Reporter, which only sends reports if they actually make it to the "Building and testing" phase (where they can leave on a PASS, FAIL or N/A state). The log you pasted stops at the Configure step, so the reporter doesn't send anything. I'll double-check anyway if this is the proper behaviour or if I screwed up somewhere, and update the ticket! Thanks!
Subject: Re: [rt.cpan.org #89985] feature request: support N/A builds
Date: Tue, 18 Mar 2014 11:47:13 -0700
To: "Breno G. de Oliveira via RT" <bug-App-cpanminus-reporter [...] rt.cpan.org>
From: Karen Etheridge <karen [...] etheridge.ca>
Download (untitled) / with headers
text/plain 960b
On Tue, Mar 18, 2014 at 02:31:19AM -0400, Breno G. de Oliveira via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=89985 > > > Hi Ether! > > It *should* detect NA reports, but it's mimicking the behaviour of CPAN::Reporter, which only sends reports if they actually make it to the "Building and testing" phase (where they can leave on a PASS, FAIL or N/A state). The log you pasted stops at the Configure step, so the reporter doesn't send anything.
After gaining more understanding of the meaning of 'NA', I concur that sending no report is the correct course of action (should Makefile.PL exit with a status of zero, as opposed to an actual error condition). Show quoted text
> I'll double-check anyway if this is the proper behaviour or if I screwed up somewhere, and update the ticket!
I would suggest that cpanm-reporter say this explicitly - e.g. something like: "Makefile.PL exited with status 0 and no Makefile produced; no report sent (NA status)"
Subject: NA reports aren't being sent
Download (untitled) / with headers
text/plain 1.3k
build.log contains: earching Dist::Zilla::Plugin::MungeFile::WithDataSection () on metacpan ... --> Working on Dist::Zilla::Plugin::MungeFile::WithDataSection Fetching http://www.cpan.org/authors/id/E/ET/ETHER/Dist-Zilla-Plugin-MungeFile-WithDataSection-0.007.tar.gz -> OK Unpacking Dist-Zilla-Plugin-MungeFile-WithDataSection-0.007.tar.gz Entering Dist-Zilla-Plugin-MungeFile-WithDataSection-0.007 Checking configure dependencies from META.json Checking if you have Module::Build::Tiny 0.034 ... Yes (0.035) Checking if you have ExtUtils::MakeMaker 6.30 ... Yes (6.97_02) Checking if you have Module::Build 0.36 ... Yes (0.4205) Configuring Dist-Zilla-Plugin-MungeFile-WithDataSection-0.007 Running Build.PL Perl v5.9.5 required--this is only v5.8.9, stopped at Build.PL line 2. BEGIN failed--compilation aborted at Build.PL line 2. Running Makefile.PL Perl v5.9.5 required--this is only v5.8.9, stopped at Makefile.PL line 64. BEGIN failed--compilation aborted at Makefile.PL line 64. Congratulations, your toolchain understands 'configure_requires'! -> N/A -> FAIL Configure failed for Dist-Zilla-Plugin-MungeFile-WithDataSection-0.007. See /Users/ether/.cpanm/work/1398728750.58077/build.log for details. then when I run cpanm-reporter, I don't see any report being sent for this dist. NA reports are still valuable, so it would be good to send these.
Download (untitled) / with headers
text/plain 361b
Looks like I filed this earlier at RT#89985. However I don't understand why me-in-the-past backed down and conceded that it would be ok to not send reports if Makefile.PL terminates early... as this is not what the smokers do. The smokers commonly send NA reports when attempting to test distributions but the OS is not supported or the perl version is too old.
Download (untitled) / with headers
text/plain 500b
On 2014-04-28 17:26:34, ETHER wrote: Show quoted text
> Looks like I filed this earlier at RT#89985. However I don't > understand why me-in-the-past backed down and conceded that it would > be ok to not send reports if Makefile.PL terminates early... as this > is not what the smokers do. The smokers commonly send NA reports when > attempting to test distributions but the OS is not supported or the > perl version is too old.
e.g. see http://matrix.cpantesters.org/?dist=Dist-Zilla-PluginBundle-Author-ETHER+0.059
Fixed in 0.14!
Download (untitled) / with headers
text/plain 110b
Are we sure this was fixed? (What exactly was fixed in 0.14?) I am not seeing any NA reports sent under 0.17.
Download (untitled) / with headers
text/plain 210b
Oops, my mistake! I failed to notice that the perlbrew in which NA reports weren't being sent was still running an older cpanm-reporter, due to the previously-reported issue with CPAN::Testers::Common::Client.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.