Skip Menu |
 

This queue is for tickets about the GD CPAN distribution.

Report information
The Basics
Id: 89592
Status: open
Priority: 0/
Queue: GD

People
Owner: Nobody in particular
Requestors: dsh [...] bamus.cz
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Makefile.PL checks version of libgd using wrong way (the check is broken)
Date: Thu, 17 Oct 2013 18:29:44 +0200
To: bug-GD [...] rt.cpan.org
From: Denis Shaposhnikov <dsh [...] bamus.cz>
Download (untitled) / with headers
text/plain 676b
Hi! I'm using GD-2.50 with libgd-2.1.0. Yesterday I found I can't use copyRotated() because broken check of version 2.0.33 of libgd. It compares the minor only. Here my fix: --- Makefile.PL.orig 2013-07-02 22:32:51.000000000 +0200 +++ Makefile.PL 2013-10-17 00:15:39.189939467 +0200 @@ -281,7 +281,7 @@ $$options = $features; my ($minor) = $version =~ /^2\.\d+\.(\d+)$/; - $$options .= " GD_UNCLOSEDPOLY GD_ANIMGIF GD_FTCIRCLE VERSION_33" if defined($minor) && $minor >= 33; + $$options .= " GD_UNCLOSEDPOLY GD_ANIMGIF GD_FTCIRCLE VERSION_33"; my @correct_inc = map {s/^-I// && $_} split /\s+/,$cflags; check_for_stray_headers(@correct_inc);
Download (untitled) / with headers
text/plain 138b
Hi, Attached is an improved patch which still checks the version numbers, and wont break back compatibility with older versions of libgd.
Subject: gd-makefile-patch
Download gd-makefile-patch
application/octet-stream 678b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.