Skip Menu |
 

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 89417
Status: resolved
Priority: 0/
Queue: Test-Harness

People
Owner: Nobody in particular
Requestors: craigberry [...] mac.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] don't localize all of %ENV in harness.t
Date: Fri, 11 Oct 2013 21:58:43 -0500
To: bug-Test-Harness [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
Download (untitled) / with headers
text/plain 786b
Because if you do, on VMS you fall down hard with: Can't make list assignment to %ENV on this system at t/harness.t line 17. So please just localize the entries you actually need, like so: --- t/harness.t;-0 2013-10-11 06:21:07 -0500 +++ t/harness.t 2013-10-11 17:55:57 -0500 @@ -14,7 +14,8 @@ use TAP::Harness; # This is done to prevent the colors environment variables from # interfering. -local %ENV = %ENV; +local $ENV{HARNESS_SUMMARY_COLOR_FAIL}; +local $ENV{HARNESS_SUMMARY_COLOR_SUCCESS}; delete $ENV{HARNESS_SUMMARY_COLOR_FAIL}; delete $ENV{HARNESS_SUMMARY_COLOR_SUCCESS}; [end] Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Download (untitled) / with headers
text/plain 851b
On Fri Oct 11 22:59:04 2013, craigberry@mac.com wrote: Show quoted text
> Because if you do, on VMS you fall down hard with: > > Can't make list assignment to %ENV on this system at t/harness.t line 17. > > So please just localize the entries you actually need, like so: > > --- t/harness.t;-0 2013-10-11 06:21:07 -0500 > +++ t/harness.t 2013-10-11 17:55:57 -0500 > @@ -14,7 +14,8 @@ use TAP::Harness; > > # This is done to prevent the colors environment variables from > # interfering. > -local %ENV = %ENV; > +local $ENV{HARNESS_SUMMARY_COLOR_FAIL}; > +local $ENV{HARNESS_SUMMARY_COLOR_SUCCESS}; > delete $ENV{HARNESS_SUMMARY_COLOR_FAIL}; > delete $ENV{HARNESS_SUMMARY_COLOR_SUCCESS};
I just applied this to the repo. Do you realize you have a commit-bit for the toolchain gang on github? Bugfixes like these don't need discussion to be applied IMO. Leon


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.