Skip Menu |
 

This queue is for tickets about the MailTools CPAN distribution.

Report information
The Basics
Id: 89371
Status: resolved
Priority: 0/
Queue: MailTools

People
Owner: Nobody in particular
Requestors: ward [...] gnu.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: format In-Reply-To header according to current best practices
Date: Wed, 9 Oct 2013 20:45:53 -0400
To: bug-MailTools [...] rt.cpan.org
From: Ward Vandewege <ward [...] gnu.org>
Download (untitled) / with headers
text/plain 442b
Cf: http://tools.ietf.org/html/rfc5322#section-3.2.2 this patch puts the comments in the In-Reply-To header in parentheses. Thanks, Ward. -- Ward Vandewege | CTO, Free Software Foundation GPG Key: 25F774AB | http://status.fsf.org/ward http://fsf.org/blogs/RSS | http://identi.ca/cure Do you use free software? Donate to join the FSF and support freedom at http://www.fsf.org/register_form?referrer=859
Download Internet.pm.patch
text/x-diff 610b

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date: Thu, 10 Oct 2013 09:12:58 +0200
To: Ward Vandewege via RT <bug-MailTools [...] rt.cpan.org>
From: Mark Overmeer <solutions [...] overmeer.net>
Download (untitled) / with headers
text/plain 1.5k
* Ward Vandewege via RT (bug-MailTools@rt.cpan.org) [131010 00:46]: Show quoted text
> Wed Oct 09 20:46:13 2013: Request 89371 was acted upon. > Transaction: Ticket created by ward@gnu.org > Queue: MailTools > Subject: format In-Reply-To header according to current best practices > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: ward@gnu.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=89371 > > > http://tools.ietf.org/html/rfc5322#section-3.2.2 > > this patch puts the comments in the In-Reply-To header in parentheses.
Ok. Show quoted text
> + $inreply .= ' (' if (defined $name or defined $date); > + $inreply .= 'from ' . $name if defined $name; > + $inreply .= 'on ' . $date if defined $date; > + $inreply .= ')' if (defined $name or defined $date);
This would glue the "on" to $name if both $name and $date are set. I have changed it into: if(defined $mid) { $inreply = $mid; my @comment; push @comment, "from $name" if defined $name; push @comment, "on $date" if defined $date; local $" = ' '; $inreply .= " (@comment)" if @comment; } Do you need this to be released soon? -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
Subject: Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date: Thu, 10 Oct 2013 10:08:08 -0400
To: Mark Overmeer via RT <bug-MailTools [...] rt.cpan.org>
From: Ward Vandewege <ward [...] gnu.org>
Download (untitled) / with headers
text/plain 1.1k
On Thu, Oct 10, 2013 at 03:13:27AM -0400, Mark Overmeer via RT wrote: Show quoted text
> > + $inreply .= ' (' if (defined $name or defined $date); > > + $inreply .= 'from ' . $name if defined $name; > > + $inreply .= 'on ' . $date if defined $date; > > + $inreply .= ')' if (defined $name or defined $date);
> > This would glue the "on" to $name if both $name and $date are set. > I have changed it into: > > if(defined $mid) > { $inreply = $mid; > my @comment; > push @comment, "from $name" if defined $name; > push @comment, "on $date" if defined $date; > local $" = ' '; > $inreply .= " (@comment)" if @comment; > }
Ah, that's much better. Thanks. Show quoted text
> Do you need this to be released soon?
I've patched our copy, there is no great urgency. Do you have a timeline in mind for a release? Thanks, Ward. -- Ward Vandewege | CTO, Free Software Foundation GPG Key: 25F774AB | http://status.fsf.org/ward http://fsf.org/blogs/RSS | http://identi.ca/cure Do you use free software? Donate to join the FSF and support freedom at http://www.fsf.org/register_form?referrer=859
Subject: Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date: Thu, 10 Oct 2013 16:10:00 +0200
To: Ward Vandewege via RT <bug-MailTools [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
Download (untitled) / with headers
text/plain 645b
* Ward Vandewege via RT (bug-MailTools@rt.cpan.org) [131010 14:08]: Show quoted text
> I've patched our copy, there is no great urgency. Do you have a timeline in > mind for a release?
That module is very old and very stable. I usually collect a few patches per release.... which can take months... unless you desparately need it. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
Subject: Re: [rt.cpan.org #89371] format In-Reply-To header according to current best practices
Date: Thu, 10 Oct 2013 10:50:06 -0400
To: Mark Overmeer via RT <bug-MailTools [...] rt.cpan.org>
From: Ward Vandewege <ward [...] gnu.org>
Download (untitled) / with headers
text/plain 828b
On Thu, Oct 10, 2013 at 10:10:26AM -0400, Mark Overmeer via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=89371 > > > * Ward Vandewege via RT (bug-MailTools@rt.cpan.org) [131010 14:08]:
> > I've patched our copy, there is no great urgency. Do you have a timeline in > > mind for a release?
> > That module is very old and very stable. I usually collect a few > patches per release.... which can take months... unless you > desparately need it.
No desperation here; that sounds like a fine plan. Thanks! Ward. -- Ward Vandewege | CTO, Free Software Foundation GPG Key: 25F774AB | http://status.fsf.org/ward http://fsf.org/blogs/RSS | http://identi.ca/cure Do you use free software? Donate to join the FSF and support freedom at http://www.fsf.org/register_form?referrer=859
fixed in 2.13


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.