Skip Menu |
 

This queue is for tickets about the Tickit-Widget-Tabbed CPAN distribution.

Report information
The Basics
Id: 89104
Status: resolved
Priority: 0/
Queue: Tickit-Widget-Tabbed

People
Owner: Nobody in particular
Requestors: TEAM [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.010
Fixed in: 0.011



Subject: Widget class not passed to ->new
Download (untitled) / with headers
text/plain 293b
This looks like an oversight - seems that passing the usual class/classes parameter to ->new does nothing, since we're not passing %args up to the ::Widget ->SUPER::new call. Makes styling a bit tricky for the rare cases when there are multiple tabbed widgets on the same page... cheers, Tom
Download (untitled) / with headers
text/plain 384b
On Tue Oct 01 08:59:37 2013, TEAM wrote: Show quoted text
> This looks like an oversight - seems that passing the usual > class/classes parameter to ->new does nothing, since we're not passing > %args up to the ::Widget ->SUPER::new call. Makes styling a bit tricky > for the rare cases when there are multiple tabbed widgets on the same > page...
Oh yes. Simple fix; patch attached. -- Paul Evans
Subject: rt89104.patch
Download rt89104.patch
text/x-diff 414b
=== modified file 'lib/Tickit/Widget/Tabbed.pm' --- lib/Tickit/Widget/Tabbed.pm 2013-08-31 20:49:09 +0000 +++ lib/Tickit/Widget/Tabbed.pm 2013-10-06 14:02:42 +0000 @@ -120,7 +120,7 @@ sub new { my $class = shift; my %args = @_; - my $self = $class->SUPER::new; + my $self = $class->SUPER::new(%args); $self->{tab_class} = delete($args{tab_class}); $self->{ribbon_class} = delete($args{ribbon_class});
Fixed in 0.011 -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.