Skip Menu |
 

This queue is for tickets about the CGI-SSI CPAN distribution.

Report information
The Basics
Id: 88497
Status: open
Priority: 0/
Queue: CGI-SSI

People
Owner: Nobody in particular
Requestors: cpan_bugs_NOSPAMPLEASE [...] insaner.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: rt.cpan.org #35933 -- patch
Date: Sun, 08 Sep 2013 06:22:24 -0400
To: bug-CGI-SSI [...] rt.cpan.org
From: insaner <cpan_bugs_NOSPAMPLEASE [...] insaner.com>
Hi JAMES and colin.fine (and whoever else will read this),

I just installed CGI::SSI and immediately ran into bug request #35933 "'echo' doesn't support the 'encoding' parameter" (dated 2008??) where having the encoding set in the echo directive does causes the echo to not print anything.

so I decided to poke around the code and see if I could fix it. After trying a couple simple things, I found a (sort of) workaround. If you move the "encoding" bit to after the "var" bit, it prints the var's value fine, in other words, if you change this:

<!--#echo encoding="none" var="extra_header_tags" -->

to this:

<!--#echo var="extra_header_tags" encoding="none" -->

it seems to do the trick. But, apparently it breaks normal apache ssi directives.. strange (a bug for that needs to be filed I guess). Some more poking, and I wrote up a bit of code that fixes it for me. I have attached a patch. Hopefully one of you can turn this into 0.93 if everything is in order. I tried my best to keep to the module's programming indentation etc, hope that's ok too.

--
-insaner
http://www.insaner.com


Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 765b
On Sun Sep 08 06:11:15 2013, cpan_bugs_NOSPAMPLEASE@insaner.com wrote: Show quoted text
> Hi JAMES and colin.fine (and whoever else will read this), > > I just installed CGI::SSI and immediately ran into bug request #35933 > "'echo' > doesn't support the 'encoding' parameter" (dated 2008??)
[...] Show quoted text
> so I decided to poke around the code and see if I could fix it.
[...] Show quoted text
> > -- > -insaner > http://www.insaner.com
All that poking around let to me rewriting the EVAL engine, and fixing a few other things along the way, resulting in an official fork of CGI::SSI which I named: CGI::apacheSSI, [ http://search.cpan.org/~insaner/CGI-apacheSSI/lib/CGI/apacheSSI.pm ]. Go check it out and let me know what you think. I'm still working on a few bugs to be fixed in the next release.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.