Skip Menu |
 

This queue is for tickets about the Devel-Declare CPAN distribution.

Report information
The Basics
Id: 88476
Status: open
Priority: 0/
Queue: Devel-Declare

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.006014
Fixed in: (no value)



Subject: update stolen_chunk_of_toke.c
Download (untitled) / with headers
text/plain 1.1k
13:26 * p5commits Karl Williamson pushed to blead (v5.19.3-357-g842991a): Karl Williamson: PATCH: [perl #119601] Bleadperl breaks ETHER/Devel-Declare; http://perl5.git.perl.org/perl.git/commitdiff/842991ae 13:27 <@khw> ether, mst ^^^^^^^^^^^^^ 13:27 <@khw> It says in the comments to blame mst if stealing toke.c created problems; consider that done 13:31 <@ether> heh 13:32 <@ether> does Devel::Declare need patching? 13:33 < chansen> haha, "stealing .c from the core" :) 13:36 <@khw> chansen, at least he had the honesty to name the file "stolen_chunk_of_toke.c" 13:36 <@khw> ether, it depends on the definition of 'need' 13:37 <@khw> D::D should now compile and run successfully 13:37 <@khw> as-is 13:37 <@ether> was it broken under any stable or dev release, or just blead-up-until-just-now? 13:37 <@khw> only blead 13:37 <@ether> in other words: when did it start being broken? 13:37 <@ether> ok cool 13:38 * ether has nothing to see here, moves along, moves along :) 13:38 <@ether> and thanks! 13:40 <@khw> ether, There may be changes to toke.c that D:D should track. I gather that this was such an attempt that lost a detail.
Download (untitled) / with headers
text/plain 411b
Aesthetically, the call to utf8_to_uvchr_buf() should cast the second parameter to U8* too. I know there are plans to deprecate using literal control characters as single char punctuation. You might consider looking at the history of this file for other changes. And is there an API that could be written that accomplished what you need without having to copy code and then try to keep in sync with changes?


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.