Skip Menu |
 

This queue is for tickets about the autodie CPAN distribution.

Report information
The Basics
Id: 88444
Status: resolved
Priority: 0/
Queue: autodie

People
Owner: Nobody in particular
Requestors: shay [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.20
Fixed in: (no value)



Subject: [PATCH] Sync utime.t with bleadperl
Download (untitled) / with headers
text/plain 526b
The attached patch syncs the utime.t test script with a minor change in bleadperl to stop Git from flagging the touch_me file as having been changed after the test has run. Please could you incorporate this change into a future CPAN release? It isn't urgent but if you were able to do this before 20th September when the next release of bleadperl is due I would be very grateful. (I note that you've also spotted another patch to a test script in #88076. The two patches between them get things fully in sync with bleadperl.)
Subject: touch_me.patch
Download touch_me.patch
text/x-diff 825b
diff -ruN autodie-2.20.orig/t/utime.t autodie-2.20/t/utime.t --- autodie-2.20.orig/t/utime.t 2013-06-24 00:08:50.000000000 +0100 +++ autodie-2.20/t/utime.t 2013-09-05 17:58:37.703234200 +0100 @@ -10,9 +10,15 @@ eval { utime(undef, undef, NO_SUCH_FILE); }; isa_ok($@, 'autodie::exception', 'exception thrown for utime'); +my($atime, $mtime) = (stat TOUCH_ME)[8, 9]; + eval { utime(undef, undef, TOUCH_ME); }; ok(! $@, "We can utime a file just fine.") or diag $@; eval { utime(undef, undef, NO_SUCH_FILE, TOUCH_ME); }; isa_ok($@, 'autodie::exception', 'utime exception on single failure.'); is($@->return, 1, "utime fails correctly on a 'true' failure."); + +# Reset timestamps so that Git doesn't think the file has changed when +# running the test in the core perl distribution. +utime($atime, $mtime, TOUCH_ME);
Download (untitled) / with headers
text/plain 311b
Done (on CPAN as 2.22)! Apologies for not hitting the September 20th deadline; I've been madly running around the desert with no internet access, and then blinded by the fact that I was speaking at YAPC::Asia. Unless it still counts as September 20th in your timezone, in whcih case, you're welcome. :) Paul


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.