Skip Menu |
 

This queue is for tickets about the Data-Structure-Util CPAN distribution.

Report information
The Basics
Id: 88257
Status: open
Priority: 0/
Queue: Data-Structure-Util

People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
PLICEASE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Test failures under perl 5.19.4-to-be
Download (untitled) / with headers
text/plain 269b
t/06signature.t tests to make sure that signature(undef) will give different values each time. Due to a perl bug fix, this is no longer the case. Since this test seems to be testing Perl behaviour, rather than Data::Structure::Util behaviour, why not just delete it?
Download (untitled) / with headers
text/plain 416b
On Thu Aug 29 09:12:14 2013, SPROUT wrote: Show quoted text
> t/06signature.t tests to make sure that signature(undef) will give > different values each time. Due to a perl bug fix, this is no longer > the case. Since this test seems to be testing Perl behaviour, rather > than Data::Structure::Util behaviour, why not just delete it?
The attached patch does just that. I leave it to you to decide whether this is the best fix.
Subject: open_07AGUfm4.txt
Download open_07AGUfm4.txt
text/plain 718b
diff -rup Data-Structure-Util-0.15-crimpK-orig/t/06signature.t Data-Structure-Util-0.15-crimpK/t/06signature.t --- Data-Structure-Util-0.15-crimpK-orig/t/06signature.t 2008-03-09 03:48:59.000000000 -0700 +++ Data-Structure-Util-0.15-crimpK/t/06signature.t 2013-09-01 17:11:26.000000000 -0700 @@ -21,7 +21,7 @@ BEGIN { } } -use Test::More tests => 16; +use Test::More tests => 14; ok( 1, "we loaded fine..." ); @@ -62,8 +62,6 @@ isnt( signature( $obj4 ), $sig4, "Signat ok( signature(), "none" ); is( signature(), signature(), "empty list" ); -ok( my $sigundef = signature( undef ), "none" ); -isnt( $sigundef, signature( undef ), "none" ); # BELOW THIS LINE REQUIRES PERL 5.8.0 OR GREATER SKIP: {
Download (untitled) / with headers
text/plain 161b
Ping! The change in perl was v5.19.3-16-gce0d59f. Related ticket on bleadperl: https://rt.perl.org/rt3/Ticket/Display.html?id=119433 5.20-RC1 is out! Cheers,
And now Perl 5.20.0 is out. Would love to see this distribution updated. Thanks! David
Looks like this is fixed in 0.16, yes?
Download (untitled) / with headers
text/plain 116b
On Mon Apr 06 15:08:22 2015, DWHEELER wrote: Show quoted text
> Looks like this is fixed in 0.16, yes?
It does work for me in 5.20.2


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.