Skip Menu |
 

This queue is for tickets about the Devel-Size CPAN distribution.

Report information
The Basics
Id: 88180
Status: patched
Priority: 0/
Queue: Devel-Size

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: wrong test for magicalness
Date: Tue, 27 Aug 2013 15:57:35 +0100
To: bug-Devel-Size [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 202b
Devel::Size looks at the SvMAGIC pointer for any SV that's SVt_PVMG or above. This is incorrect. It is actually necessary (and sufficient) to check the SvMAGICAL flag. Attached patch fixes. -zefram
Download sv_magical.patch
text/x-diff 276b

Message body is not shown because sender requested not to inline it.

From: d.thomas [...] its.uq.edu.au
Download (untitled) / with headers
text/plain 512b
building under 5.19.6 results in test FAILure which does not happen on 5.18.2-RC2 t/magic.t ..... 1/18 # Failed test 'the magic object is counted' # at t/magic.t line 55. # '1248' # > # '1256' # Looks like you failed 1 test of 18. t/magic.t ..... Dubious, test returned 1 (wstat 256, 0x100) this is on RHEL6. Devel-Size-0.79 On Tue Aug 27 10:57:56 2013, zefram@fysh.org wrote: Show quoted text
> Attached patch fixes.
on the off chance the patch might help, I applied it but got the same error condition
Subject: Re: [rt.cpan.org #88180] wrong test for magicalness
Date: Sun, 15 Dec 2013 10:55:16 +0000
To: d.thomas [...] its.uq.edu.au, "d.thomas [...] its.uq.edu.au via RT" <bug-Devel-Size [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 247b
d.thomas@its.uq.edu.au via RT wrote: Show quoted text
>t/magic.t ..... 1/18 ># Failed test 'the magic object is counted' ># at t/magic.t line 55. ># '1248' ># > ># '1256'
That's [rt.cpan.org #88182]. Patch available on that ticket. -zefram
Download (untitled) / with headers
text/plain 411b
On Tue Aug 27 10:57:56 2013, zefram@fysh.org wrote: Show quoted text
> Devel::Size looks at the SvMAGIC pointer for any SV that's SVt_PVMG > or above. This is incorrect. It is actually necessary (and sufficient) > to check the SvMAGICAL flag. Attached patch fixes.
Thanks applied. Along with your other patch, uploaded to CPAN as 0.79_50. I'm aware that the uploaded version still fails some other tests on some versions.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.