Skip Menu |
 

This queue is for tickets about the MozRepl-RemoteObject CPAN distribution.

Report information
The Basics
Id: 88100
Status: resolved
Priority: 0/
Queue: MozRepl-RemoteObject

People
Owner: Nobody in particular
Requestors: daniel.stadie [...] jgency.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: MozRepl::RemoteObject dies due to too generic regex in mozrepl continuation prompt check
Date: Sun, 25 Aug 2013 13:47:38 +0200
To: bug-MozRepl-RemoteObject [...] rt.cpan.org
From: Daniel Stadie <daniel.stadie [...] jgency.de>
Hi, version information: perl perl 5, version 14, subversion 2 (v5.14.2) built for x86_64-linux-gnu-thread-multi WWW::Mechanize::Firefox 0.74 perl module MozRepl::RemoteObject 0.36 firefox mozrepl addon 1.1.2 firefox 17.0.8 ESR description: In MozRepl::RemoteObject a regex intended to find mozRepl continuation prompts is to generic so it fails on some html input: wired HTML like content="example.&gt;br&gt;" is parsed to content=\"example.>br>\" which results in: Continuation prompt found in [{"status":"ok","result":{"result":[{"result":"<html><head><meta name=\"description\" content=\"example.>br>\">\n</head><body>\n\n<p>sample</p>\n\n\n</body></html>","type":null},{"result":"ISO-8859-1","type":null}],"type":"list"}}] at /usr/local/perl/lib/perl5/MozRepl/RemoteObject.pm line 217. steps to reproduce: sample script and data attached patch: attached Thanks for your great work on WWW::Mechanize::Firefox and your varoius other modules! Cheers, Daniel.
Download sample.html
text/html 122b

Message body is not shown because sender requested not to inline it.

Download remoteobject.patch
text/x-diff 312b

Message body is not shown because sender requested not to inline it.

Download reproduce.pl
text/x-perl 193b

Message body is not shown because sender requested not to inline it.

RT-Send-CC: daniel.stadie [...] jgency.de
Download (untitled) / with headers
text/plain 204b
Thanks for the comprehensive diagnosis and patch! Verified, applied and released as 0.37, which is uploading to CPAN. The test went into the WWW::Mechanize::Firefox distribution out of lazyness :) -max


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.