Skip Menu |
 

This queue is for tickets about the Kwiki-ModPerl CPAN distribution.

Report information
The Basics
Id: 87450
Status: new
Priority: 0/
Queue: Kwiki-ModPerl

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.09
Fixed in: (no value)

Attachments
Kwiki-ModPerl-0.09-Parenthesise-qw-explicitly.patch



Subject: Syntax error with perl 5.18
Download (untitled) / with headers
text/plain 857b
Perl 5.18 does not put implicit parentheses around qw operator anymore. That causes syntax error and the only test failure: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/compile.t .. 1/1 # Failed test 'use Kwiki::ModPerl;' # at t/compile.t line 7. # Tried to use 'Kwiki::ModPerl'. # Error: syntax error at lib/Kwiki/ModPerl.pm line 12, near "->import qw(:common)" # syntax error at lib/Kwiki/ModPerl.pm line 19, near "->import qw(:common)" # BEGIN not safe after errors--compilation aborted at lib/Kwiki/ModPerl.pm line 26. # Compilation failed in require at t/compile.t line 7. # BEGIN failed--compilation aborted at t/compile.t line 7. # Looks like you failed 1 test of 1. t/compile.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
From: ppisar [...] redhat.com
Download (untitled) / with headers
text/plain 213b
Dne Út 30.čec.2013 13:08:37, ppisar napsal(a): Show quoted text
> Perl 5.18 does not put implicit parentheses around qw operator > anymore. That causes syntax error and the only test failure: >
Attached patch fixes it. -- Petr
Subject: Kwiki-ModPerl-0.09-Parenthesise-qw-explicitly.patch
From d0b04114b33ee997e2f4eb5d0f56126616ad21d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 30 Jul 2013 19:04:39 +0200 Subject: [PATCH] Parenthesise qw explicitly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Perl 5.18 stopped to put surrounding parentheses around qw operator. Current code causes would cause syntax error. <https://rt.cpan.org/Public/Bug/Display.html?id=87450> Signed-off-by: Petr Písař <ppisar@redhat.com> --- lib/Kwiki/ModPerl.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Kwiki/ModPerl.pm b/lib/Kwiki/ModPerl.pm index f5a2140..6ba42f2 100644 --- a/lib/Kwiki/ModPerl.pm +++ b/lib/Kwiki/ModPerl.pm @@ -9,14 +9,14 @@ BEGIN { require Apache2::RequestUtil; require Apache2::RequestIO; require Apache2::Const; - Apache2::Const->import qw(:common); + Apache2::Const->import( qw/:common/); } else { if ( $mod_perl::VERSION >= 1.99 ) { require Apache::RequestRec; require Apache::RequestUtil; require Apache::RequestIO; require Apache::Const; - Apache::Const->import qw(:common); + Apache::Const->import( qw/:common/); } else { require Apache; require Apache::Constants; -- 1.8.1.4


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.