Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DBIx-Class-Helpers CPAN distribution.

Report information
The Basics
Id: 87311
Status: resolved
Priority: 0/
Queue: DBIx-Class-Helpers

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
DBIx-Class-Helpers-2.018001-returnand.patch



Subject: [PATCH] wrong return precedence
Download (untitled) / with headers
text/plain 135b
returns binds stronger than and, so the expressions after and are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: DBIx-Class-Helpers-2.018001-returnand.patch
diff -bu ./t/row/numifyget.t~ ./t/row/numifyget.t --- ./t/row/numifyget.t~ 2013-07-02 20:40:24.000000000 -0500 +++ ./t/row/numifyget.t 2013-07-25 10:01:23.852572001 -0500 @@ -19,9 +19,9 @@ my $value = shift; my $b_obj = B::svref_2object(\$value); my $flags = $b_obj->FLAGS; - return ( $flags & B::SVf_IOK or $flags & B::SVp_IOK + return (( $flags & B::SVf_IOK or $flags & B::SVp_IOK or $flags & B::SVf_NOK or $flags & B::SVp_NOK - ) and !($flags & B::SVf_POK ) + ) and !($flags & B::SVf_POK )) } ok(is_numeric($schema->resultset('Foo')->first->bar_id),"bar_id has been 'numified' w/o is_numeric set");
fix released


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.