Skip Menu |
 

This queue is for tickets about the JavaScript-MochiKit CPAN distribution.

Report information
The Basics
Id: 87310
Status: new
Priority: 0/
Queue: JavaScript-MochiKit

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
JavaScript-MochiKit-0.04-returnand.patch



Subject: [PATCH] wrong return precedence
Download (untitled) / with headers
text/plain 189b
returns binds stronger than and, so the expressions after and are ignored. That's why the 2nd shift error was not even detected See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: JavaScript-MochiKit-0.04-returnand.patch
difforig diff -u ./lib/JavaScript/MochiKit/Module.pm.orig --- ./lib/JavaScript/MochiKit/Module.pm.orig 2013-07-25 09:49:17.799084826 -0500 +++ ./lib/JavaScript/MochiKit/Module.pm 2013-07-25 09:48:35.311466614 -0500 @@ -6,8 +6,8 @@ __PACKAGE__->mk_accessors(qw[ name required javascript_definition ]); sub javascript_loaded { - return defined shift->javascript_definition - and shift->javascript_definition ne ''; + return (defined $_[0]->javascript_definition + and $_[0]->javascript_definition ne ''); } 1;


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.