Skip Menu |
 

This queue is for tickets about the Perl-Critic-Pulp CPAN distribution.

Report information
The Basics
Id: 87307
Status: resolved
Priority: 0/
Queue: Perl-Critic-Pulp

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: [PATCH] fat comma quoting fixed
Download (untitled) / with headers
text/plain 137b
t/UnexpandedSpecialLiteral.t checks for a perl bug which was fixed recently, with commit 21791330af556dc attached patch adjusts the test
Subject: Perl-Critic-Pulp-79-fatcomma.patch
diff -bu ./t/UnexpandedSpecialLiteral.t~ ./t/UnexpandedSpecialLiteral.t --- ./t/UnexpandedSpecialLiteral.t~ 2013-03-15 18:45:39.000000000 -0500 +++ ./t/UnexpandedSpecialLiteral.t 2013-07-25 09:27:20.838863482 -0500 @@ -53,15 +53,26 @@ is_deeply (\@h, [ 'Foo__FILE__', 123 ], 'hash constructor literal on right of a . expression'); } +# fat comma quoting fixed with 5.19.2 21791330af556dc { my @array = (__PACKAGE__ => 123); + if ($] >= 5.019002) { + is_deeply (\@array, [ '__PACKAGE__', 123 ], + "fat comma quotes across newline"); + } else { is_deeply (\@array, [ 'main', 123 ], "fat comma doesn't quote across newline"); + } } { my @array = (__PACKAGE__ # and with a comment => 123); + if ($] >= 5.019002) { + is_deeply (\@array, [ '__PACKAGE__', 123 ], + "fat comma quotes across newline"); + } else { is_deeply (\@array, [ 'main', 123 ], "fat comma doesn't quote across comment and newline"); + } }
Download (untitled) / with headers
text/plain 215b
Thanks. I've commented out those tests for now in version 80. If that quoting across newline is adopted into whatever next stable perl then I suppose my policy bit should be extended to report them unexpanded too.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.