Skip Menu |
 

This queue is for tickets about the Dist-Zilla-Role-ModuleIncluder CPAN distribution.

Report information
The Basics
Id: 87305
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Role-ModuleIncluder

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
Dist-Zilla-Role-ModuleIncluder-0.002-returnor.patch



Subject: [PATCH] wrong return precedence
Download (untitled) / with headers
text/plain 138b
returns binds stronger than and/or, so the expressions after and are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: Dist-Zilla-Role-ModuleIncluder-0.002-returnor.patch
diff -bu ./lib/Dist/Zilla/Role/ModuleIncluder.pm~ ./lib/Dist/Zilla/Role/ModuleIncluder.pm --- ./lib/Dist/Zilla/Role/ModuleIncluder.pm~ 2012-03-31 10:42:54.000000000 -0500 +++ ./lib/Dist/Zilla/Role/ModuleIncluder.pm 2013-07-25 08:45:16.305408201 -0500 @@ -27,7 +27,7 @@ ## no critic (Variables::ProhibitPackageVars) sub _core_has { my ($module, $wanted_version, $background_perl) = @_; - return exists $version->{$background_perl}{$module} and $version->{$background_perl}{$module} >= $wanted_version || 0 >= $wanted_version; + return (exists $version->{$background_perl}{$module} and $version->{$background_perl}{$module} >= $wanted_version || 0 >= $wanted_version); } sub _get_reqs {


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.