Skip Menu |
 

This queue is for tickets about the Auth-GoogleAuthenticator CPAN distribution.

Report information
The Basics
Id: 87228
Status: new
Priority: 0/
Queue: Auth-GoogleAuthenticator

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
Auth-GoogleAuthenticator-0.01-returnand.patch



Subject: [PATCH] wrong return precedence
Download (untitled) / with headers
text/plain 135b
returns binds stronger than and, so the expressions after and are ignored. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: Auth-GoogleAuthenticator-0.01-returnand.patch
diff -bu Auth-GoogleAuthenticator-0.01-1p_stP/lib/Auth/GoogleAuthenticator.pm~ Auth-GoogleAuthenticator-0.01-1p_stP/lib/Auth/GoogleAuthenticator.pm --- Auth-GoogleAuthenticator-0.01-1p_stP/lib/Auth/GoogleAuthenticator.pm~ 2013-02-22 06:48:10.000000000 -0600 +++ Auth-GoogleAuthenticator-0.01-1p_stP/lib/Auth/GoogleAuthenticator.pm 2013-07-23 16:03:33.045126098 -0500 @@ -54,8 +54,8 @@ sub verify { my ($self, $code, $ts) = @_; - return $code and - $self->totp( $ts ) == $code; + return $code && + ($self->totp( $ts ) == $code); } 1;


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.