|Subject:||Suggested patch - bug fixes|
|Date:||Sat, 20 Jul 2013 11:34:59 -0700|
|To:||bug-Shell-GetEnv [...] rt.cpan.org|
|From:||"Marty O'Brien" <mobrule [...] gmail.com>|
Hi Dr. Jerius, I downloaded the Shell::GetEnv distribution and have been playing around with it this week. I have two suggested patches to the Shell::GetEnv distribution. The first one is a bug/build fix, which I've enclosed in this message. The second is an enhancement, which I'll include in a separate message. This patch addresses two issues encountered with building the distribution on Cygwin: (1) environment variables with shell metacharacters in the variable name (not just in the variable value). This is common on Cygwin which inherits its environment from Windows and can have variable names like "CommonFiles(x86)", but this could happen on other systems, too. (2) Cygwin can insert the variable "_" into the environment on its own, much as you discovered some systems will create the variable "RANDOM". Including this string in the "Exclude" list of the Shell::GetEnv::envs call will help this distribution to pass the t/diffsonly.t tests on Cygwin. Suggested patch enclosed. Marty O'Brien email@example.com
Message body is not shown because sender requested not to inline it.