Skip Menu |
 

This queue is for tickets about the Shell-GetEnv CPAN distribution.

Report information
The Basics
Id: 87110
Status: resolved
Priority: 0/
Queue: Shell-GetEnv

People
Owner: Nobody in particular
Requestors: mobrule [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.09

Attachments


Subject: Suggested patch - bug fixes
Date: Sat, 20 Jul 2013 11:34:59 -0700
To: bug-Shell-GetEnv [...] rt.cpan.org
From: "Marty O'Brien" <mobrule [...] gmail.com>
Download (untitled) / with headers
text/plain 1023b
Hi Dr. Jerius, I downloaded the Shell::GetEnv distribution and have been playing around with it this week. I have two suggested patches to the Shell::GetEnv distribution. The first one is a bug/build fix, which I've enclosed in this message. The second is an enhancement, which I'll include in a separate message. This patch addresses two issues encountered with building the distribution on Cygwin: (1) environment variables with shell metacharacters in the variable name (not just in the variable value). This is common on Cygwin which inherits its environment from Windows and can have variable names like "CommonFiles(x86)", but this could happen on other systems, too. (2) Cygwin can insert the variable "_" into the environment on its own, much as you discovered some systems will create the variable "RANDOM". Including this string in the "Exclude" list of the Shell::GetEnv::envs call will help this distribution to pass the t/diffsonly.t tests on Cygwin. Suggested patch enclosed. Marty O'Brien mob@cpan.org

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 1010b
Marty, Sorry for the late reply. On Sat Jul 20 14:35:14 2013, mobrule@gmail.com wrote: Show quoted text
> Hi Dr. Jerius,
Just Diab, please. Show quoted text
> This patch addresses two issues encountered with building the distribution > on Cygwin: > > (1) environment variables with shell metacharacters in the variable name > (not just in the variable value). This is common on Cygwin which inherits > its environment from Windows and can have variable names like > "CommonFiles(x86)", but this could happen on other systems, too. > > (2) Cygwin can insert the variable "_" into the environment on its own, > much as you discovered some systems will create the variable "RANDOM". > Including this string in the "Exclude" list of the Shell::GetEnv::envs call > will help this distribution to pass the t/diffsonly.t tests on Cygwin. >
These all sound good, but I've got to ask: Where did you find a version with the RANDOM fix? As far as I know I haven't even checked that code into my local repository, let alone made it public. Diab
Download (untitled) / with headers
text/plain 1.2k
On Tue Aug 13 15:49:14 2013, DJERIUS wrote: Show quoted text
> Marty, > > Sorry for the late reply. > > On Sat Jul 20 14:35:14 2013, mobrule@gmail.com wrote:
> > Hi Dr. Jerius,
> > Just Diab, please. >
> > This patch addresses two issues encountered with building the > > distribution > > on Cygwin: > > > > (1) environment variables with shell metacharacters in the variable > > name > > (not just in the variable value). This is common on Cygwin which > > inherits > > its environment from Windows and can have variable names like > > "CommonFiles(x86)", but this could happen on other systems, too. > > > > (2) Cygwin can insert the variable "_" into the environment on its > > own, > > much as you discovered some systems will create the variable > > "RANDOM". > > Including this string in the "Exclude" list of the > > Shell::GetEnv::envs call > > will help this distribution to pass the t/diffsonly.t tests on > > Cygwin. > >
> > These all sound good, but I've got to ask: > > Where did you find a version with the RANDOM fix? As far as I know I > haven't > even checked that code into my local repository, let alone made it > public. > > Diab
Ooops. It looks like I did release an 0.08_01 to CPAN. Don't ask me how that happened... Diab
Download (untitled) / with headers
text/plain 872b
On Sat Jul 20 14:35:14 2013, mobrule@gmail.com wrote: Show quoted text
> This patch addresses two issues encountered with building the distribution > on Cygwin: > > (1) environment variables with shell metacharacters in the variable name > (not just in the variable value). This is common on Cygwin which inherits > its environment from Windows and can have variable names like > "CommonFiles(x86)", but this could happen on other systems, too. > > (2) Cygwin can insert the variable "_" into the environment on its own, > much as you discovered some systems will create the variable "RANDOM". > Including this string in the "Exclude" list of the Shell::GetEnv::envs call > will help this distribution to pass the t/diffsonly.t tests on Cygwin.
Marty, I've just uploaded 0.08_02 to CPAN which should (hopefully) address these problems. Thanks for your bug report and patches. Diab
There's finally a non-development release (0.09) with your fix. Thanks!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.