Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 87032
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.120



Subject: wrong return precedence in Perl::Critic::Utils::interpolate
Download (untitled) / with headers
text/plain 312b
Please patch Perl::Critic::Utils, line 334: < return eval "\"$literal\"" or confess $EVAL_ERROR; ## no critic (StringyEval); Show quoted text
> return (eval "\"$literal\"" || confess $EVAL_ERROR); ## no critic (StringyEval);
the or confess is ignored otherwise. See https://rt.perl.org/rt3/Public/Bug/Display.html?id=59802
Subject: Re: [rt.cpan.org #87032] wrong return precedence in Perl::Critic::Utils::interpolate
Date: Fri, 26 Jul 2013 15:26:25 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 320b
Good catch Reini. This will be the first bug we fix when we after we move to GitHub (should be any day now). https://rt.cpan.org/Public/Bug/Display.html?id=86973 I'll also make a TODO about writing a policy to detect this, since it doesn't seem like perl is ever going to warn about it. Have a great weekend! -Jeff
Subject: Re: [rt.cpan.org #87032] wrong return precedence in Perl::Critic::Utils::interpolate
Date: Mon, 29 Jul 2013 12:03:03 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Reini Urban <rurban [...] x-ray.at>
Download (untitled) / with headers
text/plain 761b
On Fri, Jul 26, 2013 at 5:26 PM, Jeffrey Thalhammer via RT <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=87032 > > > Good catch Reini. This will be the first bug we fix when we after we move > to GitHub (should be any day now). > https://rt.cpan.org/Public/Bug/Display.html?id=86973
Thanks Show quoted text
> I'll also make a TODO about writing a policy to detect this, since it > doesn't seem like perl is ever going to warn about it.
perl will warn about it soon :) That's how I detected it. See http://blogs.perl.org/users/rurban/2013/07/smoking-cpan.html and https://github.com/rurban/perl/commit/f86e1520a36f9b53a86479515c0e8e96814e20ee for the new warning. -- Reini Urban http://cpanel.net/ http://www.perl-compiler.org/
RT-Send-CC: jeff [...] imaginative-software.com
On Mon Jul 29 13:03:23 2013, rurban@x-ray.at wrote: Show quoted text
> On Fri, Jul 26, 2013 at 5:26 PM, Jeffrey Thalhammer via RT > <bug-Perl-Critic@rt.cpan.org> wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=87032 > > > > > Good catch Reini. This will be the first bug we fix when we after we > > move > > to GitHub (should be any day now). > > https://rt.cpan.org/Public/Bug/Display.html?id=86973
Hi Jeff, Reini, I ran into this issue when trying installing Perl::Cricit::Pulp on perl 5.19.5. This uses something like Test::Nowarnings in the test suite, so tests started failing for this module. I found this bug report and apparently there *is* a github repo but also I found a new release of Perl::Critic on CPAN which DOES have a fix for this RT in it, but apparently is still released from SVN because the github repo does NOT have the fix: https://github.com/Perl-Critic/Perl-Critic/blob/master/lib/Perl/Critic/Utils.pm#L334 So basically; 1.120 fixed this RT for me so it can be closed AND the github repo is not leading (yet).
Subject: Re: [rt.cpan.org #87032] wrong return precedence in Perl::Critic::Utils::interpolate
Date: Thu, 31 Oct 2013 11:41:47 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Ryan Thalhammer <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 348b
On Oct 29, 2013, at 7:51 AM, Michiel Beijen via RT wrote: Show quoted text
> So basically; 1.120 fixed this RT for me so it can be closed AND the github repo is not leading (yet).
The GitHub repo is now sync'd up with Subversion (actually, GitHub is now ahead). The next release (1.121) will come from GitHub. After that, the Subversion repo will be abandoned.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.