Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 86973
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: TIMB [...] cpan.org
Cc: andreas.marienborg [...] gmail.com
frioux [...] gmail.com
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: andreas.marienborg [...] gmail.com, frioux [...] gmail.com
Subject: Migrate from svn to github
Download (untitled) / with headers
text/plain 109b
I'm opening a new ticket to track this - see https://rt.cpan.org/Ticket/Display.html?id=86942 for background.
RT-Send-CC: andreas.marienborg [...] gmail.com, jeff [...] imaginative-software.com
Download (untitled) / with headers
text/plain 196b
Andreas, if you give me your github id I'll add you to the organization: https://github.com/organizations/Perl-Critic Jeff, what were your plans re the two repos Perl-Critic and Perl-Critic-Core?
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Wed, 17 Jul 2013 06:55:25 +0700
To: "bug-Perl-Critic [...] rt.cpan.org" <bug-Perl-Critic [...] rt.cpan.org>
From: Andreas Marienborg <andreas.marienborg [...] gmail.com>
Download (untitled) / with headers
text/plain 377b
My username is omega - a On 17. juli 2013, at 00:36, "Tim_Bunce via RT" <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=86973 > > > Andreas, if you give me your github id I'll add you to the organization: https://github.com/organizations/Perl-Critic > > Jeff, what were your plans re the two repos Perl-Critic and Perl-Critic-Core?
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Wed, 17 Jul 2013 07:32:14 +0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Andreas Marienborg <andreas.marienborg [...] gmail.com>
Download (untitled) / with headers
text/plain 447b
Does anyone have a full name and email for the svn user "robearl"? He wasn't in frews script On Jul 17, 2013, at 12:36 AM, "Tim_Bunce via RT" <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=86973 > > > Andreas, if you give me your github id I'll add you to the organization: https://github.com/organizations/Perl-Critic > > Jeff, what were your plans re the two repos Perl-Critic and Perl-Critic-Core?
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Tue, 16 Jul 2013 23:30:04 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 126b
Show quoted text
> Does anyone have a full name and email for the svn user "robearl"? He
wasn't in frews script Rob Earl rob.earl@gmail.com>
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Tue, 16 Jul 2013 23:31:38 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 175b
Show quoted text
> > Jeff, what were your plans re the two repos Perl-Critic and > Perl-Critic-Core? >
If I had a plan, I don't remember what it was. I have deleted them both. Fire at will.
RT-Send-CC: andreas.marienborg [...] gmail.com
Download (untitled) / with headers
text/plain 219b
Andreas, you're a member of https://github.com/Perl-Critic now. I've created a repo at git@github.com:Perl-Critic/perl-critic.git Feel free to push when you've got a migration that meets Jeff's requirements. Thanks!
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Wed, 17 Jul 2013 16:33:26 +0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Andreas Marienborg <andreas.marienborg [...] gmail.com>
Download (untitled) / with headers
text/plain 558b
Yeah, I'm trying but boy are there some interesting things in the history there :P I'll see how far I will get, but my time is limited between now and monday unfortunately On Jul 17, 2013, at 4:29 PM, "Tim_Bunce via RT" <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=86973 > > > Andreas, you're a member of https://github.com/Perl-Critic now. > > I've created a repo at git@github.com:Perl-Critic/perl-critic.git > > Feel free to push when you've got a migration that meets Jeff's requirements. > > Thanks! >
Download (untitled) / with headers
text/plain 639b
On Wed Jul 17 05:33:33 2013, ANDREMAR wrote: Show quoted text
> Yeah, I'm trying but boy are there some interesting things in the > history there :P I'll see how far I will get, but my time is limited > between now and monday unfortunately >
Welcome to the wonderful world of subversion to git conversions! Graham Knop aka HAARG, who converted the DBIC repo, has gotten a better conversion than mine going, in part based on my work, though not much. Here is the web url: http://git.haarg.org/gknop/Test-Perl-Critic.git, and here is the url you can clone and look at locally: git://git.haarg.org/gknop/Perl-Critic As far as I can tell this is complete.
Download (untitled) / with headers
text/plain 349b
browser: http://git.haarg.org/gknop/Perl-Critic.git clone: git://git.haarg.org/gknop/Perl-Critic.git browser: http://git.haarg.org/gknop/Test-Perl-Critic.git clone: git://git.haarg.org/gknop/Test-Perl-Critic.git The browser can be a bit unstable the way I have it set up. If these look good, I can work on converting the other things in the repo.
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Sat, 20 Jul 2013 11:06:36 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Ryan Thalhammer <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 193b
On Jul 20, 2013, at 7:33 AM, Graham Knop via RT wrote: Show quoted text
> If these look good, I can work on converting the other things in the repo.
I will look at these later today. Thanks so much! -Jeff
Download (untitled) / with headers
text/html 1015b
Download (untitled) / with headers
text/plain 208b
On Wed Jul 17 02:29:41 2013, TIMB wrote: Show quoted text
> I've created a repo at git@github.com:Perl-Critic/perl-critic.git
If it's alright with you, I would prefer to call the repo "Perl-Critic" rather than "perl-critic".
Download (untitled) / with headers
text/plain 1.2k
On Sat Jul 20 07:33:38 2013, haarg wrote: Show quoted text
> If these look good, I can work on converting the other things in the repo.
They both look great! There is one gotcha though: Most (maybe all) of the Perl-Critic-* distributions share a common Module::Build base class. We used an svn:external link to a directory located here: http://perlcritic.tigris.org/svn/perlcritic/trunk/distributions/common/inc/Perl/Critic/Module/Build Would it be possible to use a git submodule for that too? If not I can just live with duplicating the file in each repo. I won't be the end of the world. It looks like there will be some yak shaving to do before I can make a release from the new repo, but it won't be bad. And it will give me an excuse to set up Dist::Zilla here. The only projects to move at this time are Perl-Critic, Test-Perl-Critic, Test-Perl-Critic-Progressive, Perl-Critic-More, Perl-Critic-Dynamic, Perl-Critic-StricterSubs, criticism, and perlcritic.com. The others mostly belong to Elliot and I'm not sure he's ready to move (he's not a big fan of git). But you've already done so much -- don't feel pressured to do all those. I'll be completely stoked if we only get Perl-Critic moved! Thanks everyone for making this happen :)
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Sun, 21 Jul 2013 05:48:02 -0500
To: "bug-Perl-Critic [...] rt.cpan.org" <bug-Perl-Critic [...] rt.cpan.org>
From: Elliot Shank <perl [...] galumph.com>
Download (untitled) / with headers
text/plain 314b
On Jul 20, 2013, at 7:28 PM, "Jeffrey Ryan Thalhammer via RT" <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> Would it be possible to use a git submodule for that too? If not I can just live with duplicating the file in each repo. I won't be the end of the world.
Turn it into its own distro and use configure_requires?
Download (untitled) / with headers
text/plain 137b
Should we push the latest Perl-Critic and Test-Perl-Critic to github as they are now, and fix the Module::Build base-class problem later?
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Sun, 21 Jul 2013 10:05:57 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 203b
Show quoted text
> Should we push the latest Perl-Critic and Test-Perl-Critic to github as
they are now, and fix the Module::Build base-class problem later? Yes. I didn't mean to suggest this was a blocker. Push away.
RT-Send-CC: perl [...] galumph.com
Download (untitled) / with headers
text/plain 675b
I get a `access denied` when I try to clone Test-Perl-Critic: $ git clone git://git.haarg.org/gknop/Test-Perl-Critic.git test-perl-critic Cloning into 'test-perl-critic'... fatal: remote error: access denied or repository not exported: /gknop/Test-Perl-Critic.git In addition, I get a permission denied error when trying to push to the perl-critic.git repo created on github: $ git push --all -u origin ERROR: Permission to Perl-Critic/perl-critic.git denied to omega. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Maybe I am not in a team with the correct permissions in the organization?
Download (untitled) / with headers
text/plain 151b
Show quoted text
> If it's alright with you, I would prefer to call the repo "Perl-Critic" rather than "perl-critic".
Done: git@github.com:Perl-Critic/Perl-Critic.git
Download (untitled) / with headers
text/plain 674b
Show quoted text
> http://perlcritic.tigris.org/svn/perlcritic/trunk/distributions/common/inc/Perl/Critic/Module/Build > > Would it be possible to use a git submodule for that too? If not I can just live with duplicating the file in each repo. I won't be the end of the world.
I find using git subtree[*] _much_ more pleasant to work with that git submodules, which are fraught with traps for the unwary. Tim. [*] http://git-scm.com/book/en/Git-Tools-Subtree-Merging Here are a couple of random blog posts google found about it: http://blogs.atlassian.com/2013/05/alternatives-to-git-submodule-git-subtree/ http://psionides.eu/2010/02/04/sharing-code-between-projects-with-git-subtree/
RT-Send-CC: andreas.marienborg [...] gmail.com, haarg [...] haarg.org
On Mon Jul 22 06:25:19 2013, ANDREMAR wrote: Show quoted text
> I get a `access denied` when I try to clone Test-Perl-Critic: > > $ git clone git://git.haarg.org/gknop/Test-Perl-Critic.git test-perl- > critic > Cloning into 'test-perl-critic'... > fatal: remote error: access denied or repository not exported: > /gknop/Test-Perl-Critic.git
Hopefully Graham Knop (CC'd) can shed some light on that. Show quoted text
> In addition, I get a permission denied error when trying to push to > the perl-critic.git repo created on github: > > $ git push --all -u origin > ERROR: Permission to Perl-Critic/perl-critic.git denied to omega. > fatal: Could not read from remote repository. > > Please make sure you have the correct access rights > and the repository exists.
Jeff asked me to change the repo name to use capitals. You can see it at https://github.com/Perl-Critic/Perl-Critic Show quoted text
> Maybe I am not in a team with the correct permissions in the > organization?
Looks like you are: https://github.com/Perl-Critic?tab=members (Though you're membership was in the 'concealed' state - I've made it public now)
Download (untitled) / with headers
text/plain 384b
On Mon Jul 22 01:25:19 2013, ANDREMAR wrote: Show quoted text
> I get a `access denied` when I try to clone Test-Perl-Critic: > > $ git clone git://git.haarg.org/gknop/Test-Perl-Critic.git test-perl- > critic > Cloning into 'test-perl-critic'... > fatal: remote error: access denied or repository not exported: > /gknop/Test-Perl-Critic.git
I've fixed the permissions, so this should be clonable now.
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Sun, 28 Jul 2013 16:56:52 +0700
To: "bug-Perl-Critic [...] rt.cpan.org" <bug-Perl-Critic [...] rt.cpan.org>
From: Andreas Marienborg <andreas.marienborg [...] gmail.com>
Download (untitled) / with headers
text/plain 1.3k
On 27. juli 2013, at 18:12, "Tim_Bunce via RT" <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=86973 > > > On Mon Jul 22 06:25:19 2013, ANDREMAR wrote:
>> I get a `access denied` when I try to clone Test-Perl-Critic: >> >> $ git clone git://git.haarg.org/gknop/Test-Perl-Critic.git test-perl- >> critic >> Cloning into 'test-perl-critic'... >> fatal: remote error: access denied or repository not exported: >> /gknop/Test-Perl-Critic.git
> > Hopefully Graham Knop (CC'd) can shed some light on that. >
>> In addition, I get a permission denied error when trying to push to >> the perl-critic.git repo created on github: >> >> $ git push --all -u origin >> ERROR: Permission to Perl-Critic/perl-critic.git denied to omega. >> fatal: Could not read from remote repository. >> >> Please make sure you have the correct access rights >> and the repository exists.
> > Jeff asked me to change the repo name to use capitals. > You can see it at https://github.com/Perl-Critic/Perl-Critic >
>> Maybe I am not in a team with the correct permissions in the >> organization?
> > Looks like you are: https://github.com/Perl-Critic?tab=members > (Though you're membership was in the 'concealed' state - I've made it public now) > >
I've tried both. What kind of teams are setup for the org, and what permissions do those teams have on the repo? - a
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Sun, 28 Jul 2013 09:23:16 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 343b
Show quoted text
> > I've tried both. What kind of teams are setup for the org, and what > permissions do those teams have on the repo? >
I think it is fixed now. Tim added you to the Developers team, but we hadn't actually assigned any repos to that team. This is the first time I've tried managing an "organization" on GitHub. Sorry for the mixup. -Jeff
Thanks Jeff! (I'm new to github team management as well.)
Download (untitled) / with headers
text/plain 345b
Ok, I pushed * https://github.com/Perl-Critic/Test-Perl-Critic * https://github.com/Perl-Critic/Perl-Critic Please let me know if anything looks askew or wrong I don't know why https://github.com/Perl-Critic/Test-Perl-Critic/releases has the dates confused, but when I look at my clone, the tags look correct and the SHAs seem to be the same
Subject: Re: [rt.cpan.org #86973] Migrate from svn to github
Date: Mon, 29 Jul 2013 00:11:24 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 124b
That looks beau-tee-ful. Really. Thank you so much. So all are wonderful people. I can't wait to make the announcement.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.